On 12/05/2020 04:43, d.arunprakash via lists.opendaylight.org wrote:

Robert,

Hello Arun,

Verify build for Aluminum MRI review
https://git.opendaylight.org/gerrit/c/openflowplugin/+/89498 has passed,
could you please review it?

I did a partial review, there are a number of things wrong with the
changes, as noted in review.

I also worry about the number of blind conversions of 'getFoo()' to
'getFoo().values()'. As noted here:
https://docs.opendaylight.org/en/latest/release-notes/upgrade-process.html#binding-dtos-and-empty-lists,
in lists end up being empty for any reason, each of those call sites
will become a source of NPEs.

Aside from that, I cannot provide authority of whether the changes are
correct -- I am not an OFP committer after all.

Bye,
Robert