Re: [release] Silicon Code Freeze for SR2
|
Robert Varga
On 10/08/2021 18:43, Daniel de la Rosa wrote:
Hello RobertOkay, so I have a pretty good idea as to what is going on with RESTCONF. There actually are two problems based on comparison of current silicon an current phosphorus -- both of which are failing in the same test suite, but at different steps. What Silicon is seeing is this: https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netconf-csit-1node-userfeatures-rfc8040-all-silicon/301/robot-plugin/log.html.gz#s1-s6-s1-t2-k3 i.e. ODL rejects the request because it encounters a parsing failure while trying to update the datastore. I think this was broken by https://git.opendaylight.org/gerrit/c/netconf/+/83284. This failure is not present in Phosphorus, as I noticed this weirdness and eliminated the call to the source of the problem in https://git.opendaylight.org/gerrit/c/netconf/+/96268. Unfortunately that patch needs to be backported carefully, as it did a number of things that is not fair in a backport. This is tracked here: https://jira.opendaylight.org/browse/NETCONF-800 What Phosphorus is seeing is a few steps down: https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netconf-csit-1node-userfeatures-rfc8040-all-phosphorus/24/robot-plugin/log.html.gz#s1-s6-s1-t4-k5 this boils down to ODL reporting 404 from here: https://github.com/opendaylight/netconf/blob/master/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/streams/WebSocketInitializer.java#L123 and seems to be related to how https://github.com/opendaylight/netconf/blob/3212d561be73b43a9032db9cfe5045a2832ede2f/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/streams/listeners/ListenersBroker.java#L340 processes /rests/notif/data-change-event-subscription/opendaylight-inventory:nodes/datastore=CONFIGURATION/scope=BASEThis is tracked here: https://jira.opendaylight.org/browse/NETCONF-801 We need to treat both as regressions. I am also tracking three further fixes which are nice to have in Si SR2: https://jira.opendaylight.org/browse/MDSAL-677 https://jira.opendaylight.org/browse/CONTROLLER-1986 https://jira.opendaylight.org/browse/NETCONF-799 Regards, Robert
|
|
|