On 28/03/2022 00:10, Robert Varga wrote:

On 24/03/2022 01:24, Daniel de la Rosa wrote:

On Wed, Mar 23, 2022 at 3:47 PM Robert Varga <nite@... <mailto:nite@...>> wrote:
That’s impressive. Ok thanks and it is all good. We will have a very solid sulfur release

A quick update here. We are on the home stretch now, with 31 callsites still being bad. About a third are duplicate (e.g. they are the same weirdness across bierman20/rfc8040). They will need some amount of TLC, which I am not in position to give right now, sorry :(

Okay, so I am down to 3 call sites, which fall into two categories:

1. old RESTCONF's URI parser leafref support. I think I can perform sufficient surgery to make this work without having to rewrite that thing (as was done for new RESTCONF, where this is a breeze)

2. two instances of a weird interaction with XML codec. It is not that weird, I understand what is going on, it just needs a bit of more work.

I will need another day to deal with them and, fingers crossed, UTs should agree.

Regards,
Robert

On 24/03/2022 01:24, Daniel de la Rosa wrote:

On Wed, Mar 23, 2022 at 3:47 PM Robert Varga <nite@... <mailto:nite@...>> wrote:
That’s impressive. Ok thanks and it is all good. We will have a very solid sulfur release

A quick update here. We are on the home stretch now, with 31 callsites still being bad. About a third are duplicate (e.g. they are the same weirdness across bierman20/rfc8040). They will need some amount of TLC, which I am not in position to give right now, sorry :(

I expect to have them cleared tomorrow, Tuesday the latest, at which point I'll activate the supercommitter rights and roll things out.

The upgrade guide will come right after that, e.g. Tue or Wed.

Regards,
Robert

Hello Robert, all,

On 21/03/2022 14:45, Olivier Dugeon via lists.opendaylight.org wrote:

bgpcep is ready for integration, but netconf is not -- as it turns the vast majority of patches dealing with SchemaNode.getPath() caller removal had to be reverted because ... let's say they were naive.

Not yet for BGPCEP. I discover some late bugs on new PCE server last week. Patch is ready. I'll submit it this afternoon, just right after last verification.

Latest patches have been submitted:

• Correct bugs in Path Manager: https://git.opendaylight.org/gerrit/c/bgpcep/+/100205/4
• Add Close Loop mechanism to PCE Server: https://git.opendaylight.org/gerrit/c/bgpcep/+/100206/5
• Add Exclude and Include Route for Path Computation: https://git.opendaylight.org/gerrit/c/bgpcep/+/100247/1

The first two have been reviewed and are ready to be merged. Latest one needs to be reviewed.

The only point that is remaining for BGPCEP, is to clean the compilation from various warning message. I don't know if we include these now or wait for Sulfur SR1.

Regards

Olivier

Alright, anyway it's going to take a couple of days to sort out the RESTCONF stuff, so that (and the javadoc jobs) are the real blockers.

Regards,
Robert

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

--

On 21/03/2022 14:24, Robert Varga wrote:

On 20/03/2022 19:50, Robert Varga wrote:

On 19/03/2022 16:37, Daniel de la Rosa wrote:

    Alright, so MDSAL-731 is fixed and it makes MDSAL-735 more diagnosable
    -- I plan to squash that today.


It looks like all issues have been resolved. So are we ready to pick the next AR as RC?

I am still working through netconf/bgpcep, plus the bump to MSI projects. I'll keep you posted.

bgpcep is ready for integration, but netconf is not -- as it turns the vast majority of patches dealing with SchemaNode.getPath() caller removal had to be reverted because ... let's say they were naive.

So fixing RESTCONF here is going to require a yangtools-8.0.2 release. The problem is that we lost a DataSchemaContextTree capability which was provided indirectly via SchemaNode.getPath() -- the details are in YANGTOOLS-1412.

I expect to have that fixed today and finish the RESTCONF integration tomorrow, so that the MRI bump should (fingers crossed) over the weekend.

It is way later than planned, expected or hoped, but unfortunately it is what it is. There is silver lining here, though: this effort found two bugs that have been squashed after lurking around for 7 years.

I'll keep you posted,
Robert

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

On 21/03/2022 14:45, Olivier Dugeon via lists.opendaylight.org wrote:

bgpcep is ready for integration, but netconf is not -- as it turns the vast majority of patches dealing with SchemaNode.getPath() caller removal had to be reverted because ... let's say they were naive.

Not yet for BGPCEP. I discover some late bugs on new PCE server last week. Patch is ready. I'll submit it this afternoon, just right after last verification.

Alright, anyway it's going to take a couple of days to sort out the RESTCONF stuff, so that (and the javadoc jobs) are the real blockers.

Regards,
Robert

Hello Robert,

On 20/03/2022 19:50, Robert Varga wrote:

On 19/03/2022 16:37, Daniel de la Rosa wrote:

    Alright, so MDSAL-731 is fixed and it makes MDSAL-735 more diagnosable
    -- I plan to squash that today.


It looks like all issues have been resolved. So are we ready to pick the next AR as RC?

I am still working through netconf/bgpcep, plus the bump to MSI projects. I'll keep you posted.

bgpcep is ready for integration, but netconf is not -- as it turns the vast majority of patches dealing with SchemaNode.getPath() caller removal had to be reverted because ... let's say they were naive.

Not yet for BGPCEP. I discover some late bugs on new PCE server last week. Patch is ready. I'll submit it this afternoon, just right after last verification.

Regards

Olivier

serviceutils is also ready to integrate, but there's a problem needing action in global-jjb: javadocs jobs are using mvn35 and thus end up exploding like here: https://jenkins.opendaylight.org/releng/job/serviceutils-maven-javadoc-verify-sulfur-openjdk11/32/

Even when we tell the job to use mvn38, it will unpack the correct maven, but will attempt to use mvn35: https://jenkins.opendaylight.org/releng/job/serviceutils-maven-javadoc-verify-sulfur-openjdk11/33/console

Regards,
Robert

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

On 20/03/2022 19:50, Robert Varga wrote:

On 19/03/2022 16:37, Daniel de la Rosa wrote:

    Alright, so MDSAL-731 is fixed and it makes MDSAL-735 more diagnosable
    -- I plan to squash that today.


It looks like all issues have been resolved. So are we ready to pick the next AR as RC?

I am still working through netconf/bgpcep, plus the bump to MSI projects. I'll keep you posted.

bgpcep is ready for integration, but netconf is not -- as it turns the vast majority of patches dealing with SchemaNode.getPath() caller removal had to be reverted because ... let's say they were naive.

serviceutils is also ready to integrate, but there's a problem needing action in global-jjb: javadocs jobs are using mvn35 and thus end up exploding like here: https://jenkins.opendaylight.org/releng/job/serviceutils-maven-javadoc-verify-sulfur-openjdk11/32/

Even when we tell the job to use mvn38, it will unpack the correct maven, but will attempt to use mvn35: https://jenkins.opendaylight.org/releng/job/serviceutils-maven-javadoc-verify-sulfur-openjdk11/33/console

Regards,
Robert

On 19/03/2022 16:37, Daniel de la Rosa wrote:

Alright, so MDSAL-731 is fixed and it makes MDSAL-735 more diagnosable
-- I plan to squash that today.
It looks like all issues have been resolved. So are we ready to pick the next AR as RC?

I am still working through netconf/bgpcep, plus the bump to MSI projects. I'll keep you posted.

Regards,
Robert

On 16/03/2022 23:46, Robert Varga wrote:

On 16/03/2022 00:53, Daniel de la Rosa wrote:

Hello Robert

Hello Daniel,

    The major outstanding item are the MD-SAL regressions detected in ovsdb
    (and same thing is biting netconf) and bgpcep, tracked as MDSAL-731 and
    MDSAL-735 respectivelly.


Another day has passed :) so i guess we have to wait until these two are fixed to pick a RC?

Yes, unfortunately and I am still struggling with the fix, it turns out to be more complicated than expected, but I am converging on a solution.

Alright, so MDSAL-731 is fixed and it makes MDSAL-735 more diagnosable -- I plan to squash that today.

Regards,
Robert

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

On 16/03/2022 00:53, Daniel de la Rosa wrote:

Hello Robert

Hello Daniel,

The major outstanding item are the MD-SAL regressions detected in ovsdb
(and same thing is biting netconf) and bgpcep, tracked as MDSAL-731 and
MDSAL-735 respectivelly.
Another day has passed :) so i guess we have to wait until these two are fixed to pick a RC?

Yes, unfortunately and I am still struggling with the fix, it turns out to be more complicated than expected, but I am converging on a solution.

Regards,
Robert

On 01/12/2021 11:14, Robert Varga wrote:

The tracker issue for the removal is https://jira.opendaylight.org/browse/NETCONF-837 and the plan of action is as follows:
1. Phosphorus SR2, due out 2022-01-27, will issue a single (mild) warning on startup. We will continue to install the implementation as part of the 'odl-restconf' feature.
2. 2022.03 Sulfur, due out 2022-03-17, will not install the old implementation by default. Users will be required to explicitly install the 'odl-restconf-nb-bierman02' feature. The warning introduced in step 1. will be updated to warn about the fact the feature is no longer supported and scheduled for removal in the next major release.
3. Old implementation will be removed from the netconf git repository's master branch as soon as the 3.0.x stability branch for Sulfur is created -- i.e. March/April 2022.
4. 2022.09 Chlorine, due out in September 2022, will not include the old implementation.
Unless serious objections to this are raised by 2022-01-10 we will execute it exactly as outlined above.

No objections received up until now (~2 months after the dealine), this is the official plan of action.

Regards,
Robert