Tony -

Can you check in a Unit test that will test this particular case so we can ensure that we don’t regress again?

It would be nice to start building in Unit tests that will prevent merges into main if code doesn’t work as expected so we can avoid these issues.

Thank you,

Devin

From: "Tony Tkacik -X (ttkacik - Pantheon Technologies SRO at Cisco)" <ttkacik@...>
Date: Thursday, May 29, 2014 at 8:31 AM
To: Luis Gomez <ecelgp@...>, Abhijit Kumbhare <abhijitkoss@...>
Cc: Controller Dev <controller-dev@...>, "'integration-dev@...' (integration-dev@...)" <integration-dev@...>, openflowplugin-dev <openflowplugin-dev@...>
Subject: Re: [controller-dev] [openflowplugin-dev] OF plugin issues

Hi,

All regressions are fixed, bugfix (https://git.opendaylight.org/gerrit/#/c/7485/) merged to the master.

 

Regression were introduced by converting sal-compatibility from xtend to java,

and Felix DM not reporting missing callbacks as explained in commit log.

 

Tony

 

 

From: controller-dev-bounces@... [mailto:controller-dev-bounces@...] On Behalf Of Luis Gomez
Sent: Thursday, May 29, 2014 8:32 AM
To: Abhijit Kumbhare
Cc: Controller Dev; 'integration-dev@...' (integration-dev@...); openflowplugin-dev
Subject: Re: [controller-dev] [openflowplugin-dev] OF plugin issues

 

For the time of the failure:

 

Ping test stopped to work after any of these patches:

 

https://git.opendaylight.org/gerrit/#/c/7271

https://git.opendaylight.org/gerrit/#/c/7456

https://git.opendaylight.org/gerrit/#/c/7435

 

AD-SAL NSF stopped to work after any of these patches:

 

https://git.opendaylight.org/gerrit/#/c/7461

https://git.opendaylight.org/gerrit/#/c/7462

 

BR/Luis

 

 

On May 28, 2014, at 11:09 PM, Abhijit Kumbhare <abhijitkoss@...> wrote:

We discussed in the OF Plugin meeting - looks like there has been no change which has gone in the OF plugin in last 2-3 days which may be causing issues that Luis is reporting. Can the controller folks please look into this as there seem to be a lot more list of changes in there? Please see my email below - or look at https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z for the possible culprits :-).

 

 

On Wed, May 28, 2014 at 5:08 PM, Abhijit Kumbhare <abhijitkoss@...> wrote:

The recent ones which have gone into the plugin are (the times are probably Pacific):

 

May 27, 2014 9:56 AM

https://git.opendaylight.org/gerrit/#/c/7401/  BUG-1074: add javadoc for QueueKeeper

 

Since just a javadoc change - this is unlikely to have caused the issue.

 

May 27, 2014 4:34 AM

https://git.opendaylight.org/gerrit/#/c/7421/ Removed unnecessary libxml2 import

 

Since this is a test script change - unlikely to have caused the issue.

 

May 27, 2014 1:00 AM

https://git.opendaylight.org/gerrit/#/c/7390/  CRUD ODL python RESTconf tests

 

Again a test script change - not the culprit.

 

May 26, 2014 6:11 AM

https://git.opendaylight.org/gerrit/#/c/7399/  BUG-770: NumberFormatException for datapathId

 

Did it break two days ago? If not - this can be eliminated.

 

May 26, 2014 2:28 AM

https://git.opendaylight.org/gerrit/#/c/7371/  Bug 1071: Invalid value used for frame priority code point in OFCommandProvider

 

This is in the test provider - so can be eliminated.

 

 

Hence - we may need to go thru the controller project commits rather than the openflowplugin as things have stopped working today:

 

 

BUG-625: migrate MDFlowMapping	Merged	Robert Varga	controller	master	9:48 AM
Bug 1029: Remove dead code: sal-dom-it	Merged	Ed Warnicke	controller	master (stable/hydrogen)	9:23 AM
Bug 1029: Remove dead code: sal-schema-repository-api	Merged	Ed Warnicke	controller	master (stable/hydrogen)	8:59 AM
BUG-625: migrate FlowProgrammerAdapter	Merged	Robert Varga	controller	master	8:33 AM
BUG-625: migrate ComponentActivator	Merged	Robert Varga	controller	master	8:05 AM
BUG-625: split off SalCompatibilityProvider	Merged	Robert Varga	controller	master	4:21 AM
BUG-625: convert TopologyMapping	Merged	Robert Varga	controller	master	3:57 AM
BUG-625: convert TopologyAdapter	Merged	Robert Varga	controller	master	3:33 AM
BUG-625: convert TopologyProvider	Merged	Robert Varga	controller	master	3:07 AM
BUG-625: convert DataPacketAdapter	Merged	Robert Varga	controller	master	2:43 AM
BUG-614: convert RuntimeCodeSpecification	Merged	Robert Varga	controller	master	2:18 AM
BUG-620: replace xtend version of classes with Java versions	Merged	David Bainbridge	controller	master	1:52 AM
Bug 1010: Implement restconf error responses	Merged	Tom Pantelis	controller	master (helium)	27-May
BUG-731: fix duplicate entry warning	Merged	Robert Varga	controller	master	27-May
Registered SecGroup/Rules in netconfig.Neutron Activator	Merged	Brent Salisbury	controller	master	27-May
BUG-624 make netconf tcp address optional in config.ini with default value ...	Merged	Maros Marsalek	controller	master	26-May
Bug 1036 - Allow using container in case stmt to preserve uniqueness.	Merged	Tomas Olvecky	controller	master (stable/hydrogen)	26-May
BUG-1070: allow for URL registration failing	Merged	Robert Varga	controller	master	26-May
BUG-1070: make BundleContext required	Merged	Robert Varga	controller	master	26-May
Neutron API v2.0 bindings and APIs for security groups/rules.	Merged	Brent Salisbury	controller	master	26-May

 

On Wed, May 28, 2014 at 3:53 PM, Luis Gomez <ecelgp@...> wrote:

Hi devs,

I just noticed a couple of things:

- mininet ping test stopped to work today between 8:26AM-9:39AM UTC

- AD-SAL apps cannot see OF nodes since today 2:16PM-3:27PM UTC

See test report here:

https://jenkins.opendaylight.org/integration/job/integration-csit-base-of13/

BR/Luis

_______________________________________________
openflowplugin-dev mailing list
openflowplugin-dev@...
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

 

 

 

_______________________________________________
integration-dev mailing list
integration-dev@...
https://lists.opendaylight.org/mailman/listinfo/integration-dev