Hi Robert,
for this case you cannot cover with a UT, but with an integration test with
pax-exam, that way you will have an OSGi environment in which you can check if
the bundle that failed to get the callback registered missed any required
service dependency. There are already few IT that do this kind of validation and
fails if the services are not registered. Northbound integration test on
controller is probably the biggest one. The IT are executed as part of
verification job hence the issue should be gated before the code hit the repository.
Thanks,
Giovanni
toggle quoted message
Show quoted text
On 29-May-14 20:14, Robert Varga wrote: I have to claim ignorance here. Do we have a framework for testing component
activation using ADM?
Thanks,
Robert
On 05/29/2014 02:47 PM, Devin Avery wrote:
Tony -
Can you check in a Unit test that will test this particular case so we can
ensure that we don’t regress again?
It would be nice to start building in Unit tests that will prevent merges into
main if code doesn’t work as expected so we can avoid these issues.
Thank you,
Devin
From: "Tony Tkacik -X (ttkacik - Pantheon Technologies SRO at Cisco)"
<ttkacik@... <mailto:ttkacik@...>>
Date: Thursday, May 29, 2014 at 8:31 AM
To: Luis Gomez <ecelgp@... <mailto:ecelgp@...>>, Abhijit Kumbhare
<abhijitkoss@... <mailto:abhijitkoss@...>>
Cc: Controller Dev <controller-dev@...
<mailto:controller-dev@...>>,
"'integration-dev@...
<mailto:%27integration-dev@...>'
(integration-dev@...
<mailto:integration-dev@...>)"
<integration-dev@...
<mailto:integration-dev@...>>, openflowplugin-dev
<openflowplugin-dev@...
<mailto:openflowplugin-dev@...>>
Subject: Re: [controller-dev] [openflowplugin-dev] OF plugin issues
Hi,
All regressions are fixed, bugfix
(https://git.opendaylight.org/gerrit/#/c/7485/) merged to the master.
Regression were introduced by converting sal-compatibility from xtend to java,
and Felix DM not reporting missing callbacks as explained in commit log.
Tony
*From:*controller-dev-bounces@...
<mailto:controller-dev-bounces@...>
[mailto:controller-dev-bounces@...] *On Behalf Of *Luis Gomez
*Sent:* Thursday, May 29, 2014 8:32 AM
*To:* Abhijit Kumbhare
*Cc:* Controller Dev; 'integration-dev@...
<mailto:%27integration-dev@...>'
(integration-dev@...
<mailto:integration-dev@...>); openflowplugin-dev
*Subject:* Re: [controller-dev] [openflowplugin-dev] OF plugin issues
For the time of the failure:
Ping test stopped to work after any of these patches:
https://git.opendaylight.org/gerrit/#/c/7271
https://git.opendaylight.org/gerrit/#/c/7456
https://git.opendaylight.org/gerrit/#/c/7435
AD-SAL NSF stopped to work after any of these patches:
https://git.opendaylight.org/gerrit/#/c/7461
https://git.opendaylight.org/gerrit/#/c/7462
BR/Luis
On May 28, 2014, at 11:09 PM, Abhijit Kumbhare <abhijitkoss@...
<mailto:abhijitkoss@...>> wrote:
We discussed in the OF Plugin meeting - looks like there has been no change
which has gone in the OF plugin in last 2-3 days which may be causing issues
that Luis is reporting. Can the controller folks please look into this as
there seem to be a lot more list of changes in there? Please see my email
below - or look
at https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z
for the possible culprits :-).
On Wed, May 28, 2014 at 5:08 PM, Abhijit Kumbhare <abhijitkoss@...
<mailto:abhijitkoss@...>> wrote:
The recent ones which have gone into the plugin are (the times are probably
Pacific):
May 27, 2014 9:56 AM
https://git.opendaylight.org/gerrit/#/c/7401/ *BUG-1074*
<https://bugs.opendaylight.org/show_bug.cgi?id=1074>*: add javadoc for
QueueKeeper*
Since just a javadoc change - this is unlikely to have caused the issue.
May 27, 2014 4:34 AM
https://git.opendaylight.org/gerrit/#/c/7421/ *Removed unnecessary libxml2 import*
Since this is a test script change - unlikely to have caused the issue.
May 27, 2014 1:00 AM
https://git.opendaylight.org/gerrit/#/c/7390/ *CRUD ODL python RESTconf tests*
Again a test script change - not the culprit.
May 26, 2014 6:11 AM
https://git.opendaylight.org/gerrit/#/c/7399/ *BUG-770*
<https://bugs.opendaylight.org/show_bug.cgi?id=770>*: NumberFormatException
for datapathId*
Did it break two days ago? If not - this can be eliminated.
May 26, 2014 2:28 AM
https://git.opendaylight.org/gerrit/#/c/7371/ *Bug 1071*
<https://bugs.opendaylight.org/show_bug.cgi?id=1071>*: Invalid value used for
frame priority code point in OFCommandProvider*
This is in the test provider - so can be eliminated.
Hence - we may need to go thru the controller project commits rather than the
openflowplugin as things have stopped working today:
BUG-625: migrate MDFlowMapping <https://git.opendaylight.org/gerrit/7463>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
9:48 AM
Bug 1029: Remove dead code: sal-dom-it <https://git.opendaylight.org/gerrit/7198>
Merged
Ed Warnicke
<https://git.opendaylight.org/gerrit/#/q/owner:%22Ed+Warnicke%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master (stable/hydrogen)
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master+topic:stable/hydrogen,n,z>
9:23 AM
Bug 1029: Remove dead code: sal-schema-repository-api
<https://git.opendaylight.org/gerrit/7199>
Merged
Ed Warnicke
<https://git.opendaylight.org/gerrit/#/q/owner:%22Ed+Warnicke%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master (stable/hydrogen)
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master+topic:stable/hydrogen,n,z>
8:59 AM
BUG-625: migrate FlowProgrammerAdapter <https://git.opendaylight.org/gerrit/7462>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
8:33 AM
BUG-625: migrate ComponentActivator <https://git.opendaylight.org/gerrit/7461>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
8:05 AM
BUG-625: split off SalCompatibilityProvider
<https://git.opendaylight.org/gerrit/7436>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
4:21 AM
BUG-625: convert TopologyMapping <https://git.opendaylight.org/gerrit/7438>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
3:57 AM
BUG-625: convert TopologyAdapter <https://git.opendaylight.org/gerrit/7437>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
3:33 AM
BUG-625: convert TopologyProvider <https://git.opendaylight.org/gerrit/7439>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
3:07 AM
BUG-625: convert DataPacketAdapter <https://git.opendaylight.org/gerrit/7435>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
2:43 AM
BUG-614: convert RuntimeCodeSpecification
<https://git.opendaylight.org/gerrit/7456>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
2:18 AM
BUG-620: replace xtend version of classes with Java versions
<https://git.opendaylight.org/gerrit/7271>
Merged
David Bainbridge
<https://git.opendaylight.org/gerrit/#/q/owner:%22David+Bainbridge%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
1:52 AM
Bug 1010: Implement restconf error responses
<https://git.opendaylight.org/gerrit/7125>
Merged
Tom Pantelis
<https://git.opendaylight.org/gerrit/#/q/owner:%22Tom+Pantelis%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master (helium)
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master+topic:helium,n,z>
27-May
BUG-731: fix duplicate entry warning <https://git.opendaylight.org/gerrit/7419>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
27-May
Registered SecGroup/Rules in netconfig.Neutron Activator
<https://git.opendaylight.org/gerrit/7410>
Merged
Brent Salisbury
<https://git.opendaylight.org/gerrit/#/q/owner:%22Brent+Salisbury%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
27-May
BUG-624 make netconf tcp address optional in config.ini with default value ...
<https://git.opendaylight.org/gerrit/6198>
Merged
Maros Marsalek
<https://git.opendaylight.org/gerrit/#/q/owner:%22Maros+Marsalek%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
26-May
Bug 1036 - Allow using container in case stmt to preserve uniqueness.
<https://git.opendaylight.org/gerrit/7354>
Merged
Tomas Olvecky
<https://git.opendaylight.org/gerrit/#/q/owner:%22Tomas+Olvecky%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master (stable/hydrogen)
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master+topic:stable/hydrogen,n,z>
26-May
BUG-1070: allow for URL registration failing
<https://git.opendaylight.org/gerrit/7388>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
26-May
BUG-1070: make BundleContext required <https://git.opendaylight.org/gerrit/7389>
Merged
Robert Varga
<https://git.opendaylight.org/gerrit/#/q/owner:%22Robert+Varga%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
26-May
Neutron API v2.0 bindings and APIs for security groups/rules.
<https://git.opendaylight.org/gerrit/7369>
Merged
Brent Salisbury
<https://git.opendaylight.org/gerrit/#/q/owner:%22Brent+Salisbury%22+status:merged,n,z>
controller
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller,n,z>
master
<https://git.opendaylight.org/gerrit/#/q/status:merged+project:controller+branch:master,n,z>
26-May
On Wed, May 28, 2014 at 3:53 PM, Luis Gomez <ecelgp@...
<mailto:ecelgp@...>> wrote:
Hi devs,
I just noticed a couple of things:
- mininet ping test stopped to work today between 8:26AM-9:39AM UTC
- AD-SAL apps cannot see OF nodes since today 2:16PM-3:27PM UTC
See test report here:
https://jenkins.opendaylight.org/integration/job/integration-csit-base-of13/
BR/Luis
_______________________________________________
openflowplugin-dev mailing list
openflowplugin-dev@...
<mailto:openflowplugin-dev@...>
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
_______________________________________________
integration-dev mailing list
integration-dev@...
https://lists.opendaylight.org/mailman/listinfo/integration-dev
_______________________________________________
integration-dev mailing list
integration-dev@...
https://lists.opendaylight.org/mailman/listinfo/integration-dev
--
Giovanni Meo
Via del Serafico, 200 Telephone: +390651644000
00142, Roma Mobile: +393480700958
Italia Fax: +390651645917
VOIP: 8-3964000
“The pessimist complains about the wind;
the optimist expects it to change;
the realist adjusts the sails.” -- Wm. Arthur Ward
IETF credo: "Rough consensus and running code"
|
