Re: Start and stop suite for COE - LFN internship


JamO Luhrsen
 

This idea came from Sam on IRC. The problem with __init__.robot is that you can't
do the teardown that way, AND you have to call pybot on folders, not specific
suites.

JamO

On 08/02/2018 07:47 AM, Faseela K wrote:
Isn't this a bit complicated?
I remember previously we used to have an _init.py file where we used to have common start suite and stop suite.
Is that not available right now?
Thanks,
Faseela
-----Original Message-----
From: Jamo Luhrsen [mailto:jluhrsen@...]
Sent: Tuesday, July 31, 2018 8:53 PM
To: Karthika Paneer <karthikapaneer97@...>; integration-dev@...
Cc: Prem sankar G <prem.sankar.g@...>; Faseela K <faseela.k@...>
Subject: Re: [integration-dev] Start and stop suite for COE - LFN internship
On 07/31/2018 04:54 AM, Karthika Paneer wrote:
Hi Jamo/Sam,
I have done the changes to the pybot file to include ${SUITES} variable.
And I also implemented Sam's idea , but it doesnt work as expected.

${SUITES} stores value as  :

/w/workspace/Karthikacoe-csit-1node-container-networking-all-fluorine/
test/csit/suites/coe/*Pods_Basic_Connectivity_Tests.robot
*/w/workspace/Karthikacoe-csit-1node-container-networking-all-fluorine
/test/csit/suites/coe/*Pods_Scalability_Tests.robot *To compare it
against the current suite I used , **${SUITE_NAME} (from BuiltIn)
which stores value as , **${current suite} =
coe-container-networking.txt.*Pods Basic Connectivity Tests***So when
i compare the first value in list ${SUITES} and ${current suite} using
BuiltIn.Evaluate it obviously fails (Even if i use regex and extract
the suite name alone)More precisely ,
*Pods_Basic_Connectivity_Tests.robot != *Pods Basic Connectivity
Tests* * How do we fix
this is robot being "friendly" and removing the underscores from the suite name (as well as the .robot extension)
try to string replace "_" with just a space " " and then do the comparison.
Again, this is another example of something you can figure out locally and not deal with the overhead of the sandbox. but, hopefully you were already doing that.
Thanks,
JamO

this? Regards, R P Karthika**


On Mon, Jul 30, 2018 at 8:51 PM, Karthika Paneer <karthikapaneer97@... <mailto:karthikapaneer97@...>> wrote:

Thanks Jamo,
Let me try it and provide the updates



Regards,
R P Karthika

On Mon, Jul 30, 2018 at 8:49 PM, Jamo Luhrsen <jluhrsen@... <mailto:jluhrsen@...>> wrote:

Karthika,

pybot is not even executing here ("[ ERROR ] Parsing '-v' failed: Data source does not exist.")
so your patch [1] is irrelevant.

the problem is you are passing the ${SUITES} variable, which has spaces in it on the
command line. you will probably just need to wrap "${SUITES}" in quotes to make it
work.

either way, that is something to quickly figure out/test locally so you don't have
all the overhead of the sandbox.

hope it helps,
JamO

On 07/30/2018 08:02 AM, Karthika Paneer wrote:

Hi Jamo/Sam,
As a result of discussion we had in IRC (regarding having single start and stop suite for COE) I have
modified my patch [1] and pushed a separate patch [2] to include suites variable in
*integration-deploy-controller-run-test.sh*.
Now when I trigger a sandbox job for patch[1] it fails
with the following error,

ERROR :

*07:38:10* + pybot -N coe-container-networking.txt --removekeywords wuks -c critical -e exclude -e
skip_if_fluorine -v BUNDLEFOLDER:karaf-0.9.0-SNAPSHOT -v
BUNDLE_URL:https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.9.0-SNAPSHOT/karaf-0.9.0-20180729.062408-1871.zip
<https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.9.0-SNAPSHOT/karaf-0.9.0-20180729.062408-1871.zip>
<https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.9.0-SNAPSHOT/karaf-0.9.0-20180729.062408-1871.zip
<https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/integration/karaf/0.9.0-SNAPSHOT/karaf-0.9.0-20180729.062408-1871.zip>>
-v CONTROLLER:10.30.170.202 -v CONTROLLER_USER:jenkins -v JAVA_HOME:/usr/lib/jvm/java-1.8.0 -v
JDKVERSION:openjdk8 -v
JENKINS_WORKSPACE:/w/workspace/Karthikacoe-csit-1node-container-networking-all-fluorine -v
MININET1:10.30.170.49 -v MININET2:10.30.170.208 -v MININET3: -v MININET4: -v MININET5: -v
MININET:10.30.170.89 -v MININET_USER:jenkins -v NEXUSURL_PREFIX:https://nexus.opendaylight.org
<https://nexus.opendaylight.org> <https://nexus.opendaylight.org/ <https://nexus.opendaylight.org/>>  -v
NUM_ODL_SYSTEM:1 -v NUM_TOOLS_SYSTEM:3 -v ODL_STREAM:fluorine -v ODL_SYSTEM_1_IP:10.30.170.202 -v
ODL_SYSTEM_IP:10.30.170.202 -v ODL_SYSTEM_USER:jenkins -v
SUITES:/w/workspace/Karthikacoe-csit-1node-container-networking-all-fluorine/test/csit/suites/coe/Pods_Basic_Connectivity_Tests.robot
/w/workspace/Karthikacoe-csit-1node-container-networking-all-fluorine/test/csit/suites/coe/Pods_Scalability_Tests.robot
-v TOOLS_SYSTEM_1_IP:10.30.170.89 -v TOOLS_SYSTEM_2_IP:10.30.170.49 -v TOOLS_SYSTEM_3_IP:10.30.170.208 -v
TOOLS_SYSTEM_4_IP: -v TOOLS_SYSTEM_5_IP: -v TOOLS_SYSTEM_6_IP: -v TOOLS_SYSTEM_IP:10.30.170.89 -v
TOOLS_SYSTEM_USER:jenkins -v USER_HOME:/home/jenkins -v WORKSPACE:/tmp
/w/workspace/Karthikacoe-csit-1node-container-networking-all-fluorine/test/csit/suites/coe/Pods_Basic_Connectivity_Tests.robot
/w/workspace/Karthikacoe-csit-1node-container-networking-all-fluorine/test/csit/suites/coe/Pods_Scalability_Tests.robot
*07:38:11* [ ERROR ] Parsing '-v' failed: Data source does not exist.



Is it because the changes in patch [2] not being reflected  in patch [1]?
How do I rectify this error?


[1] : https://git.opendaylight.org/gerrit/#/c/73654/ <https://git.opendaylight.org/gerrit/#/c/73654/>
<https://git.opendaylight.org/gerrit/#/c/73654/ <https://git.opendaylight.org/gerrit/#/c/73654/>>
[2] : https://git.opendaylight.org/gerrit/#/c/74614/ <https://git.opendaylight.org/gerrit/#/c/74614/>
<https://git.opendaylight.org/gerrit/#/c/74614/
<https://git.opendaylight.org/gerrit/#/c/74614/>>


Regards,
R P Karthika



_______________________________________________
integration-dev mailing list
integration-dev@... <mailto:integration-dev@...>
https://lists.opendaylight.org/mailman/listinfo/integration-dev
<https://lists.opendaylight.org/mailman/listinfo/integration-dev>


Join integration-dev@lists.opendaylight.org to automatically receive all group messages.