Hi netconf devs,

A CSIT regression has been detected in Neon since 2 days:

https://jenkins.opendaylight.org/releng/job/netconf-csit-1node-userfeatures-all-neon/

Connected to this, there is this BC exception in the testtool log:

08:44:28.082 [main] DEBUG o.a.s.c.util.security.SecurityUtils - register(BC) not registered - enabled=false, supported=true
08:44:28.083 [main] DEBUG o.a.s.c.util.security.SecurityUtils - register(EdDSA) not registered - enabled=true, supported=false
08:44:28.086 [main] ERROR o.o.netconf.test.tool.Main - Unhandled exception
java.lang.IllegalArgumentException: BouncyCastle not registered
at org.apache.sshd.common.util.ValidateUtils.createFormattedException(ValidateUtils.java:213)
at org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:179)
at org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:156)
at org.apache.sshd.common.util.security.SecurityUtils.createGeneratorHostKeyProvider(SecurityUtils.java:503)
at org.opendaylight.netconf.test.tool.NetconfDeviceSimulator.getPemGeneratorHostKeyProvider(NetconfDeviceSimulator.java:294)
at org.opendaylight.netconf.test.tool.NetconfDeviceSimulator.start(NetconfDeviceSimulator.java:194)
at org.opendaylight.netconf.test.tool.Main.main(Main.java:47)

So when I change the test tool command like in this patch, then testtool works fine:

https://git.opendaylight.org/gerrit/#/c/81879

Since I am not sure why this BC option was introduced in first place, my question is: should we go ahead and merge the test patch or is there anything else we need to investigate?

BR/Luis