Re: shellcheck broken


Luis Gomez
 

Thanks Andy :)

On Jan 29, 2021, at 6:47 AM, Andrew Grimberg <agrimberg@...> wrote:

On 1/28/21 8:11 PM, Luis Gomez wrote:
FYI, not sure which jobs are impacted but shellcheck pre-commit is broken here:

https://jenkins.opendaylight.org/releng/job/builder-tox-verify-master/

BR/Luis
The pre-commit project released 2.10.0 which seems to have introduced an
incompatibility with jumanjihouse/pre-commit-hooks and in particular the
shellcheck hook.

At this time we don't know if it was intentional or not, but we've taken
to pinning pre-commit to version 2.9.3 in our tox.ini for the time being.

This is a project by project change for projects that use shellcheck in
their .pre-commit-config.yaml file that would need to happen as it
doesn't come from global-jjb.

For releng/builder I've pushed up [0] that does this pinning.

-Andy-

[0] https://git.opendaylight.org/gerrit/c/releng/builder/+/94887

--
Andrew J Grimberg
Manager Release Engineering
The Linux Foundation
<OpenPGP_0x3360FFB703A9DA1F_and_old_rev.asc>

Join integration-dev@lists.opendaylight.org to automatically receive all group messages.