1. posterid:1320659
  2. Messages

Re: [controller-dev] Master broken

Robert Varga
 

On 01/23/2015 07:02 PM, Luis Gomez wrote:
Hi Robert, 

integration does not trigger any other integration, that has risk of loops

Okay, but that means the system is broken, as the integration jobs are supposed to guard the published artifacts -- which used to be published *only* by merges, but that is no longer true.


I think there is some chance that a merge job uploads at the same time as an integration job, but for the same reasoning 2 merge jobs could upload at the same time too. How are we doing today to make sure we do not run 2 merge jobs in parallel? we can apply the same to integration job.

Right, we do not run merges in parallel, as far as I know, and it is a simple knob in the job configuration. It is not sufficient to just not run integration jobs in parallel -- integration job cannot run when a merge is running and vice versa -- I do not know how to do that.

Bye,
Robert

BR/Luis

On Jan 23, 2015, at 1:45 AM, Robert Varga <nite@...> wrote:

The merge and integration have been made mutually exclusive, or what happens if the two publish artifacts at the same time?

Also, this means that integration jobs must trigger downstream integration jobs -- is that happening?

Bye,
Robert

On 01/23/2015 12:48 AM, Thanh Ha wrote:
Just to loop everyone in. We discussed this over IRC and decided to go ahead with making integration jobs deploy artifacts. This was pushed into JJB and is now active on all projects that use JJB.

Regards,

Thanh

On 22 January 2015 at 14:18, Luis Gomez <ecelgp@...> wrote:
Hi Andy and Thanh,

This is also related with the request of publishing artifacts in the project integration job we discussed this morning. We can smooth the impact of the changes that require project rebuild and publishing. Almost all projects have declared dependencies to controller and yangtools that generate these kind of breakages.

BR/Luis


Begin forwarded message:

From: "Tony Tkacik -X (ttkacik - Pantheon Technologies SRO at Cisco)" <ttkacik@...>
To: "dev (dev@...)" <dev@...>
Cc: openflowplugin-dev <openflowplugin-dev@...>, "controller-dev@..." <controller-dev@...>, Luis Gomez <ecelgp@...>, Reinaldo Penno <rapenno@...>
Subject: RE: [controller-dev] Master broken
Date: January 21, 2015 at 12:37:57 AM PST

Hi,
Sorry for breakage / confusion, but this change was already announced  on the 2015-01-08,
But probably was miscommunicated / overloooked.
Since we are in middle of development cycle (Lithium) some breakage changes may occur
 
In order to prevent same miscommunications / breakages further:
1.      Change in SNAPSHOT artefact, which requires rebuild of users will be announced at least 5 working days before to dev@...
a.      Email will contain date when change will be merged
b.      Email will contain description why change is needed
2.      When change is merged, commiter who merged change will send email that projects needs to be rebuilded when
a.      Title should be Rebuild needed: $reason
b.      Mail should contain link to change and description
c.      Mail should contain description of breakage which is to be expected without rebuild
d.      Mail MUST contain required steps in order to unbreakage (re-run merge job / recompile).
Tony
 
 
 
 
 
Tony
 
From: controller-dev-bounces@... [mailto:controller-dev-bounces@...] On Behalf Of Reinaldo Penno
Sent: Wednesday, January 21, 2015 5:47 AM
To: Luis Gomez; controller-dev; openflowplugin-dev
Subject: Re: [controller-dev] Master broken
 
Maybe
 
 
Irrespective, I think this change should have been announced in the mailing list. 
 
I know this caused one of the projects I work on to stop working since we had to change a Yang generate file in order to override an abstract method.
 
Thanks,
 
Reinaldo
 
From: Luis Gomez <ecelgp@...>
Date: Tuesday, January 20, 2015 at 8:04 PM
To: controller-dev <controller-dev@...>, openflowplugin-dev <openflowplugin-dev@...>
Subject: [controller-dev] Master broken
 
So today it is the turn for master, when I install odl-openflowplugin-flow-services-ui feature, I see this error in karaf console:
 
opendaylight-user@root>Exception in thread "config-pusher" java.lang.AbstractMethodError
               at sun.reflect.GeneratedMethodAccessor41.invoke(Unknown Source)
               at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
               at java.lang.reflect.Method.invoke(Method.java:606)
               at org.opendaylight.controller.config.manager.impl.dependencyresolver.DependencyResolverManager$ModuleInvocationHandler.handleInvocation(DependencyResolverManager.java:149)
               at com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:70)
               at com.sun.proxy.$Proxy73.canReuse(Unknown Source)
               at org.opendaylight.controller.config.manager.impl.dependencyresolver.DependencyResolverImpl.canReuseDependency(DependencyResolverImpl.java:206)
               at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.openflow.common.config.impl.rev140326.AbstractConfigurableOpenFlowProviderModule.isSame(AbstractConfigurableOpenFlowProviderModule.java:81)
               at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.openflow.common.config.impl.rev140326.AbstractConfigurableOpenFlowProviderModule.canReuseInstance(AbstractConfigurableOpenFlowProviderModule.java:65)
               at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.openflow.common.config.impl.rev140326.AbstractConfigurableOpenFlowProviderModule.canReuseInstance(AbstractConfigurableOpenFlowProviderModule.java:11)
               at org.opendaylight.controller.config.spi.AbstractModule.getInstance(AbstractModule.java:61)
               at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source)
               at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
               at java.lang.reflect.Method.invoke(Method.java:606)
               at org.opendaylight.controller.config.manager.impl.dependencyresolver.DependencyResolverManager$ModuleInvocationHandler.handleInvocation(DependencyResolverManager.java:149)
               at com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:70)
               at com.sun.proxy.$Proxy73.getInstance(Unknown Source)
               at org.opendaylight.controller.config.manager.impl.dependencyresolver.DependencyResolverImpl.resolveInstance(DependencyResolverImpl.java:160)
               at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.openflow.common.config.impl.rev140326.AbstractMsgSpyServiceModule.resolveDependencies(AbstractMsgSpyServiceModule.java:62)
               at org.opendaylight.controller.config.spi.AbstractModule.getInstance(AbstractModule.java:72)
               at sun.reflect.GeneratedMethodAccessor16.invoke(Unknown Source)
               at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
               at java.lang.reflect.Method.invoke(Method.java:606)
               at org.opendaylight.controller.config.manager.impl.dependencyresolver.DependencyResolverManager$ModuleInvocationHandler.handleInvocation(DependencyResolverManager.java:149)
               at com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:70)
               at com.sun.proxy.$Proxy20.getInstance(Unknown Source)
               at org.opendaylight.controller.config.manager.impl.ConfigTransactionControllerImpl.secondPhaseCommit(ConfigTransactionControllerImpl.java:399)
               at org.opendaylight.controller.config.manager.impl.ConfigRegistryImpl.secondPhaseCommit(ConfigRegistryImpl.java:280)
               at org.opendaylight.controller.config.manager.impl.ConfigRegistryImpl.commitConfig(ConfigRegistryImpl.java:227)
               at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
               at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
               at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
               at java.lang.reflect.Method.invoke(Method.java:606)
               at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:75)
               at sun.reflect.GeneratedMethodAccessor31.invoke(Unknown Source)
               at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
               at java.lang.reflect.Method.invoke(Method.java:606)
               at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:279)
               at com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
               at com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
               at com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)
               at com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)
               at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
               at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
               at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
               at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
               at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
               at com.sun.jmx.mbeanserver.MXBeanProxy$InvokeHandler.invoke(MXBeanProxy.java:150)
               at com.sun.jmx.mbeanserver.MXBeanProxy.invoke(MXBeanProxy.java:167)
               at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:252)
               at com.sun.proxy.$Proxy16.commitConfig(Unknown Source)
               at org.opendaylight.controller.config.util.ConfigRegistryJMXClient.commitConfig(ConfigRegistryJMXClient.java:102)
               at org.opendaylight.controller.netconf.confignetconfconnector.transactions.TransactionProvider.commitTransaction(TransactionProvider.java:110)
               at org.opendaylight.controller.netconf.confignetconfconnector.operations.Commit.handleWithNoSubsequentOperations(Commit.java:54)
               at org.opendaylight.controller.netconf.util.mapping.AbstractLastNetconfOperation.handle(AbstractLastNetconfOperation.java:33)
               at org.opendaylight.controller.netconf.util.mapping.AbstractNetconfOperation.handle(AbstractNetconfOperation.java:100)
               at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.sendRequestGetResponseCheckIsOK(ConfigPusherImpl.java:280)
               at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.pushConfig(ConfigPusherImpl.java:239)
               at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.pushConfigWithConflictingVersionRetries(ConfigPusherImpl.java:128)
               at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.internalPushConfigs(ConfigPusherImpl.java:101)
               at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.process(ConfigPusherImpl.java:76)
               at org.opendaylight.controller.netconf.persist.impl.osgi.ConfigPersisterActivator$InnerCustomizer$1.run(ConfigPersisterActivator.java:175)
               at java.lang.Thread.run(Thread.java:745)
 
After that any RESTCONF call I try returns 503 Service Unavailable.
 
Can you please take a look?
 
BR/Luis
 
On Jan 20, 2015, at 10:59 AM, Luis Gomez <ecelgp@...> wrote:
 
OK, it looks the patch below fixed the stable/helium issue:
 
 
BR/Luis
 
 
On Jan 19, 2015, at 10:01 PM, Luis Gomez <ecelgp@...> wrote:
 
Hi experts,

I downloaded latest stable/helium distribution, installed odl-openflowplugin-flow-services-ui and I see this error in karaf console:

Exception in thread "config-pusher" java.lang.IllegalStateException: Failed to send edit-config for configuration 01-mdsal.xml(odl-openflowplugin-flow-services-ui,odl-mdsal-broker)
              at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.sendRequestGetResponseCheckIsOK(ConfigPusherImpl.java:293)
              at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.pushConfig(ConfigPusherImpl.java:244)
              at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.pushConfigWithConflictingVersionRetries(ConfigPusherImpl.java:136)
              at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.internalPushConfigs(ConfigPusherImpl.java:109)
              at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.process(ConfigPusherImpl.java:76)
              at org.opendaylight.controller.netconf.persist.impl.osgi.ConfigPersisterActivator$InnerCustomizer$1.run(ConfigPersisterActivator.java:178)
              at java.lang.Thread.run(Thread.java:745)
Caused by: NetconfDocumentedException{message=Error reading module prefix:binding-forwarded-data-broker : pingpong-binding-data-broker - Unrecognised elements [XmlElement{name='schema-service', namespace='urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding:impl'}] in XmlElement{name='binding-forwarded-data-broker', namespace='urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding:impl'}, errorType=application, errorTag=invalid_value, errorSeverity=error, errorInfo={}}
              at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.InstanceConfig.fromXml(InstanceConfig.java:183)
              at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.ModuleConfig.fromXml(ModuleConfig.java:61)
              at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config$1.resolveElement(Config.java:146)
              at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config$1.resolveElement(Config.java:143)
              at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config.resolveModule(Config.java:223)
              at org.opendaylight.controller.netconf.confignetconfconnector.mapping.config.Config.fromXmlModulesResolved(Config.java:151)
              at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfigXmlParser$EditConfigExecution.getResolvedXmlElements(EditConfigXmlParser.java:176)
              at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.setOnTransaction(EditConfig.java:180)
              at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.test(EditConfig.java:121)
              at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.executeTests(EditConfig.java:97)
              at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.getResponseInternal(EditConfig.java:76)
              at org.opendaylight.controller.netconf.confignetconfconnector.operations.editconfig.EditConfig.handleWithNoSubsequentOperations(EditConfig.java:307)
              at org.opendaylight.controller.netconf.util.mapping.AbstractLastNetconfOperation.handle(AbstractLastNetconfOperation.java:33)
              at org.opendaylight.controller.netconf.util.mapping.AbstractNetconfOperation.handle(AbstractNetconfOperation.java:105)
              at org.opendaylight.controller.netconf.persist.impl.ConfigPusherImpl.sendRequestGetResponseCheckIsOK(ConfigPusherImpl.java:288)
              ... 6 more


After that OpenFlow port 6633 is down and any RESTCONF call I try returns 503 Service Unavailable.

This seems started to happen after this merge:

https://git.opendaylight.org/gerrit/#/c/14245/

But maybe it is something else. Can you please take a look?

Thanks/Luis
 
 
_______________________________________________ controller-dev mailing list controller-dev@...https://lists.opendaylight.org/mailman/listinfo/controller-dev




_______________________________________________
integration-dev mailing list
integration-dev@...
https://lists.opendaylight.org/mailman/listinfo/integration-dev

_______________________________________________
integration-dev mailing list
integration-dev@...
https://lists.opendaylight.org/mailman/listinfo/integration-dev
Join {integration-dev@lists.opendaylight.org to automatically receive all group messages.