Date
1 - 9 of 9
[opendaylight-dev] serviceutils view in jjb messing up my jenkins-job pushing
Thanh Ha <thanh.ha@...>
On Thu, Jun 21, 2018 at 7:34 AM Anil Belur <abelur@...> wrote:
Seems like a breaking change for ODL's JJB users. We should document this, update the example jenkins.ini.example in releng/builder and notify the community when a change like this is requires users to modify their environment. Regards, Thanh |
|
JamO Luhrsen
On 6/21/18 7:45 AM, Thanh Ha wrote:
On Thu, Jun 21, 2018 at 7:34 AM Anil Belur <abelur@... <mailto:abelur@...>> wrote:I think this is happening every 1-2 months lately. JamO Regards, |
|
Robert Varga
On 21/06/18 16:50, Jamo Luhrsen wrote:
Could this also explain why verify-javadoc jobs are suddenly using mvn35I think this is happening every 1-2 months lately. instead of mvn33 ? Regards, Robert |
|
Thanh Ha <thanh.ha@...>
On Thu, Jun 21, 2018 at 11:08 AM Robert Varga <nite@...> wrote: On 21/06/18 16:50, Jamo Luhrsen wrote: Hi Robert, That was caused by this patch https://git.opendaylight.org/gerrit/71087 which was merged 9 weeks ago. Which was a result of this Jira https://jira.opendaylight.org/browse/RELENG-97 when we were having off-by-1 artifact issues with the Nitrogen stream back when we were trying to get Nitrogen-SR3 out the door. There was a decision on the mailing list https://lists.opendaylight.org/pipermail/release/2018-April/014799.html to migrate to Maven 3.5.3 moving forward so that we would (hopefully) stop hitting that off by 1 artifact bug in maven versions < 3.5.2. Initially we only rolled it out to merge jobs to get over the Nitrogen-SR3 blocker but eventually rolled it out to the remaining jobs. Regards, Thanh |
|
Thanh Ha <thanh.ha@...>
On Thu, Jun 21, 2018 at 10:50 AM Jamo Luhrsen <jluhrsen@...> wrote: On 6/21/18 7:45 AM, Thanh Ha wrote: We definitely dropped the ball here, this change should have been better communicated to the community before it was rolled out. Sorry about that. Regards, Thanh |
|
Robert Varga
On 21/06/18 17:17, Thanh Ha wrote:
On Thu, Jun 21, 2018 at 11:08 AM Robert Varga <nite@...Thanks for the clarification, but it was rolled out between https://jenkins.opendaylight.org/releng/job/mdsal-maven-javadoc-verify-fluorine/1123/ https://jenkins.opendaylight.org/releng/job/mdsal-maven-javadoc-verify-fluorine/1125/ i.e. on June 19, with no mention of this happening. mdsal now cannot successfully verify and after spending a day on the issue I am no closer to seeing a way to resolve it. Regards, Robert |
|
Thanh Ha <thanh.ha@...>
On Thu, Jun 21, 2018 at 11:27 AM Robert Varga <nite@...> wrote: On 21/06/18 17:17, Thanh Ha wrote: I tracked this down. It was caused by the upgrade to global-jjb v0.21.0 patch: After inspecting the commit log of global-jjb for versions between v0.19.2 to v0.21.0 and release notes: The patch 10394 changes the "default" Maven version from mvn33 to mvn35 in the global-jjb template and in releng/builder we were not overriding the mvn-version for the javadoc job. Normally we override via the job-group here: but the javadoc jobs are not in that list so was accepting the default value coming from upstream global-jjb. This is why the javadoc jobs did not switch to mvn35 when we migrated all the other jobs. With that said, if mvn35 is causing issues for mdsal, we can explicitly set the version back to mvn33 for the javadoc job with this patch: In hindsight this is definitely something we missed in evaluating impact of the global-jjb upgrade as missed the fact that javadoc job mvn-version setting was pulling in the default value rather than the value explicitly set by the ODL job group. This is because not all projects have javadocs to publish so it was not included in the job-group. Moving forward one solution is to ensure that every project that specifies a "javadoc" job in their JJB YAML that they explicitly set the mvn-version setting to ensure we do not get surprises like this again in the future. Regards, Thanh |
|
Robert Varga
On 21/06/18 18:28, Thanh Ha wrote:
This will work for the time being :) Thanks a bunch, Robert |
|
Daniel Farrell
On Thu, Jun 21, 2018 at 12:42 PM Robert Varga <nite@...> wrote: On 21/06/18 18:28, Thanh Ha wrote: Merged, give it a try. Daniel
|
|