code review


Luis Gomez
 

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz


Luis Gomez
 

Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz



Emmett Cox <emmett.cox@...>
 

Hi Luis,

Tested to check for your questions:

- The new header does work with RFC8040 put

- the new header does not work with older restconf implementations

Regards,

Emmett

On 06/09/2019 21:27, Luis Gomez wrote:

Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz



Mariusz Sobucki <mariusz.sobucki@...>
 

Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 

Hi Luis,

Tested to check for your questions:

- The new header does work with RFC8040 put

- the new header does not work with older restconf implementations

Regards,

Emmett

On 06/09/2019 21:27, Luis Gomez wrote:

Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz



Luis Gomez
 

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
    [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
    SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
    NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz


Luis Gomez
 

OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.

BR/Luis


On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
    [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
    SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
    NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz



Mariusz Sobucki <mariusz.sobucki@...>
 

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
    [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
    SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
    NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 

Hi Luis,

Tested to check for your questions:

- The new header does work with RFC8040 put

- the new header does not work with older restconf implementations

Regards,

Emmett

On 06/09/2019 21:27, Luis Gomez wrote:

Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz



Luis Gomez
 

OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.

BR/Luis

On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.

BR/Luis


On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
    [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
    SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
    NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


Mariusz Sobucki <mariusz.sobucki@...>
 

Hi Luis,
The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.

I think it should work in fluorine as custom rpc is supported in this release.

Please let me know if you have any idea what the problem could be.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Monday 9 September 2019 20:58
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>
Subject: Re: [integration-dev] code review
 
OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.

BR/Luis

On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.

BR/Luis


On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
    [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
    SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
    NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


Luis Gomez
 

I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?

BR/Luis



On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.

I think it should work in fluorine as custom rpc is supported in this release.

Please let me know if you have any idea what the problem could be.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Monday 9 September 2019 20:58
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>
Subject: Re: [integration-dev] code review
 
OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.

BR/Luis

On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.

BR/Luis


On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
    [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
    SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
    NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


mariusz.sobucki@est.tech <mariusz.sobucki@...>
 

Hi Luis,
Thanks for help. I have restored the log redirection  as it was before.
Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work. 
So it seems like i am not able to add any file.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Tuesday 10 September 2019 19:30
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?

BR/Luis



On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.

I think it should work in fluorine as custom rpc is supported in this release.

Please let me know if you have any idea what the problem could be.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Monday 9 September 2019 20:58
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>
Subject: Re: [integration-dev] code review
 
OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.

BR/Luis

On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.

BR/Luis


On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
    [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
    SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
    NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13 ==============================================================================
11:13:13 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
11:13:13 ==============================================================================
11:13:16 Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
11:14:19 Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
11:14:19 ------------------------------------------------------------------------------
11:14:19 Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
11:14:20 ------------------------------------------------------------------------------
11:14:20 Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
11:14:40 Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
11:14:40  "node": [
11:14:40   {
11:14:40    "netconf-node-topology:connection-status": "connecting",
11:14:40    "netconf-node-topology:host": "10.30.170.53",
11:14:40    "netconf-node-topology:port": 17830,
11:14:40    "node-id": "netconf-test-device"
11:14:40   }
11:14:40  ]
11:14:40 }
11:14:40 ' does not contain '"netconf-node-topology:connection-status": "connected"'
11:14:40 ------------------------------------------------------------------------------
11:14:40 Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
11:14:40 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:40 ------------------------------------------------------------------------------
11:14:40 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
11:14:41 [ 200 | 201 | 204 ] does not contain value '404'.
11:14:41 ------------------------------------------------------------------------------
11:14:41 netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
11:14:41 3 critical tests, 3 passed, 0 failed
11:14:41 8 tests total, 3 passed, 5 failed
11:14:41 ==============================================================================

Regards,
Mariusz

From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review
 
Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:


- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.


Thank you.

Mariusz


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


Luis Gomez
 

OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):

/usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true

However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.

I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.

Let me know of you have further questions

BR/Luis

On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Thanks for help. I have restored the log redirection as it was before.
Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work.
So it seems like i am not able to add any file.


Regards,
Mariusz
From: Luis Gomez <ecelgp@...>
Sent: Tuesday 10 September 2019 19:30
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review

I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?

BR/Luis



On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.

I think it should work in fluorine as custom rpc is supported in this release.

Please let me know if you have any idea what the problem could be.


Regards,
Mariusz
From: Luis Gomez <ecelgp@...>
Sent: Monday 9 September 2019 20:58
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>
Subject: Re: [integration-dev] code review

OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.

BR/Luis

On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.

BR/Luis


On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08
Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |

18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
[Documentation] Deploy and start test tool, then wait for all its devices to become online.
SSHLibrary.File Should Exist ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
NetconfKeywords.Install_And_Start_Testtool device-count=1 schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz
From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review

Hi Luis,
I am trying to debug Start_Testtool failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13
==============================================================================

11:13:13
netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...

11:13:13
==============================================================================

11:13:16
Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |

11:14:19
Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1

11:14:19
------------------------------------------------------------------------------

11:14:19
Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |

11:14:19
------------------------------------------------------------------------------

11:14:19
Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |

11:14:19
------------------------------------------------------------------------------

11:14:19
Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |

11:14:20
------------------------------------------------------------------------------

11:14:20
Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |

11:14:40
Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{

11:14:40
"node": [

11:14:40
{

11:14:40
"netconf-node-topology:connection-status": "connecting",

11:14:40
"netconf-node-topology:host": "10.30.170.53",

11:14:40
"netconf-node-topology:port": 17830,

11:14:40
"node-id": "netconf-test-device"

11:14:40
}

11:14:40
]

11:14:40
}

11:14:40
' does not contain '"netconf-node-topology:connection-status": "connected"'

11:14:40
------------------------------------------------------------------------------

11:14:40
Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |

11:14:40
[ 200 | 201 | 204 ] does not contain value '404'.

11:14:40
------------------------------------------------------------------------------

11:14:40
Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |

11:14:41
[ 200 | 201 | 204 ] does not contain value '404'.

11:14:41
------------------------------------------------------------------------------

11:14:41
Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |

11:14:41
[ 200 | 201 | 204 ] does not contain value '404'.

11:14:41
------------------------------------------------------------------------------

11:14:41
netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |

11:14:41
3 critical tests, 3 passed, 0 failed

11:14:41
8 tests total, 3 passed, 5 failed

11:14:41 ==============================================================================

Regards,
Mariusz
From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review

Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:

https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201

- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/


Thank you.

Mariusz
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


mariusz.sobucki@est.tech <mariusz.sobucki@...>
 

Hi Luis,
Thanks for your help. 

There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?

Copy_File_To_Tools_System
[Arguments] ${system} ${source} ${destination}=./
[Documentation] Wrapper keyword to make it easier to copy a file to an Tools specific system
SSHKeywords.Copy_File_To_Remote_System ${system} ${source} ${destination} ${TOOLS_SYSTEM_USER} ${TOOLS_SYSTEM_PASSWORD} ${TOOLS_SYSTEM_PROMPT}
Can I use one of below as a ${system} argument?
${TOOLS_SYSTEM_1_IP}    127.0.0.1    # IP address of first system hosting testing tools.
${TOOLS_SYSTEM_2_IP} 127.0.0.2 # IP address of second system hosting testing tools.
${TOOLS_SYSTEM_3_IP} 127.0.0.3 # IP address of third system hosting testing tools.
I would like to test this, but it seems that all Jenkins jobs fail now with:

16:58:56 Failed!
16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml

Wonder if you're aware of this.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Wednesday 11 September 2019 21:46
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):

/usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar  --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true

However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.

I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.

Let me know of you have further questions

BR/Luis



> On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>
> Hi Luis,
> Thanks for help. I have restored the log redirection  as it was before.
> Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work.
> So it seems like i am not able to add any file.
>
>
> Regards,
> Mariusz
> From: Luis Gomez <ecelgp@...>
> Sent: Tuesday 10 September 2019 19:30
> To: Mariusz Sobucki <mariusz.sobucki@...>
> Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
> Subject: Re: [integration-dev] code review

> I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?
>
> BR/Luis
>
>
>
>> On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>
>> Hi Luis,
>> The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
>> So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.
>>
>> I think it should work in fluorine as custom rpc is supported in this release.
>>
>> Please let me know if you have any idea what the problem could be.
>>
>>
>> Regards,
>> Mariusz
>> From: Luis Gomez <ecelgp@...>
>> Sent: Monday 9 September 2019 20:58
>> To: Mariusz Sobucki <mariusz.sobucki@...>
>> Cc: integration-dev@... <integration-dev@...>
>> Subject: Re: [integration-dev] code review
>> 
>> OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.
>>
>> BR/Luis
>>
>>> On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>>
>>> OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.
>>>
>>> BR/Luis
>>>
>>>
>>>> On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:
>>>>
>>>> Hi Mariusz,
>>>>
>>>> The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?
>>>>
>>>> If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.
>>>>
>>>> BR/Luis
>>>>
>>>>
>>>>> On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>>
>>>>> Hi Luis,
>>>>>
>>>>> While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
>>>>> 18:33:08
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>>
>>>>> 18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
>>>>> The rpc config file is used when starting testtool in CRUD-ACTION.robot:
>>>>> Start_Testtool
>>>>>     [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
>>>>>     SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>>     NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>>
>>>>> The file is also added as part of this code change:
>>>>> integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml
>>>>>
>>>>> I wonder if there is anything wrong with the path we are using or the way we add the file?
>>>>> I would appreciate any comments regarding this.
>>>>>
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Sent: Monday 9 September 2019 14:23
>>>>> To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>> 
>>>>> Hi Luis,
>>>>> I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?
>>>>>
>>>>> 11:13:13
>>>>> ==============================================================================
>>>>>
>>>>> 11:13:13
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
>>>>>
>>>>> 11:13:13
>>>>> ==============================================================================
>>>>>
>>>>> 11:13:16
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>>
>>>>> 11:14:19
>>>>> Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
>>>>>
>>>>> 11:14:19
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:19
>>>>> Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
>>>>>
>>>>> 11:14:19
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:19
>>>>> Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
>>>>>
>>>>> 11:14:19
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:19
>>>>> Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
>>>>>
>>>>> 11:14:20
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:20
>>>>> Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
>>>>>
>>>>> 11:14:40
>>>>> Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
>>>>>
>>>>> 11:14:40
>>>>>  "node": [
>>>>>
>>>>> 11:14:40
>>>>>   {
>>>>>
>>>>> 11:14:40
>>>>>    "netconf-node-topology:connection-status": "connecting",
>>>>>
>>>>> 11:14:40
>>>>>    "netconf-node-topology:host": "10.30.170.53",
>>>>>
>>>>> 11:14:40
>>>>>    "netconf-node-topology:port": 17830,
>>>>>
>>>>> 11:14:40
>>>>>    "node-id": "netconf-test-device"
>>>>>
>>>>> 11:14:40
>>>>>   }
>>>>>
>>>>> 11:14:40
>>>>>  ]
>>>>>
>>>>> 11:14:40
>>>>> }
>>>>>
>>>>> 11:14:40
>>>>> ' does not contain '"netconf-node-topology:connection-status": "connected"'
>>>>>
>>>>> 11:14:40
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:40
>>>>> Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
>>>>>
>>>>> 11:14:40
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>>
>>>>> 11:14:40
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:40
>>>>> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>>>>>
>>>>> 11:14:41
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>>
>>>>> 11:14:41
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:41
>>>>> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>>>>>
>>>>> 11:14:41
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>>
>>>>> 11:14:41
>>>>> ------------------------------------------------------------------------------
>>>>>
>>>>> 11:14:41
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
>>>>>
>>>>> 11:14:41
>>>>> 3 critical tests, 3 passed, 0 failed
>>>>>
>>>>> 11:14:41
>>>>> 8 tests total, 3 passed, 5 failed
>>>>>
>>>>> 11:14:41 ==============================================================================
>>>>>
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Emmett Cox <emmett.cox@...>
>>>>> Sent: Monday 9 September 2019 10:43
>>>>> To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>> 
>>>>> Hi Luis,
>>>>> Tested to check for your questions:
>>>>> - The new header does work with RFC8040 put
>>>>> - the new header does not work with older restconf implementations
>>>>> Regards,
>>>>> Emmett
>>>>> On 06/09/2019 21:27, Luis Gomez wrote:
>>>>>> Hi, I have couple of questions on this change:
>>>>>>
>>>>>> https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201
>>>>>>
>>>>>> - Does the new header works also with RFC8040 PUT?
>>>>>> - Does the new header works with older RESTCONF implementation?
>>>>>>
>>>>>> BR/Luis
>>>>>>
>>>>>>
>>>>>>> On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:
>>>>>>>
>>>>>>> Thanks Mariusz,
>>>>>>>
>>>>>>> Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.
>>>>>>>
>>>>>>> BR/Luis
>>>>>>>
>>>>>>>
>>>>>>>> On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>>>>>
>>>>>>>> Hi Luis,
>>>>>>>> Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
>>>>>>>> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>>>>>>>>
>>>>>>>>
>>>>>>>> Thank you.
>>>>>>>>
>>>>>>>> Mariusz
>>>>
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
>>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> Group Owner: integration-dev+owner@...
>>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> -=-=-=-=-=-=-=-=-=-=-=-


Luis Gomez
 

Yes, this seems like a good KW to use. Also the CSIT is currently broken because a python missing dependency in the vexhost script:

09:45:54 No module named v1.contrib
09:45:54 Build step 'Execute shell' marked build as failure

Anil, can you please take a look what is missing here?

BR/Luis


On Sep 12, 2019, at 9:06 AM, mariusz.sobucki@... wrote:

Hi Luis,
Thanks for your help. 

There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?

Copy_File_To_Tools_System
[Arguments] ${system} ${source} ${destination}=./
[Documentation] Wrapper keyword to make it easier to copy a file to an Tools specific system
SSHKeywords.Copy_File_To_Remote_System ${system} ${source} ${destination} ${TOOLS_SYSTEM_USER} ${TOOLS_SYSTEM_PASSWORD} ${TOOLS_SYSTEM_PROMPT}
Can I use one of below as a ${system} argument?
${TOOLS_SYSTEM_1_IP}    127.0.0.1    # IP address of first system hosting testing tools.
${TOOLS_SYSTEM_2_IP} 127.0.0.2 # IP address of second system hosting testing tools.
${TOOLS_SYSTEM_3_IP} 127.0.0.3 # IP address of third system hosting testing tools.
I would like to test this, but it seems that all Jenkins jobs fail now with:

16:58:56 Failed!
16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml

Wonder if you're aware of this.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Wednesday 11 September 2019 21:46
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):

/usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar  --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true

However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.

I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.

Let me know of you have further questions

BR/Luis



> On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
> 
> Hi Luis,
> Thanks for help. I have restored the log redirection  as it was before.
> Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work. 
> So it seems like i am not able to add any file.
> 
> 
> Regards,
> Mariusz
> From: Luis Gomez <ecelgp@...>
> Sent: Tuesday 10 September 2019 19:30
> To: Mariusz Sobucki <mariusz.sobucki@...>
> Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
> Subject: Re: [integration-dev] code review
 
> I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?
> 
> BR/Luis
> 
> 
> 
>> On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>> 
>> Hi Luis,
>> The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
>> So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.
>> 
>> I think it should work in fluorine as custom rpc is supported in this release.
>> 
>> Please let me know if you have any idea what the problem could be.
>> 
>> 
>> Regards,
>> Mariusz
>> From: Luis Gomez <ecelgp@...>
>> Sent: Monday 9 September 2019 20:58
>> To: Mariusz Sobucki <mariusz.sobucki@...>
>> Cc: integration-dev@... <integration-dev@...>
>> Subject: Re: [integration-dev] code review
>>  
>> OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.
>> 
>> BR/Luis
>> 
>>> On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>> 
>>> OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.
>>> 
>>> BR/Luis
>>> 
>>> 
>>>> On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:
>>>> 
>>>> Hi Mariusz,
>>>> 
>>>> The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?
>>>> 
>>>> If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.
>>>> 
>>>> BR/Luis
>>>> 
>>>> 
>>>>> On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>> 
>>>>> Hi Luis,
>>>>> 
>>>>> While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
>>>>> 18:33:08 
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>> 
>>>>> 18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
>>>>> The rpc config file is used when starting testtool in CRUD-ACTION.robot:
>>>>> Start_Testtool
>>>>>     [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
>>>>>     SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>>     NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>> 
>>>>> The file is also added as part of this code change:
>>>>> integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml
>>>>> 
>>>>> I wonder if there is anything wrong with the path we are using or the way we add the file?
>>>>> I would appreciate any comments regarding this.
>>>>> 
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Sent: Monday 9 September 2019 14:23
>>>>> To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>>  
>>>>> Hi Luis,
>>>>> I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?
>>>>> 
>>>>> 11:13:13 
>>>>> ==============================================================================
>>>>> 
>>>>> 11:13:13 
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
>>>>> 
>>>>> 11:13:13 
>>>>> ==============================================================================
>>>>> 
>>>>> 11:13:16 
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>> 
>>>>> 11:14:19 
>>>>> Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
>>>>> 
>>>>> 11:14:20 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:20 
>>>>> Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
>>>>> 
>>>>> 11:14:40 
>>>>> Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
>>>>> 
>>>>> 11:14:40 
>>>>>  "node": [
>>>>> 
>>>>> 11:14:40 
>>>>>   {
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:connection-status": "connecting",
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:host": "10.30.170.53",
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:port": 17830,
>>>>> 
>>>>> 11:14:40 
>>>>>    "node-id": "netconf-test-device"
>>>>> 
>>>>> 11:14:40 
>>>>>   }
>>>>> 
>>>>> 11:14:40 
>>>>>  ]
>>>>> 
>>>>> 11:14:40 
>>>>> }
>>>>> 
>>>>> 11:14:40 
>>>>> ' does not contain '"netconf-node-topology:connection-status": "connected"'
>>>>> 
>>>>> 11:14:40 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:40 
>>>>> Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
>>>>> 
>>>>> 11:14:40 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:40 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:40 
>>>>> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>>>>> 
>>>>> 11:14:41 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:41 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:41 
>>>>> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>>>>> 
>>>>> 11:14:41 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:41 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:41 
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
>>>>> 
>>>>> 11:14:41 
>>>>> 3 critical tests, 3 passed, 0 failed
>>>>> 
>>>>> 11:14:41 
>>>>> 8 tests total, 3 passed, 5 failed
>>>>> 
>>>>> 11:14:41 ==============================================================================
>>>>> 
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Emmett Cox <emmett.cox@...>
>>>>> Sent: Monday 9 September 2019 10:43
>>>>> To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>>  
>>>>> Hi Luis,
>>>>> Tested to check for your questions:
>>>>> - The new header does work with RFC8040 put
>>>>> - the new header does not work with older restconf implementations
>>>>> Regards,
>>>>> Emmett
>>>>> On 06/09/2019 21:27, Luis Gomez wrote:
>>>>>> Hi, I have couple of questions on this change:
>>>>>> 
>>>>>> https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201
>>>>>> 
>>>>>> - Does the new header works also with RFC8040 PUT?
>>>>>> - Does the new header works with older RESTCONF implementation?
>>>>>> 
>>>>>> BR/Luis
>>>>>> 
>>>>>> 
>>>>>>> On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:
>>>>>>> 
>>>>>>> Thanks Mariusz,
>>>>>>> 
>>>>>>> Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.
>>>>>>> 
>>>>>>> BR/Luis
>>>>>>> 
>>>>>>> 
>>>>>>>> On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>>>>> 
>>>>>>>> Hi Luis,
>>>>>>>> Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
>>>>>>>> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Thank you.
>>>>>>>> 
>>>>>>>> Mariusz
>>>> 
>>> 
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> 
>>> View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
>>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> Group Owner: integration-dev+owner@...
>>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13696): https://lists.opendaylight.org/g/integration-dev/message/13696
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


Luis Gomez
 

Full log here:


09:45:52 ---> Create HEAT stack
09:45:52 + openstack --os-cloud vex limits show --absolute
09:45:54 No module named v1.contrib
09:45:54 Build step 'Execute shell' marked build as failure



On Sep 12, 2019, at 9:48 AM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

Yes, this seems like a good KW to use. Also the CSIT is currently broken because a python missing dependency in the vexhost script:

09:45:54 No module named v1.contrib
09:45:54 Build step 'Execute shell' marked build as failure

Anil, can you please take a look what is missing here?

BR/Luis


On Sep 12, 2019, at 9:06 AM, mariusz.sobucki@... wrote:

Hi Luis,
Thanks for your help. 

There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?

Copy_File_To_Tools_System
[Arguments] ${system} ${source} ${destination}=./
[Documentation] Wrapper keyword to make it easier to copy a file to an Tools specific system
SSHKeywords.Copy_File_To_Remote_System ${system} ${source} ${destination} ${TOOLS_SYSTEM_USER} ${TOOLS_SYSTEM_PASSWORD} ${TOOLS_SYSTEM_PROMPT}
Can I use one of below as a ${system} argument?
${TOOLS_SYSTEM_1_IP}    127.0.0.1    # IP address of first system hosting testing tools.
${TOOLS_SYSTEM_2_IP} 127.0.0.2 # IP address of second system hosting testing tools.
${TOOLS_SYSTEM_3_IP} 127.0.0.3 # IP address of third system hosting testing tools.
I would like to test this, but it seems that all Jenkins jobs fail now with:

16:58:56 Failed!
16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml

Wonder if you're aware of this.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Wednesday 11 September 2019 21:46
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):

/usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar  --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true

However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.

I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.

Let me know of you have further questions

BR/Luis



> On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
> 
> Hi Luis,
> Thanks for help. I have restored the log redirection  as it was before.
> Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work. 
> So it seems like i am not able to add any file.
> 
> 
> Regards,
> Mariusz
> From: Luis Gomez <ecelgp@...>
> Sent: Tuesday 10 September 2019 19:30
> To: Mariusz Sobucki <mariusz.sobucki@...>
> Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
> Subject: Re: [integration-dev] code review
 
> I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?
> 
> BR/Luis
> 
> 
> 
>> On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>> 
>> Hi Luis,
>> The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
>> So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.
>> 
>> I think it should work in fluorine as custom rpc is supported in this release.
>> 
>> Please let me know if you have any idea what the problem could be.
>> 
>> 
>> Regards,
>> Mariusz
>> From: Luis Gomez <ecelgp@...>
>> Sent: Monday 9 September 2019 20:58
>> To: Mariusz Sobucki <mariusz.sobucki@...>
>> Cc: integration-dev@... <integration-dev@...>
>> Subject: Re: [integration-dev] code review
>>  
>> OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.
>> 
>> BR/Luis
>> 
>>> On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>> 
>>> OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.
>>> 
>>> BR/Luis
>>> 
>>> 
>>>> On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:
>>>> 
>>>> Hi Mariusz,
>>>> 
>>>> The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?
>>>> 
>>>> If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.
>>>> 
>>>> BR/Luis
>>>> 
>>>> 
>>>>> On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>> 
>>>>> Hi Luis,
>>>>> 
>>>>> While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
>>>>> 18:33:08 
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>> 
>>>>> 18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
>>>>> The rpc config file is used when starting testtool in CRUD-ACTION.robot:
>>>>> Start_Testtool
>>>>>     [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
>>>>>     SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>>     NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>> 
>>>>> The file is also added as part of this code change:
>>>>> integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml
>>>>> 
>>>>> I wonder if there is anything wrong with the path we are using or the way we add the file?
>>>>> I would appreciate any comments regarding this.
>>>>> 
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Sent: Monday 9 September 2019 14:23
>>>>> To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>>  
>>>>> Hi Luis,
>>>>> I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?
>>>>> 
>>>>> 11:13:13 
>>>>> ==============================================================================
>>>>> 
>>>>> 11:13:13 
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
>>>>> 
>>>>> 11:13:13 
>>>>> ==============================================================================
>>>>> 
>>>>> 11:13:16 
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>> 
>>>>> 11:14:19 
>>>>> Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
>>>>> 
>>>>> 11:14:20 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:20 
>>>>> Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
>>>>> 
>>>>> 11:14:40 
>>>>> Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
>>>>> 
>>>>> 11:14:40 
>>>>>  "node": [
>>>>> 
>>>>> 11:14:40 
>>>>>   {
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:connection-status": "connecting",
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:host": "10.30.170.53",
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:port": 17830,
>>>>> 
>>>>> 11:14:40 
>>>>>    "node-id": "netconf-test-device"
>>>>> 
>>>>> 11:14:40 
>>>>>   }
>>>>> 
>>>>> 11:14:40 
>>>>>  ]
>>>>> 
>>>>> 11:14:40 
>>>>> }
>>>>> 
>>>>> 11:14:40 
>>>>> ' does not contain '"netconf-node-topology:connection-status": "connected"'
>>>>> 
>>>>> 11:14:40 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:40 
>>>>> Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
>>>>> 
>>>>> 11:14:40 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:40 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:40 
>>>>> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>>>>> 
>>>>> 11:14:41 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:41 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:41 
>>>>> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>>>>> 
>>>>> 11:14:41 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:41 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:41 
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
>>>>> 
>>>>> 11:14:41 
>>>>> 3 critical tests, 3 passed, 0 failed
>>>>> 
>>>>> 11:14:41 
>>>>> 8 tests total, 3 passed, 5 failed
>>>>> 
>>>>> 11:14:41 ==============================================================================
>>>>> 
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Emmett Cox <emmett.cox@...>
>>>>> Sent: Monday 9 September 2019 10:43
>>>>> To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>>  
>>>>> Hi Luis,
>>>>> Tested to check for your questions:
>>>>> - The new header does work with RFC8040 put
>>>>> - the new header does not work with older restconf implementations
>>>>> Regards,
>>>>> Emmett
>>>>> On 06/09/2019 21:27, Luis Gomez wrote:
>>>>>> Hi, I have couple of questions on this change:
>>>>>> 
>>>>>> https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201
>>>>>> 
>>>>>> - Does the new header works also with RFC8040 PUT?
>>>>>> - Does the new header works with older RESTCONF implementation?
>>>>>> 
>>>>>> BR/Luis
>>>>>> 
>>>>>> 
>>>>>>> On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:
>>>>>>> 
>>>>>>> Thanks Mariusz,
>>>>>>> 
>>>>>>> Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.
>>>>>>> 
>>>>>>> BR/Luis
>>>>>>> 
>>>>>>> 
>>>>>>>> On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>>>>> 
>>>>>>>> Hi Luis,
>>>>>>>> Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
>>>>>>>> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Thank you.
>>>>>>>> 
>>>>>>>> Mariusz
>>>> 
>>> 
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> 
>>> View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
>>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> Group Owner: integration-dev+owner@...
>>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13696): https://lists.opendaylight.org/g/integration-dev/message/13696
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13697): https://lists.opendaylight.org/g/integration-dev/message/13697
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


mariusz.sobucki@est.tech <mariusz.sobucki@...>
 

Hi Luis,
Thank you for advise. Now Testtool starts ok 🙂. 
There are two test cases which fail though(see below). 
I am not sure what is the problem since they pass locally. Could you please advise?

Link to JJB:
https://jenkins.opendaylight.org/releng/job/netconf-csit-verify-1node-gate-userfeatures/183/console


Code review:
https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/


10:45:09 ------------------------------------------------------------------------------
10:45:09 Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
10:45:10 [ 200 | 201 | 204 ] does not contain value '404'.
10:45:10 ------------------------------------------------------------------------------
10:45:10 Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
10:45:10 [ 200 | 201 | 204 ] does not contain value '404'.
10:45:10 ------------------------------------------------------------------------------


One more question if you don't mind.

This new CRUD-Action test suite has been placed under  csit/suites/netconf/CRUD. This is part of netconf-userfeatures.txt testplan. I think this might be a problem. Yang 1.1 actions that is part of this change is only supported since sodium onwards. That is why the Jenkins jobs for this particular tests should only run on sodium and magnesium. However tests under testplan netconf-userfeatures.txt are ran against sodium/neon/fluorine branches. Please correct me if I'm wrong here.

I think we could fix it by creating new testplan and move the CRUD-Action test suite there. Then we could create new project in releng/builder repository under builder/jjb/netconf (next to existing netconf-userfeatures.yaml) which would run only on sodium/magnesium branches.

Please let me know if this makes sense and/or anything is missing here. Or maybe this can be done in a different/better way? Is there any documentation in this matter?

Kind regards,
Mariusz


From: Luis Gomez <ecelgp@...>
Sent: Thursday 12 September 2019 17:50
To: Mariusz Sobucki <mariusz.sobucki@...>; Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>
Subject: Re: [integration-dev] code review
 
Full log here:


09:45:52 ---> Create HEAT stack
09:45:52 + openstack --os-cloud vex limits show --absolute
09:45:54 No module named v1.contrib
09:45:54 Build step 'Execute shell' marked build as failure



On Sep 12, 2019, at 9:48 AM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

Yes, this seems like a good KW to use. Also the CSIT is currently broken because a python missing dependency in the vexhost script:

09:45:54 No module named v1.contrib
09:45:54 Build step 'Execute shell' marked build as failure

Anil, can you please take a look what is missing here?

BR/Luis


On Sep 12, 2019, at 9:06 AM, mariusz.sobucki@... wrote:

Hi Luis,
Thanks for your help. 

There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?

Copy_File_To_Tools_System
[Arguments] ${system} ${source} ${destination}=./
[Documentation] Wrapper keyword to make it easier to copy a file to an Tools specific system
SSHKeywords.Copy_File_To_Remote_System ${system} ${source} ${destination} ${TOOLS_SYSTEM_USER} ${TOOLS_SYSTEM_PASSWORD} ${TOOLS_SYSTEM_PROMPT}
Can I use one of below as a ${system} argument?
${TOOLS_SYSTEM_1_IP}    127.0.0.1    # IP address of first system hosting testing tools.
${TOOLS_SYSTEM_2_IP} 127.0.0.2 # IP address of second system hosting testing tools.
${TOOLS_SYSTEM_3_IP} 127.0.0.3 # IP address of third system hosting testing tools.
I would like to test this, but it seems that all Jenkins jobs fail now with:

16:58:56 Failed!
16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml

Wonder if you're aware of this.


Regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Wednesday 11 September 2019 21:46
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):

/usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar  --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true

However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.

I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.

Let me know of you have further questions

BR/Luis



> On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
> 
> Hi Luis,
> Thanks for help. I have restored the log redirection  as it was before.
> Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work. 
> So it seems like i am not able to add any file.
> 
> 
> Regards,
> Mariusz
> From: Luis Gomez <ecelgp@...>
> Sent: Tuesday 10 September 2019 19:30
> To: Mariusz Sobucki <mariusz.sobucki@...>
> Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
> Subject: Re: [integration-dev] code review
 
> I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?
> 
> BR/Luis
> 
> 
> 
>> On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>> 
>> Hi Luis,
>> The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
>> So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.
>> 
>> I think it should work in fluorine as custom rpc is supported in this release.
>> 
>> Please let me know if you have any idea what the problem could be.
>> 
>> 
>> Regards,
>> Mariusz
>> From: Luis Gomez <ecelgp@...>
>> Sent: Monday 9 September 2019 20:58
>> To: Mariusz Sobucki <mariusz.sobucki@...>
>> Cc: integration-dev@... <integration-dev@...>
>> Subject: Re: [integration-dev] code review
>>  
>> OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.
>> 
>> BR/Luis
>> 
>>> On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>> 
>>> OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.
>>> 
>>> BR/Luis
>>> 
>>> 
>>>> On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:
>>>> 
>>>> Hi Mariusz,
>>>> 
>>>> The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?
>>>> 
>>>> If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.
>>>> 
>>>> BR/Luis
>>>> 
>>>> 
>>>>> On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>> 
>>>>> Hi Luis,
>>>>> 
>>>>> While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
>>>>> 18:33:08 
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>> 
>>>>> 18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
>>>>> The rpc config file is used when starting testtool in CRUD-ACTION.robot:
>>>>> Start_Testtool
>>>>>     [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
>>>>>     SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>>     NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>>>> 
>>>>> The file is also added as part of this code change:
>>>>> integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml
>>>>> 
>>>>> I wonder if there is anything wrong with the path we are using or the way we add the file?
>>>>> I would appreciate any comments regarding this.
>>>>> 
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Sent: Monday 9 September 2019 14:23
>>>>> To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>>  
>>>>> Hi Luis,
>>>>> I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?
>>>>> 
>>>>> 11:13:13 
>>>>> ==============================================================================
>>>>> 
>>>>> 11:13:13 
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
>>>>> 
>>>>> 11:13:13 
>>>>> ==============================================================================
>>>>> 
>>>>> 11:13:16 
>>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>>>> 
>>>>> 11:14:19 
>>>>> Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
>>>>> 
>>>>> 11:14:19 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:19 
>>>>> Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
>>>>> 
>>>>> 11:14:20 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:20 
>>>>> Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
>>>>> 
>>>>> 11:14:40 
>>>>> Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
>>>>> 
>>>>> 11:14:40 
>>>>>  "node": [
>>>>> 
>>>>> 11:14:40 
>>>>>   {
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:connection-status": "connecting",
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:host": "10.30.170.53",
>>>>> 
>>>>> 11:14:40 
>>>>>    "netconf-node-topology:port": 17830,
>>>>> 
>>>>> 11:14:40 
>>>>>    "node-id": "netconf-test-device"
>>>>> 
>>>>> 11:14:40 
>>>>>   }
>>>>> 
>>>>> 11:14:40 
>>>>>  ]
>>>>> 
>>>>> 11:14:40 
>>>>> }
>>>>> 
>>>>> 11:14:40 
>>>>> ' does not contain '"netconf-node-topology:connection-status": "connected"'
>>>>> 
>>>>> 11:14:40 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:40 
>>>>> Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
>>>>> 
>>>>> 11:14:40 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:40 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:40 
>>>>> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>>>>> 
>>>>> 11:14:41 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:41 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:41 
>>>>> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>>>>> 
>>>>> 11:14:41 
>>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>>>> 
>>>>> 11:14:41 
>>>>> ------------------------------------------------------------------------------
>>>>> 
>>>>> 11:14:41 
>>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
>>>>> 
>>>>> 11:14:41 
>>>>> 3 critical tests, 3 passed, 0 failed
>>>>> 
>>>>> 11:14:41 
>>>>> 8 tests total, 3 passed, 5 failed
>>>>> 
>>>>> 11:14:41 ==============================================================================
>>>>> 
>>>>> Regards,
>>>>> Mariusz
>>>>> From: Emmett Cox <emmett.cox@...>
>>>>> Sent: Monday 9 September 2019 10:43
>>>>> To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
>>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>>>> Subject: Re: code review
>>>>>  
>>>>> Hi Luis,
>>>>> Tested to check for your questions:
>>>>> - The new header does work with RFC8040 put
>>>>> - the new header does not work with older restconf implementations
>>>>> Regards,
>>>>> Emmett
>>>>> On 06/09/2019 21:27, Luis Gomez wrote:
>>>>>> Hi, I have couple of questions on this change:
>>>>>> 
>>>>>> https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201
>>>>>> 
>>>>>> - Does the new header works also with RFC8040 PUT?
>>>>>> - Does the new header works with older RESTCONF implementation?
>>>>>> 
>>>>>> BR/Luis
>>>>>> 
>>>>>> 
>>>>>>> On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:
>>>>>>> 
>>>>>>> Thanks Mariusz,
>>>>>>> 
>>>>>>> Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.
>>>>>>> 
>>>>>>> BR/Luis
>>>>>>> 
>>>>>>> 
>>>>>>>> On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>>>>>>> 
>>>>>>>> Hi Luis,
>>>>>>>> Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
>>>>>>>> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Thank you.
>>>>>>>> 
>>>>>>>> Mariusz
>>>> 
>>> 
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> 
>>> View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
>>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> Group Owner: integration-dev+owner@...
>>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13696): https://lists.opendaylight.org/g/integration-dev/message/13696
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13697): https://lists.opendaylight.org/g/integration-dev/message/13697
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


Luis Gomez
 

On Sep 17, 2019, at 10:09 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Thank you for advise. Now Testtool starts ok 🙂.
There are two test cases which fail though(see below).
I am not sure what is the problem since they pass locally. Could you please advise?

Link to JJB:
https://jenkins.opendaylight.org/releng/job/netconf-csit-verify-1node-gate-userfeatures/183/console


Code review:
https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/


10:45:09
------------------------------------------------------------------------------

10:45:09
Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |

10:45:10
[ 200 | 201 | 204 ] does not contain value '404'.

10:45:10
------------------------------------------------------------------------------

10:45:10
Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |

10:45:10
[ 200 | 201 | 204 ] does not contain value '404'.

10:45:10 ------------------------------------------------------------------------------

I am not sure what is difference between your local env and ODL CI but yes the RPC is failing with 404 code even when using latest sodium code (I added job to sandbox):

https://jenkins.opendaylight.org/sandbox/job/netconf-csit-1node-userfeatures-all-sodium/1/


One more question if you don't mind.

This new CRUD-Action test suite has been placed under csit/suites/netconf/CRUD. This is part of netconf-userfeatures.txt testplan. I think this might be a problem. Yang 1.1 actions that is part of this change is only supported since sodium onwards. That is why the Jenkins jobs for this particular tests should only run on sodium and magnesium. However tests under testplan netconf-userfeatures.txt are ran against sodium/neon/fluorine branches. Please correct me if I'm wrong here.

I think we could fix it by creating new testplan and move the CRUD-Action test suite there. Then we could create new project in releng/builder repository under builder/jjb/netconf (next to existing netconf-userfeatures.yaml) which would run only on sodium/magnesium branches.

Please let me know if this makes sense and/or anything is missing here. Or maybe this can be done in a different/better way? Is there any documentation in this matter?
In this case where the difference is in a suite it is recommended to use per-stream test plan, in your case you can use:

- netconf-userfeatures-neon.txt for neon
- netconf-userfeatures.txt by default (sodium onwards)

BR/Luis




Kind regards,
Mariusz

From: Luis Gomez <ecelgp@...>
Sent: Thursday 12 September 2019 17:50
To: Mariusz Sobucki <mariusz.sobucki@...>; Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>
Subject: Re: [integration-dev] code review

Full log here:

https://jenkins.opendaylight.org/releng/view/openflowplugin/job/netvirt-csit-3node-0cmb-1ctl-2cmp-openstack-queens-tempest-stateful-magnesium/25/console

09:45:52
---> Create HEAT stack

09:45:52
+ openstack --os-cloud vex limits show --absolute

09:45:54
No module named v1.contrib

09:45:54
Build step 'Execute shell' marked build as failure




On Sep 12, 2019, at 9:48 AM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

Yes, this seems like a good KW to use. Also the CSIT is currently broken because a python missing dependency in the vexhost script:

09:45:54
No module named v1.contrib

09:45:54
Build step 'Execute shell' marked build as failure


Anil, can you please take a look what is missing here?

BR/Luis


On Sep 12, 2019, at 9:06 AM, mariusz.sobucki@... wrote:

Hi Luis,
Thanks for your help.

There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?

Copy_File_To_Tools_System
[Arguments] ${system} ${source} ${destination}=./
[Documentation] Wrapper keyword to make it easier to copy a file to an Tools specific system
SSHKeywords.Copy_File_To_Remote_System ${system} ${source} ${destination} ${TOOLS_SYSTEM_USER} ${TOOLS_SYSTEM_PASSWORD} ${TOOLS_SYSTEM_PROMPT}
Can I use one of below as a ${system} argument?
${TOOLS_SYSTEM_1_IP} 127.0.0.1 # IP address of first system hosting testing tools.
${TOOLS_SYSTEM_2_IP} 127.0.0.2 # IP address of second system hosting testing tools.
${TOOLS_SYSTEM_3_IP} 127.0.0.3 # IP address of third system hosting testing tools.
I would like to test this, but it seems that all Jenkins jobs fail now with:

16:58:56
Failed!

16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml

Wonder if you're aware of this.


Regards,
Mariusz
From: Luis Gomez <ecelgp@...>
Sent: Wednesday 11 September 2019 21:46
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review

OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):

/usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true

However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.

I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.

Let me know of you have further questions

BR/Luis



On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Thanks for help. I have restored the log redirection as it was before.
Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work.
So it seems like i am not able to add any file.


Regards,
Mariusz
From: Luis Gomez <ecelgp@...>
Sent: Tuesday 10 September 2019 19:30
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review

I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?

BR/Luis



On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.

I think it should work in fluorine as custom rpc is supported in this release.

Please let me know if you have any idea what the problem could be.


Regards,
Mariusz
From: Luis Gomez <ecelgp@...>
Sent: Monday 9 September 2019 20:58
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: integration-dev@... <integration-dev@...>
Subject: Re: [integration-dev] code review

OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.

BR/Luis

On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:

OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.

BR/Luis


On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:

Hi Mariusz,

The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?

If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.

BR/Luis


On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,

While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
18:33:08
Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |

18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
The rpc config file is used when starting testtool in CRUD-ACTION.robot:
Start_Testtool
[Documentation] Deploy and start test tool, then wait for all its devices to become online.
SSHLibrary.File Should Exist ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
NetconfKeywords.Install_And_Start_Testtool device-count=1 schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml

The file is also added as part of this code change:
integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml

I wonder if there is anything wrong with the path we are using or the way we add the file?
I would appreciate any comments regarding this.

Regards,
Mariusz
From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Monday 9 September 2019 14:23
To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review

Hi Luis,
I am trying to debug Start_Testtool failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?

11:13:13
==============================================================================

11:13:13
netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...

11:13:13
==============================================================================

11:13:16
Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |

11:14:19
Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1

11:14:19
------------------------------------------------------------------------------

11:14:19
Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |

11:14:19
------------------------------------------------------------------------------

11:14:19
Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |

11:14:19
------------------------------------------------------------------------------

11:14:19
Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |

11:14:20
------------------------------------------------------------------------------

11:14:20
Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |

11:14:40
Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{

11:14:40
"node": [

11:14:40
{

11:14:40
"netconf-node-topology:connection-status": "connecting",

11:14:40
"netconf-node-topology:host": "10.30.170.53",

11:14:40
"netconf-node-topology:port": 17830,

11:14:40
"node-id": "netconf-test-device"

11:14:40
}

11:14:40
]

11:14:40
}

11:14:40
' does not contain '"netconf-node-topology:connection-status": "connected"'

11:14:40
------------------------------------------------------------------------------

11:14:40
Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |

11:14:40
[ 200 | 201 | 204 ] does not contain value '404'.

11:14:40
------------------------------------------------------------------------------

11:14:40
Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |

11:14:41
[ 200 | 201 | 204 ] does not contain value '404'.

11:14:41
------------------------------------------------------------------------------

11:14:41
Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |

11:14:41
[ 200 | 201 | 204 ] does not contain value '404'.

11:14:41
------------------------------------------------------------------------------

11:14:41
netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |

11:14:41
3 critical tests, 3 passed, 0 failed

11:14:41
8 tests total, 3 passed, 5 failed

11:14:41 ==============================================================================

Regards,
Mariusz
From: Emmett Cox <emmett.cox@...>
Sent: Monday 9 September 2019 10:43
To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
Subject: Re: code review

Hi Luis,
Tested to check for your questions:
- The new header does work with RFC8040 put
- the new header does not work with older restconf implementations
Regards,
Emmett
On 06/09/2019 21:27, Luis Gomez wrote:
Hi, I have couple of questions on this change:

https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201

- Does the new header works also with RFC8040 PUT?
- Does the new header works with older RESTCONF implementation?

BR/Luis


On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:

Thanks Mariusz,

Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.

BR/Luis


On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:

Hi Luis,
Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/


Thank you.

Mariusz
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13696): https://lists.opendaylight.org/g/integration-dev/message/13696
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13697): https://lists.opendaylight.org/g/integration-dev/message/13697
Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub [ecelgp@...]
-=-=-=-=-=-=-=-=-=-=-=-


mariusz.sobucki@est.tech <mariusz.sobucki@...>
 

Hi Luis,
Thank you for help.
I had discussion with Ajay and CRUD-Action test suite should only run against magnesium branch at this moment.

I created new test plan netconf-userfeatures-magnesium.txt to run only tests under CRUD folder.

However when I pushed the changes and builds were triggered I could not find the one with the magnesium test plan i created.

Is there any other change required? Maybe in builder project.


Thank and Regards,
Mariusz


From: Luis Gomez <ecelgp@...>
Sent: Wednesday 18 September 2019 06:21
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 


> On Sep 17, 2019, at 10:09 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>
> Hi Luis,
> Thank you for advise. Now Testtool starts ok 🙂.
> There are two test cases which fail though(see below).
> I am not sure what is the problem since they pass locally. Could you please advise?
>
> Link to JJB:
> https://jenkins.opendaylight.org/releng/job/netconf-csit-verify-1node-gate-userfeatures/183/console
>
>
> Code review:
> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>
>
> 10:45:09
> ------------------------------------------------------------------------------
>
> 10:45:09
> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>
> 10:45:10
> [ 200 | 201 | 204 ] does not contain value '404'.
>
> 10:45:10
> ------------------------------------------------------------------------------
>
> 10:45:10
> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>
> 10:45:10
> [ 200 | 201 | 204 ] does not contain value '404'.
>
> 10:45:10 ------------------------------------------------------------------------------
>
>

I am not sure what is difference between your local env and ODL CI but yes the RPC is failing with 404 code even when using latest sodium code (I added job to sandbox):

https://jenkins.opendaylight.org/sandbox/job/netconf-csit-1node-userfeatures-all-sodium/1/


> One more question if you don't mind.
>
> This new CRUD-Action test suite has been placed under  csit/suites/netconf/CRUD. This is part of netconf-userfeatures.txt testplan. I think this might be a problem. Yang 1.1 actions that is part of this change is only supported since sodium onwards. That is why the Jenkins jobs for this particular tests should only run on sodium and magnesium. However tests under testplan netconf-userfeatures.txt are ran against sodium/neon/fluorine branches. Please correct me if I'm wrong here.
>
> I think we could fix it by creating new testplan and move the CRUD-Action test suite there. Then we could create new project in releng/builder repository under builder/jjb/netconf (next to existing netconf-userfeatures.yaml) which would run only on sodium/magnesium branches.
>
> Please let me know if this makes sense and/or anything is missing here. Or maybe this can be done in a different/better way? Is there any documentation in this matter?

In this case where the difference is in a suite it is recommended to use per-stream test plan, in your case you can use:

- netconf-userfeatures-neon.txt for neon
- netconf-userfeatures.txt by default (sodium onwards)

BR/Luis



>
> Kind regards,
> Mariusz
>
> From: Luis Gomez <ecelgp@...>
> Sent: Thursday 12 September 2019 17:50
> To: Mariusz Sobucki <mariusz.sobucki@...>; Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>
> Subject: Re: [integration-dev] code review

> Full log here:
>
> https://jenkins.opendaylight.org/releng/view/openflowplugin/job/netvirt-csit-3node-0cmb-1ctl-2cmp-openstack-queens-tempest-stateful-magnesium/25/console
>
> 09:45:52
> ---> Create HEAT stack
>
> 09:45:52
> + openstack --os-cloud vex limits show --absolute
>
> 09:45:54
> No module named v1.contrib
>
> 09:45:54
> Build step 'Execute shell' marked build as failure
>
>
>
>
>> On Sep 12, 2019, at 9:48 AM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>
>> Yes, this seems like a good KW to use. Also the CSIT is currently broken because a python missing dependency in the vexhost script:
>>
>> 09:45:54
>> No module named v1.contrib
>>
>> 09:45:54
>> Build step 'Execute shell' marked build as failure
>>
>>
>> Anil, can you please take a look what is missing here?
>>
>> BR/Luis
>>
>>
>>> On Sep 12, 2019, at 9:06 AM, mariusz.sobucki@... wrote:
>>>
>>> Hi Luis,
>>> Thanks for your help.
>>>
>>> There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?
>>>
>>> Copy_File_To_Tools_System
>>>     [Arguments]    ${system}    ${source}    ${destination}=./
>>>     [Documentation]    Wrapper keyword to make it easier to copy a file to an Tools specific system
>>>     SSHKeywords.Copy_File_To_Remote_System    ${system}    ${source}    ${destination}    ${TOOLS_SYSTEM_USER}    ${TOOLS_SYSTEM_PASSWORD}    ${TOOLS_SYSTEM_PROMPT}
>>> Can I use one of below as a ${system} argument?
>>> ${TOOLS_SYSTEM_1_IP}    127.0.0.1    # IP address of first system hosting testing tools.
>>> ${TOOLS_SYSTEM_2_IP}    127.0.0.2    # IP address of second system hosting testing tools.
>>> ${TOOLS_SYSTEM_3_IP}    127.0.0.3    # IP address of third system hosting testing tools.
>>> I would like to test this, but it seems that all Jenkins jobs fail now with:
>>>
>>> 16:58:56
>>> Failed!
>>>
>>> 16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml
>>>
>>> Wonder if you're aware of this.
>>>
>>>
>>> Regards,
>>> Mariusz
>>> From: Luis Gomez <ecelgp@...>
>>> Sent: Wednesday 11 September 2019 21:46
>>> To: Mariusz Sobucki <mariusz.sobucki@...>
>>> Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
>>> Subject: Re: [integration-dev] code review
>>> 
>>> OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):
>>>
>>> /usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar  --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true
>>>
>>> However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.
>>>
>>> I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.
>>>
>>> Let me know of you have further questions
>>>
>>> BR/Luis
>>>
>>>
>>>
>>> > On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >
>>> > Hi Luis,
>>> > Thanks for help. I have restored the log redirection  as it was before.
>>> > Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work.
>>> > So it seems like i am not able to add any file.
>>> >
>>> >
>>> > Regards,
>>> > Mariusz
>>> > From: Luis Gomez <ecelgp@...>
>>> > Sent: Tuesday 10 September 2019 19:30
>>> > To: Mariusz Sobucki <mariusz.sobucki@...>
>>> > Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
>>> > Subject: Re: [integration-dev] code review
>>> > 
>>> > I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?
>>> >
>>> > BR/Luis
>>> >
>>> >
>>> >
>>> >> On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>
>>> >> Hi Luis,
>>> >> The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
>>> >> So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.
>>> >>
>>> >> I think it should work in fluorine as custom rpc is supported in this release.
>>> >>
>>> >> Please let me know if you have any idea what the problem could be.
>>> >>
>>> >>
>>> >> Regards,
>>> >> Mariusz
>>> >> From: Luis Gomez <ecelgp@...>
>>> >> Sent: Monday 9 September 2019 20:58
>>> >> To: Mariusz Sobucki <mariusz.sobucki@...>
>>> >> Cc: integration-dev@... <integration-dev@...>
>>> >> Subject: Re: [integration-dev] code review
>>> >> 
>>> >> OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.
>>> >>
>>> >> BR/Luis
>>> >>
>>> >>> On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>> >>>
>>> >>> OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.
>>> >>>
>>> >>> BR/Luis
>>> >>>
>>> >>>
>>> >>>> On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:
>>> >>>>
>>> >>>> Hi Mariusz,
>>> >>>>
>>> >>>> The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?
>>> >>>>
>>> >>>> If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.
>>> >>>>
>>> >>>> BR/Luis
>>> >>>>
>>> >>>>
>>> >>>>> On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>>>>
>>> >>>>> Hi Luis,
>>> >>>>>
>>> >>>>> While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
>>> >>>>> 18:33:08
>>> >>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>> >>>>>
>>> >>>>> 18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
>>> >>>>> The rpc config file is used when starting testtool in CRUD-ACTION.robot:
>>> >>>>> Start_Testtool
>>> >>>>>     [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
>>> >>>>>     SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>     NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>
>>> >>>>> The file is also added as part of this code change:
>>> >>>>> integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>
>>> >>>>> I wonder if there is anything wrong with the path we are using or the way we add the file?
>>> >>>>> I would appreciate any comments regarding this.
>>> >>>>>
>>> >>>>> Regards,
>>> >>>>> Mariusz
>>> >>>>> From: Mariusz Sobucki <mariusz.sobucki@...>
>>> >>>>> Sent: Monday 9 September 2019 14:23
>>> >>>>> To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
>>> >>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>> >>>>> Subject: Re: code review
>>> >>>>> 
>>> >>>>> Hi Luis,
>>> >>>>> I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> ==============================================================================
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> ==============================================================================
>>> >>>>>
>>> >>>>> 11:13:16
>>> >>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
>>> >>>>>
>>> >>>>> 11:14:20
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:20
>>> >>>>> Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>  "node": [
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>   {
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:connection-status": "connecting",
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:host": "10.30.170.53",
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:port": 17830,
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "node-id": "netconf-test-device"
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>   }
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>  ]
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> }
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ' does not contain '"netconf-node-topology:connection-status": "connected"'
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> 3 critical tests, 3 passed, 0 failed
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> 8 tests total, 3 passed, 5 failed
>>> >>>>>
>>> >>>>> 11:14:41 ==============================================================================
>>> >>>>>
>>> >>>>> Regards,
>>> >>>>> Mariusz
>>> >>>>> From: Emmett Cox <emmett.cox@...>
>>> >>>>> Sent: Monday 9 September 2019 10:43
>>> >>>>> To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
>>> >>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>> >>>>> Subject: Re: code review
>>> >>>>> 
>>> >>>>> Hi Luis,
>>> >>>>> Tested to check for your questions:
>>> >>>>> - The new header does work with RFC8040 put
>>> >>>>> - the new header does not work with older restconf implementations
>>> >>>>> Regards,
>>> >>>>> Emmett
>>> >>>>> On 06/09/2019 21:27, Luis Gomez wrote:
>>> >>>>>> Hi, I have couple of questions on this change:
>>> >>>>>>
>>> >>>>>> https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201
>>> >>>>>>
>>> >>>>>> - Does the new header works also with RFC8040 PUT?
>>> >>>>>> - Does the new header works with older RESTCONF implementation?
>>> >>>>>>
>>> >>>>>> BR/Luis
>>> >>>>>>
>>> >>>>>>
>>> >>>>>>> On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:
>>> >>>>>>>
>>> >>>>>>> Thanks Mariusz,
>>> >>>>>>>
>>> >>>>>>> Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.
>>> >>>>>>>
>>> >>>>>>> BR/Luis
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>>>> On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>>>>>>>
>>> >>>>>>>> Hi Luis,
>>> >>>>>>>> Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
>>> >>>>>>>> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>> Thank you.
>>> >>>>>>>>
>>> >>>>>>>> Mariusz
>>> >>>>
>>> >>>
>>> >>> -=-=-=-=-=-=-=-=-=-=-=-
>>> >>> Links: You receive all messages sent to this group.
>>> >>>
>>> >>> View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
>>> >>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> >>> Group Owner: integration-dev+owner@...
>>> >>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> >>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#13696): https://lists.opendaylight.org/g/integration-dev/message/13696
>>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> Group Owner: integration-dev+owner@...
>>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>>
>> View/Reply Online (#13697): https://lists.opendaylight.org/g/integration-dev/message/13697
>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>> Group Owner: integration-dev+owner@...
>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>> -=-=-=-=-=-=-=-=-=-=-=-


mariusz.sobucki@est.tech <mariusz.sobucki@...>
 

Hi Luis/All,
Could anyone advise me in the below.


My intention is that a system test system test job is triggered for test plan netconf-userfeatures-magnesium.txt.
I have created per-stream test plan netconf-userfeatures-magnesium.txt. I do not see it being triggered when uploading new patch set.

I can only see 
  • netconf-csit-verify-1node-gate-userfeatures 
  • netconf-csit-verify-1node-userfeatures  

being triggered. Both are defined in netconf-userfeatures.yaml in builder.

I wonder if it is required to create corresponding system test job in builder? The job for generic plan netconf-userfeatures.txt already exist in jjb.
I assume it is not required to create job for per stream test plan and the reason is that I don't see any other per-stream jobs for in jbb except the ones auto generated by Jenkins, but maybe I'm wrong.

Also i have noticed that the existing system test job is named netconf-userfeatures.yaml (according to documentation it should be 
netconf-csit-userfeatures.yaml). Is this required or just good practice? 

Also it should ran on below branches:

# Project branches
stream:
- magnesium:
branch: 'master'
- sodium:
branch: 'stable/sodium'
- neon:
branch: 'stable/neon'
- fluorine:
branch: 'stable/fluorine'

Luis mentioned it only runs on fluorine though, so I am a bit confused.
The DISTROBRANCH is set to stable/fluorine in jjb, but then what is the purpose of the above stream settings?
Could you please advise if it is required to create new system test job or anything else? Documentation does not specify if it is required for per-stream test plans.

I would appreciate comments from everyone.


Thanks and regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Wednesday 18 September 2019 18:38
To: Luis Gomez <ecelgp@...>
Cc: Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
Hi Luis,
Thank you for help.
I had discussion with Ajay and CRUD-Action test suite should only run against magnesium branch at this moment.

I created new test plan netconf-userfeatures-magnesium.txt to run only tests under CRUD folder.

However when I pushed the changes and builds were triggered I could not find the one with the magnesium test plan i created.

Is there any other change required? Maybe in builder project.


Thank and Regards,
Mariusz


From: Luis Gomez <ecelgp@...>
Sent: Wednesday 18 September 2019 06:21
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 


> On Sep 17, 2019, at 10:09 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>
> Hi Luis,
> Thank you for advise. Now Testtool starts ok 🙂.
> There are two test cases which fail though(see below).
> I am not sure what is the problem since they pass locally. Could you please advise?
>
> Link to JJB:
> https://jenkins.opendaylight.org/releng/job/netconf-csit-verify-1node-gate-userfeatures/183/console
>
>
> Code review:
> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>
>
> 10:45:09
> ------------------------------------------------------------------------------
>
> 10:45:09
> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>
> 10:45:10
> [ 200 | 201 | 204 ] does not contain value '404'.
>
> 10:45:10
> ------------------------------------------------------------------------------
>
> 10:45:10
> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>
> 10:45:10
> [ 200 | 201 | 204 ] does not contain value '404'.
>
> 10:45:10 ------------------------------------------------------------------------------
>
>

I am not sure what is difference between your local env and ODL CI but yes the RPC is failing with 404 code even when using latest sodium code (I added job to sandbox):

https://jenkins.opendaylight.org/sandbox/job/netconf-csit-1node-userfeatures-all-sodium/1/


> One more question if you don't mind.
>
> This new CRUD-Action test suite has been placed under  csit/suites/netconf/CRUD. This is part of netconf-userfeatures.txt testplan. I think this might be a problem. Yang 1.1 actions that is part of this change is only supported since sodium onwards. That is why the Jenkins jobs for this particular tests should only run on sodium and magnesium. However tests under testplan netconf-userfeatures.txt are ran against sodium/neon/fluorine branches. Please correct me if I'm wrong here.
>
> I think we could fix it by creating new testplan and move the CRUD-Action test suite there. Then we could create new project in releng/builder repository under builder/jjb/netconf (next to existing netconf-userfeatures.yaml) which would run only on sodium/magnesium branches.
>
> Please let me know if this makes sense and/or anything is missing here. Or maybe this can be done in a different/better way? Is there any documentation in this matter?

In this case where the difference is in a suite it is recommended to use per-stream test plan, in your case you can use:

- netconf-userfeatures-neon.txt for neon
- netconf-userfeatures.txt by default (sodium onwards)

BR/Luis



>
> Kind regards,
> Mariusz
>
> From: Luis Gomez <ecelgp@...>
> Sent: Thursday 12 September 2019 17:50
> To: Mariusz Sobucki <mariusz.sobucki@...>; Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>
> Subject: Re: [integration-dev] code review

> Full log here:
>
> https://jenkins.opendaylight.org/releng/view/openflowplugin/job/netvirt-csit-3node-0cmb-1ctl-2cmp-openstack-queens-tempest-stateful-magnesium/25/console
>
> 09:45:52
> ---> Create HEAT stack
>
> 09:45:52
> + openstack --os-cloud vex limits show --absolute
>
> 09:45:54
> No module named v1.contrib
>
> 09:45:54
> Build step 'Execute shell' marked build as failure
>
>
>
>
>> On Sep 12, 2019, at 9:48 AM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>
>> Yes, this seems like a good KW to use. Also the CSIT is currently broken because a python missing dependency in the vexhost script:
>>
>> 09:45:54
>> No module named v1.contrib
>>
>> 09:45:54
>> Build step 'Execute shell' marked build as failure
>>
>>
>> Anil, can you please take a look what is missing here?
>>
>> BR/Luis
>>
>>
>>> On Sep 12, 2019, at 9:06 AM, mariusz.sobucki@... wrote:
>>>
>>> Hi Luis,
>>> Thanks for your help.
>>>
>>> There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?
>>>
>>> Copy_File_To_Tools_System
>>>     [Arguments]    ${system}    ${source}    ${destination}=./
>>>     [Documentation]    Wrapper keyword to make it easier to copy a file to an Tools specific system
>>>     SSHKeywords.Copy_File_To_Remote_System    ${system}    ${source}    ${destination}    ${TOOLS_SYSTEM_USER}    ${TOOLS_SYSTEM_PASSWORD}    ${TOOLS_SYSTEM_PROMPT}
>>> Can I use one of below as a ${system} argument?
>>> ${TOOLS_SYSTEM_1_IP}    127.0.0.1    # IP address of first system hosting testing tools.
>>> ${TOOLS_SYSTEM_2_IP}    127.0.0.2    # IP address of second system hosting testing tools.
>>> ${TOOLS_SYSTEM_3_IP}    127.0.0.3    # IP address of third system hosting testing tools.
>>> I would like to test this, but it seems that all Jenkins jobs fail now with:
>>>
>>> 16:58:56
>>> Failed!
>>>
>>> 16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml
>>>
>>> Wonder if you're aware of this.
>>>
>>>
>>> Regards,
>>> Mariusz
>>> From: Luis Gomez <ecelgp@...>
>>> Sent: Wednesday 11 September 2019 21:46
>>> To: Mariusz Sobucki <mariusz.sobucki@...>
>>> Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
>>> Subject: Re: [integration-dev] code review
>>> 
>>> OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):
>>>
>>> /usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar  --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true
>>>
>>> However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.
>>>
>>> I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.
>>>
>>> Let me know of you have further questions
>>>
>>> BR/Luis
>>>
>>>
>>>
>>> > On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >
>>> > Hi Luis,
>>> > Thanks for help. I have restored the log redirection  as it was before.
>>> > Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work.
>>> > So it seems like i am not able to add any file.
>>> >
>>> >
>>> > Regards,
>>> > Mariusz
>>> > From: Luis Gomez <ecelgp@...>
>>> > Sent: Tuesday 10 September 2019 19:30
>>> > To: Mariusz Sobucki <mariusz.sobucki@...>
>>> > Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
>>> > Subject: Re: [integration-dev] code review
>>> > 
>>> > I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?
>>> >
>>> > BR/Luis
>>> >
>>> >
>>> >
>>> >> On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>
>>> >> Hi Luis,
>>> >> The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
>>> >> So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.
>>> >>
>>> >> I think it should work in fluorine as custom rpc is supported in this release.
>>> >>
>>> >> Please let me know if you have any idea what the problem could be.
>>> >>
>>> >>
>>> >> Regards,
>>> >> Mariusz
>>> >> From: Luis Gomez <ecelgp@...>
>>> >> Sent: Monday 9 September 2019 20:58
>>> >> To: Mariusz Sobucki <mariusz.sobucki@...>
>>> >> Cc: integration-dev@... <integration-dev@...>
>>> >> Subject: Re: [integration-dev] code review
>>> >> 
>>> >> OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.
>>> >>
>>> >> BR/Luis
>>> >>
>>> >>> On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>> >>>
>>> >>> OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.
>>> >>>
>>> >>> BR/Luis
>>> >>>
>>> >>>
>>> >>>> On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:
>>> >>>>
>>> >>>> Hi Mariusz,
>>> >>>>
>>> >>>> The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?
>>> >>>>
>>> >>>> If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.
>>> >>>>
>>> >>>> BR/Luis
>>> >>>>
>>> >>>>
>>> >>>>> On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>>>>
>>> >>>>> Hi Luis,
>>> >>>>>
>>> >>>>> While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
>>> >>>>> 18:33:08
>>> >>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>> >>>>>
>>> >>>>> 18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
>>> >>>>> The rpc config file is used when starting testtool in CRUD-ACTION.robot:
>>> >>>>> Start_Testtool
>>> >>>>>     [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
>>> >>>>>     SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>     NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>
>>> >>>>> The file is also added as part of this code change:
>>> >>>>> integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>
>>> >>>>> I wonder if there is anything wrong with the path we are using or the way we add the file?
>>> >>>>> I would appreciate any comments regarding this.
>>> >>>>>
>>> >>>>> Regards,
>>> >>>>> Mariusz
>>> >>>>> From: Mariusz Sobucki <mariusz.sobucki@...>
>>> >>>>> Sent: Monday 9 September 2019 14:23
>>> >>>>> To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
>>> >>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>> >>>>> Subject: Re: code review
>>> >>>>> 
>>> >>>>> Hi Luis,
>>> >>>>> I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> ==============================================================================
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> ==============================================================================
>>> >>>>>
>>> >>>>> 11:13:16
>>> >>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
>>> >>>>>
>>> >>>>> 11:14:20
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:20
>>> >>>>> Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>  "node": [
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>   {
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:connection-status": "connecting",
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:host": "10.30.170.53",
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:port": 17830,
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "node-id": "netconf-test-device"
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>   }
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>  ]
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> }
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ' does not contain '"netconf-node-topology:connection-status": "connected"'
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> 3 critical tests, 3 passed, 0 failed
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> 8 tests total, 3 passed, 5 failed
>>> >>>>>
>>> >>>>> 11:14:41 ==============================================================================
>>> >>>>>
>>> >>>>> Regards,
>>> >>>>> Mariusz
>>> >>>>> From: Emmett Cox <emmett.cox@...>
>>> >>>>> Sent: Monday 9 September 2019 10:43
>>> >>>>> To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
>>> >>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>> >>>>> Subject: Re: code review
>>> >>>>> 
>>> >>>>> Hi Luis,
>>> >>>>> Tested to check for your questions:
>>> >>>>> - The new header does work with RFC8040 put
>>> >>>>> - the new header does not work with older restconf implementations
>>> >>>>> Regards,
>>> >>>>> Emmett
>>> >>>>> On 06/09/2019 21:27, Luis Gomez wrote:
>>> >>>>>> Hi, I have couple of questions on this change:
>>> >>>>>>
>>> >>>>>> https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201
>>> >>>>>>
>>> >>>>>> - Does the new header works also with RFC8040 PUT?
>>> >>>>>> - Does the new header works with older RESTCONF implementation?
>>> >>>>>>
>>> >>>>>> BR/Luis
>>> >>>>>>
>>> >>>>>>
>>> >>>>>>> On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:
>>> >>>>>>>
>>> >>>>>>> Thanks Mariusz,
>>> >>>>>>>
>>> >>>>>>> Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.
>>> >>>>>>>
>>> >>>>>>> BR/Luis
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>>>> On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>>>>>>>
>>> >>>>>>>> Hi Luis,
>>> >>>>>>>> Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
>>> >>>>>>>> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>> Thank you.
>>> >>>>>>>>
>>> >>>>>>>> Mariusz
>>> >>>>
>>> >>>
>>> >>> -=-=-=-=-=-=-=-=-=-=-=-
>>> >>> Links: You receive all messages sent to this group.
>>> >>>
>>> >>> View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
>>> >>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> >>> Group Owner: integration-dev+owner@...
>>> >>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> >>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#13696): https://lists.opendaylight.org/g/integration-dev/message/13696
>>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> Group Owner: integration-dev+owner@...
>>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>>
>> View/Reply Online (#13697): https://lists.opendaylight.org/g/integration-dev/message/13697
>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>> Group Owner: integration-dev+owner@...
>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>> -=-=-=-=-=-=-=-=-=-=-=-


mariusz.sobucki@est.tech <mariusz.sobucki@...>
 

Hi Luis/Guys,
I wander why Jenkins job is ran against fluorine when I upload the patch set? Is this correct? Shouldn't it pick master branch?
The second question is what do I need to do to test my changes against master branch which is magnesium now. 
The reason I am asking all these questions is that my CSIT will only pass in latest code which is master.


I would appreciate your comments.


Thanks and Regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Thursday 19 September 2019 15:13
To: Luis Gomez <ecelgp@...>
Cc: Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
Hi Luis/All,
Could anyone advise me in the below.


My intention is that a system test system test job is triggered for test plan netconf-userfeatures-magnesium.txt.
I have created per-stream test plan netconf-userfeatures-magnesium.txt. I do not see it being triggered when uploading new patch set.

I can only see 
  • netconf-csit-verify-1node-gate-userfeatures 
  • netconf-csit-verify-1node-userfeatures  

being triggered. Both are defined in netconf-userfeatures.yaml in builder.

I wonder if it is required to create corresponding system test job in builder? The job for generic plan netconf-userfeatures.txt already exist in jjb.
I assume it is not required to create job for per stream test plan and the reason is that I don't see any other per-stream jobs for in jbb except the ones auto generated by Jenkins, but maybe I'm wrong.

Also i have noticed that the existing system test job is named netconf-userfeatures.yaml (according to documentation it should be 
netconf-csit-userfeatures.yaml). Is this required or just good practice? 

Also it should ran on below branches:

# Project branches
stream:
- magnesium:
branch: 'master'
- sodium:
branch: 'stable/sodium'
- neon:
branch: 'stable/neon'
- fluorine:
branch: 'stable/fluorine'

Luis mentioned it only runs on fluorine though, so I am a bit confused.
The DISTROBRANCH is set to stable/fluorine in jjb, but then what is the purpose of the above stream settings?
Could you please advise if it is required to create new system test job or anything else? Documentation does not specify if it is required for per-stream test plans.

I would appreciate comments from everyone.


Thanks and regards,
Mariusz

From: Mariusz Sobucki <mariusz.sobucki@...>
Sent: Wednesday 18 September 2019 18:38
To: Luis Gomez <ecelgp@...>
Cc: Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 
Hi Luis,
Thank you for help.
I had discussion with Ajay and CRUD-Action test suite should only run against magnesium branch at this moment.

I created new test plan netconf-userfeatures-magnesium.txt to run only tests under CRUD folder.

However when I pushed the changes and builds were triggered I could not find the one with the magnesium test plan i created.

Is there any other change required? Maybe in builder project.


Thank and Regards,
Mariusz


From: Luis Gomez <ecelgp@...>
Sent: Wednesday 18 September 2019 06:21
To: Mariusz Sobucki <mariusz.sobucki@...>
Cc: Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
Subject: Re: [integration-dev] code review
 


> On Sep 17, 2019, at 10:09 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>
> Hi Luis,
> Thank you for advise. Now Testtool starts ok 🙂.
> There are two test cases which fail though(see below).
> I am not sure what is the problem since they pass locally. Could you please advise?
>
> Link to JJB:
> https://jenkins.opendaylight.org/releng/job/netconf-csit-verify-1node-gate-userfeatures/183/console
>
>
> Code review:
> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>
>
> 10:45:09
> ------------------------------------------------------------------------------
>
> 10:45:09
> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>
> 10:45:10
> [ 200 | 201 | 204 ] does not contain value '404'.
>
> 10:45:10
> ------------------------------------------------------------------------------
>
> 10:45:10
> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>
> 10:45:10
> [ 200 | 201 | 204 ] does not contain value '404'.
>
> 10:45:10 ------------------------------------------------------------------------------
>
>

I am not sure what is difference between your local env and ODL CI but yes the RPC is failing with 404 code even when using latest sodium code (I added job to sandbox):

https://jenkins.opendaylight.org/sandbox/job/netconf-csit-1node-userfeatures-all-sodium/1/


> One more question if you don't mind.
>
> This new CRUD-Action test suite has been placed under  csit/suites/netconf/CRUD. This is part of netconf-userfeatures.txt testplan. I think this might be a problem. Yang 1.1 actions that is part of this change is only supported since sodium onwards. That is why the Jenkins jobs for this particular tests should only run on sodium and magnesium. However tests under testplan netconf-userfeatures.txt are ran against sodium/neon/fluorine branches. Please correct me if I'm wrong here.
>
> I think we could fix it by creating new testplan and move the CRUD-Action test suite there. Then we could create new project in releng/builder repository under builder/jjb/netconf (next to existing netconf-userfeatures.yaml) which would run only on sodium/magnesium branches.
>
> Please let me know if this makes sense and/or anything is missing here. Or maybe this can be done in a different/better way? Is there any documentation in this matter?

In this case where the difference is in a suite it is recommended to use per-stream test plan, in your case you can use:

- netconf-userfeatures-neon.txt for neon
- netconf-userfeatures.txt by default (sodium onwards)

BR/Luis



>
> Kind regards,
> Mariusz
>
> From: Luis Gomez <ecelgp@...>
> Sent: Thursday 12 September 2019 17:50
> To: Mariusz Sobucki <mariusz.sobucki@...>; Anil Belur <abelur@...>; integration-dev@... <integration-dev@...>
> Subject: Re: [integration-dev] code review

> Full log here:
>
> https://jenkins.opendaylight.org/releng/view/openflowplugin/job/netvirt-csit-3node-0cmb-1ctl-2cmp-openstack-queens-tempest-stateful-magnesium/25/console
>
> 09:45:52
> ---> Create HEAT stack
>
> 09:45:52
> + openstack --os-cloud vex limits show --absolute
>
> 09:45:54
> No module named v1.contrib
>
> 09:45:54
> Build step 'Execute shell' marked build as failure
>
>
>
>
>> On Sep 12, 2019, at 9:48 AM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>
>> Yes, this seems like a good KW to use. Also the CSIT is currently broken because a python missing dependency in the vexhost script:
>>
>> 09:45:54
>> No module named v1.contrib
>>
>> 09:45:54
>> Build step 'Execute shell' marked build as failure
>>
>>
>> Anil, can you please take a look what is missing here?
>>
>> BR/Luis
>>
>>
>>> On Sep 12, 2019, at 9:06 AM, mariusz.sobucki@... wrote:
>>>
>>> Hi Luis,
>>> Thanks for your help.
>>>
>>> There is a Copy_File_To_Tools_System keyword (in SSHKeywords.robot) that should come handy, what you think?
>>>
>>> Copy_File_To_Tools_System
>>>     [Arguments]    ${system}    ${source}    ${destination}=./
>>>     [Documentation]    Wrapper keyword to make it easier to copy a file to an Tools specific system
>>>     SSHKeywords.Copy_File_To_Remote_System    ${system}    ${source}    ${destination}    ${TOOLS_SYSTEM_USER}    ${TOOLS_SYSTEM_PASSWORD}    ${TOOLS_SYSTEM_PROMPT}
>>> Can I use one of below as a ${system} argument?
>>> ${TOOLS_SYSTEM_1_IP}    127.0.0.1    # IP address of first system hosting testing tools.
>>> ${TOOLS_SYSTEM_2_IP}    127.0.0.2    # IP address of second system hosting testing tools.
>>> ${TOOLS_SYSTEM_3_IP}    127.0.0.3    # IP address of third system hosting testing tools.
>>> I would like to test this, but it seems that all Jenkins jobs fail now with:
>>>
>>> 16:58:56
>>> Failed!
>>>
>>> 16:58:56 hudson.AbortException: No files found in path /w/workspace/netconf-csit-verify-1node-userfeatures with configured filemask: output.xml
>>>
>>> Wonder if you're aware of this.
>>>
>>>
>>> Regards,
>>> Mariusz
>>> From: Luis Gomez <ecelgp@...>
>>> Sent: Wednesday 11 September 2019 21:46
>>> To: Mariusz Sobucki <mariusz.sobucki@...>
>>> Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
>>> Subject: Re: [integration-dev] code review
>>> 
>>> OK, lets go step by step, here: your patch runs this command in the mininet VM (where the testtool is deployed):
>>>
>>> /usr/lib/jvm/java-8-openjdk-amd64/bin/java -Xmx1G -XX:MaxPermSize=256M -jar netconf-testtool-1.5.4-20190911.023609-85-executable.jar  --device-count 1 --debug true --schemas-dir ./schemas --rpc-config /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml --md-sal true
>>>
>>> However the path you provide as argument: /w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/datamod2/customaction.xml is not in the same VM but in the robot VM executing the test.
>>>
>>> I think you test has to first move the desired xml file to the mininet VM (e.g. SSLibrary.Put) and then execute the above command on the path you move the file.
>>>
>>> Let me know of you have further questions
>>>
>>> BR/Luis
>>>
>>>
>>>
>>> > On Sep 11, 2019, at 10:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >
>>> > Hi Luis,
>>> > Thanks for help. I have restored the log redirection  as it was before.
>>> > Just to let you know, I tried to start testtool with custom rpc placed in the existing datamod2 (Patch Set 13) folder used in CRUD_RPC and it also did not work.
>>> > So it seems like i am not able to add any file.
>>> >
>>> >
>>> > Regards,
>>> > Mariusz
>>> > From: Luis Gomez <ecelgp@...>
>>> > Sent: Tuesday 10 September 2019 19:30
>>> > To: Mariusz Sobucki <mariusz.sobucki@...>
>>> > Cc: integration-dev@... <integration-dev@...>; Emmett Cox <emmett.cox@...>; Paul Dennehy P <paul.p.dennehy@...>; Ajay Deep Singh <ajay.deep.singh@...>
>>> > Subject: Re: [integration-dev] code review
>>> > 
>>> > I just looked at the last build of the verify job and the issue seems to be the netconf testtool, unfortunately I cannot see the test tool log in the log server because you changed the line creating it (see my comment in the patch). Can you please restore the log so we can see what is going on?
>>> >
>>> > BR/Luis
>>> >
>>> >
>>> >
>>> >> On Sep 10, 2019, at 8:46 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>
>>> >> Hi Luis,
>>> >> The problem is that I am trying to pass the custom rpc file to Testtool using --rpc-config parameter and there is an error that this file is missing. I am not sure why.
>>> >> So I used various ways to confirm if the file is present or not. Each time it says no file. Strange thing that it works fine in my environment.
>>> >>
>>> >> I think it should work in fluorine as custom rpc is supported in this release.
>>> >>
>>> >> Please let me know if you have any idea what the problem could be.
>>> >>
>>> >>
>>> >> Regards,
>>> >> Mariusz
>>> >> From: Luis Gomez <ecelgp@...>
>>> >> Sent: Monday 9 September 2019 20:58
>>> >> To: Mariusz Sobucki <mariusz.sobucki@...>
>>> >> Cc: integration-dev@... <integration-dev@...>
>>> >> Subject: Re: [integration-dev] code review
>>> >> 
>>> >> OK, I think I know what is going on: 'SSHLibrary.File Should Exist' searches the file in the remote system = mininet VM, I think you should use 'OperativeSystem.File Should Exist'.
>>> >>
>>> >> BR/Luis
>>> >>
>>> >>> On Sep 9, 2019, at 12:20 PM, Luis Gomez via Lists.Opendaylight.Org <ecelgp=gmail.com@...> wrote:
>>> >>>
>>> >>> OK, the issue you describe is actually very weird: it seems like your suite checks for a file that exists in the patch but it fails to find, so I cannot tell right away what is wrong here. I will download your patch and try in my robot setup later today.
>>> >>>
>>> >>> BR/Luis
>>> >>>
>>> >>>
>>> >>>> On Sep 9, 2019, at 11:29 AM, Luis Gomez <ecelgp@...> wrote:
>>> >>>>
>>> >>>> Hi Mariusz,
>>> >>>>
>>> >>>> The CSIT verify job currently pulls Fluorine distribution (it should be neon), does the new test suppose to work in this release?
>>> >>>>
>>> >>>> If not you can neglect the test or try to test the same in the sandbox where you can specify the distribution branch. Let me know if you have further questions.
>>> >>>>
>>> >>>> BR/Luis
>>> >>>>
>>> >>>>
>>> >>>>> On Sep 9, 2019, at 11:15 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>>>>
>>> >>>>> Hi Luis,
>>> >>>>>
>>> >>>>> While starting the testtool there is below error, so we know that the file is not found. This works fine on my local environment.
>>> >>>>> 18:33:08
>>> >>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>> >>>>>
>>> >>>>> 18:33:08 File '/w/workspace/netconf-csit-verify-1node-gate-userfeatures/test/csit/suites/netconf/CRUD/../../../variables/netconf/CRUD/customaction/customaction.xml' does not exist.
>>> >>>>> The rpc config file is used when starting testtool in CRUD-ACTION.robot:
>>> >>>>> Start_Testtool
>>> >>>>>     [Documentation]    Deploy and start test tool, then wait for all its devices to become online.
>>> >>>>>     SSHLibrary.File Should Exist    ${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>     NetconfKeywords.Install_And_Start_Testtool    device-count=1    schemas=${CURDIR}/../../../variables/netconf/CRUD/schemas    rpc_config=${CURDIR}/../../../variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>
>>> >>>>> The file is also added as part of this code change:
>>> >>>>> integration/test / csit/variables/netconf/CRUD/customaction/customaction.xml
>>> >>>>>
>>> >>>>> I wonder if there is anything wrong with the path we are using or the way we add the file?
>>> >>>>> I would appreciate any comments regarding this.
>>> >>>>>
>>> >>>>> Regards,
>>> >>>>> Mariusz
>>> >>>>> From: Mariusz Sobucki <mariusz.sobucki@...>
>>> >>>>> Sent: Monday 9 September 2019 14:23
>>> >>>>> To: Emmett Cox <emmett.cox@...>; Luis Gomez <ecelgp@...>
>>> >>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>> >>>>> Subject: Re: code review
>>> >>>>> 
>>> >>>>> Hi Luis,
>>> >>>>> I am trying to debug Start_Testtool   failing below. There is not much info available in the log. Would you know how to get some more information regarding why it is failing? Is there any other log or maybe we can switch more debug info somehow?
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> ==============================================================================
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connector CRUD-Ac...
>>> >>>>>
>>> >>>>> 11:13:13
>>> >>>>> ==============================================================================
>>> >>>>>
>>> >>>>> 11:13:16
>>> >>>>> Start_Testtool :: Deploy and start test tool, then wait for all it... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Keyword 'Check_Device_Up_And_Running' failed after retrying for 1 minute. The last error was: 0 != 1
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Check_Device_Is_Not_Configured_At_Beginning :: Sanity check making... | PASS |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Configure_Device_On_Netconf :: Make request to configure a testtoo... | PASS |
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:19
>>> >>>>> Check_ODL_Has_Netconf_Connector_For_Device :: Get the list of conf... | PASS |
>>> >>>>>
>>> >>>>> 11:14:20
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:20
>>> >>>>> Wait_For_Device_To_Become_Connected :: Wait until the device becom... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Keyword 'Check_Device_Connected' failed after retrying for 20 seconds. The last error was: '{
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>  "node": [
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>   {
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:connection-status": "connecting",
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:host": "10.30.170.53",
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "netconf-node-topology:port": 17830,
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>    "node-id": "netconf-test-device"
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>   }
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>>  ]
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> }
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ' does not contain '"netconf-node-topology:connection-status": "connected"'
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Check_Device_Data_Is_Empty :: Get the device data and make sure it... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:40
>>> >>>>> Invoke_Yang1.1_Action_Via_Xml_Post :: Send a sample test data labe... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> Invoke_Yang1.1_Action_Via_Json_Post :: Send a sample test data lab... | FAIL |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> [ 200 | 201 | 204 ] does not contain value '404'.
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> ------------------------------------------------------------------------------
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> netconf-gate-userfeatures.txt.CRUD.CRUD-ACTION :: netconf-connecto... | PASS |
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> 3 critical tests, 3 passed, 0 failed
>>> >>>>>
>>> >>>>> 11:14:41
>>> >>>>> 8 tests total, 3 passed, 5 failed
>>> >>>>>
>>> >>>>> 11:14:41 ==============================================================================
>>> >>>>>
>>> >>>>> Regards,
>>> >>>>> Mariusz
>>> >>>>> From: Emmett Cox <emmett.cox@...>
>>> >>>>> Sent: Monday 9 September 2019 10:43
>>> >>>>> To: Luis Gomez <ecelgp@...>; Mariusz Sobucki <mariusz.sobucki@...>
>>> >>>>> Cc: Ajay Deep Singh <ajay.deep.singh@...>; integration-dev@... <integration-dev@...>; Paul Dennehy P <paul.p.dennehy@...>
>>> >>>>> Subject: Re: code review
>>> >>>>> 
>>> >>>>> Hi Luis,
>>> >>>>> Tested to check for your questions:
>>> >>>>> - The new header does work with RFC8040 put
>>> >>>>> - the new header does not work with older restconf implementations
>>> >>>>> Regards,
>>> >>>>> Emmett
>>> >>>>> On 06/09/2019 21:27, Luis Gomez wrote:
>>> >>>>>> Hi, I have couple of questions on this change:
>>> >>>>>>
>>> >>>>>> https://git.opendaylight.org/gerrit/c/integration/test/+/84258/2/csit/libraries/TemplatedRequests.robot#201
>>> >>>>>>
>>> >>>>>> - Does the new header works also with RFC8040 PUT?
>>> >>>>>> - Does the new header works with older RESTCONF implementation?
>>> >>>>>>
>>> >>>>>> BR/Luis
>>> >>>>>>
>>> >>>>>>
>>> >>>>>>> On Sep 6, 2019, at 9:50 AM, Luis Gomez <ecelgp@...> wrote:
>>> >>>>>>>
>>> >>>>>>> Thanks Mariusz,
>>> >>>>>>>
>>> >>>>>>> Going forward please copy the integration mail list (integration-dev@...) in the ODL communications related to test.
>>> >>>>>>>
>>> >>>>>>> BR/Luis
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>>>> On Sep 6, 2019, at 9:47 AM, Mariusz Sobucki <mariusz.sobucki@...> wrote:
>>> >>>>>>>>
>>> >>>>>>>> Hi Luis,
>>> >>>>>>>> Could you please review the change in CSIT made to cater for actions in YANG1.1 model.
>>> >>>>>>>> https://git.opendaylight.org/gerrit/#/c/integration/test/+/84258/
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>> Thank you.
>>> >>>>>>>>
>>> >>>>>>>> Mariusz
>>> >>>>
>>> >>>
>>> >>> -=-=-=-=-=-=-=-=-=-=-=-
>>> >>> Links: You receive all messages sent to this group.
>>> >>>
>>> >>> View/Reply Online (#13680): https://lists.opendaylight.org/g/integration-dev/message/13680
>>> >>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> >>> Group Owner: integration-dev+owner@...
>>> >>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> >>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#13696): https://lists.opendaylight.org/g/integration-dev/message/13696
>>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>>> Group Owner: integration-dev+owner@...
>>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>>
>> View/Reply Online (#13697): https://lists.opendaylight.org/g/integration-dev/message/13697
>> Mute This Topic: https://lists.opendaylight.org/mt/33279377/1217165
>> Group Owner: integration-dev+owner@...
>> Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [ecelgp@...]
>> -=-=-=-=-=-=-=-=-=-=-=-