One robot case finished, please help to review it, and provide your comment or feedback.


denghui huang
 

Hi guys.

    Back then, i implement a robot TA case based on CSIT_Test tool, and in last meeting with baohua, Luis, and Carol, i got some good feedbacks on how to make TA cases more readable. In last a couple of days,baohua and i had a discussion about how to implement TA cases in more robot way for OpenDaylight system test plan, and after discussed, i reimplemented one test cases, please review it from https://github.com/yeasy/robot_tool, and please give your comments on the following thing:
1. Does code organization look like good?
2. Does that test case look like good?

For myself, i think there is one thing need to improve that, we need put Create Session to ODL controller in Test suite setup, and in test suite Teardown, we need clear all open session. it is in my TODO list.


Luis Gomez <luis.gomez@...>
 

Hi Denghui,

 

I downloaded your code and run it in the Lab. It works very good and has very clear understanding.  So I say +1 on both 1&2 questions.

 

From: integration-dev-bounces@... [mailto:integration-dev-bounces@...] On Behalf Of huang denghui
Sent: Wednesday, November 13, 2013 8:07 AM
To: integration-dev@...
Subject: [integration-dev] One robot case finished, please help to review it, and provide your comment or feedback.

 

Hi guys.

    Back then, i implement a robot TA case based on CSIT_Test tool, and in last meeting with baohua, Luis, and Carol, i got some good feedbacks on how to make TA cases more readable. In last a couple of days,baohua and i had a discussion about how to implement TA cases in more robot way for OpenDaylight system test plan, and after discussed, i reimplemented one test cases, please review it from https://github.com/yeasy/robot_tool, and please give your comments on the following thing:

1. Does code organization look like good?

2. Does that test case look like good?

For myself, i think there is one thing need to improve that, we need put Create Session to ODL controller in Test suite setup, and in test suite Teardown, we need clear all open session. it is in my TODO list.