Date
1 - 2 of 2
Patches proposed by jenkins
Robert Varga
Hey everyone,
there is a number of patches in Gerrit proposed by production jenkins: https://git.opendaylight.org/gerrit/q/owner:jenkins-releng%2540opendaylight.org and by sandbox jenkins: https://git.opendaylight.org/gerrit/q/owner:jenkins-sandbox%2540opendaylight.org The problem with the first one is that they do not really point to their source job -- yes, they are tagged with a topic, but it would be nice if there was a record of which job (including number, i.e. ${BUILD_TAG} or ${BUILD_URL}) produced the last revision -- either in the commit message, or better as a separate comment. Can we make that happen? For the sandbox ... I am surprised it is even able do push patches to gerrit. Do we really want that capability? Even if we do, those patches should be automatically abandoned when sandbox is reset -- otherwise we'll end up with random mess being dropped onto projects and never cleaned up. Regards, Robert |
|
JamO Luhrsen
On 12/12/19 6:48 AM, Robert Varga
wrote:
Hey everyone, there is a number of patches in Gerrit proposed by production jenkins: https://git.opendaylight.org/gerrit/q/owner:jenkins-releng%2540opendaylight.org and by sandbox jenkins: https://git.opendaylight.org/gerrit/q/owner:jenkins-sandbox%2540opendaylight.org The problem with the first one is that they do not really point to their source job -- yes, they are tagged with a topic, but it would be nice if there was a record of which job (including number, i.e. ${BUILD_TAG} or ${BUILD_URL}) produced the last revision -- either in the commit message, or better as a separate comment. Can we make that happen? this would be a nice addition. Could it be this simple? https://gerrit.linuxfoundation.org/infra/c/releng/global-jjb/+/62615 I don't know how to test it though. I'm not really a contributor or active in the global-jjb project. Anyone know? For the sandbox ... I am surprised it is even able do push patches to gerrit. Do we really want that capability? I think it's probably needed so folks can test things and make sure the auto created patches look right. Like I'd like to do (see above) :) Even if we do, those patches should be automatically abandoned when sandbox is reset -- otherwise we'll end up with random mess being dropped onto projects and never cleaned up. Agreed, but I don't know how to do that. JamO Regards, Robert |
|