See robot tidy ERRORs


Luis Gomez
 

Hi int devs,

I remember some time back the tox job showed robot-tidy syntax errors in the jenkins console, but now I do not see these errors anymore:


If you see above, the build fails in the robot-tidy, but no indication what is wrong (at least I could not find).

Am I missing something here?

BR/Luis




JamO Luhrsen
 

I remember it the same way as you, Luis. I don't see the
output any more. Clearly your patch has an extra space, but
for more complicated patches it would be nice to see it in
the console.

Oh, I think before we had a script to run robot.tidy that
Vratko gave us, but now we are getting it automatically from
pre-commit. That's probably the difference.

Maybe it's possible to get pre-commit to give us that output?

JamO

On 9/9/19 11:34 AM, Luis Gomez wrote:

Hi int devs,

I remember some time back the tox job showed robot-tidy syntax errors in the jenkins console, but now I do not see these errors anymore:


If you see above, the build fails in the robot-tidy, but no indication what is wrong (at least I could not find).

Am I missing something here?

BR/Luis




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13679): https://lists.opendaylight.org/g/integration-dev/message/13679
Mute This Topic: https://lists.opendaylight.org/mt/34083459/535209
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [jluhrsen@...]
-=-=-=-=-=-=-=-=-=-=-=-


Thanh ha <zxiiro@...>
 

Yes, the pre-commit changed this behaviour. The difference is that pre-commit fixes the issues for you when it's run so if you are running pre-commit locally you'll just have modified files locally. I recommend installing pre-commit locally and running `pre-commit install` this will install the pre-commit checks and automatically runs them every time you type `git commit` so that linting is automatic.

In CI you can't see the changes since we are not doing a "git status && git diff" after pre-commit runs. Maybe it's worth updating the job to automatically run those to show what pre-commit is catching so that there's no confusion. We could either modify the job or the tox.ini I'm not sure where the best place to put it is (I can experiment and report back later).

Regards,
Thanh


On Mon, 9 Sep 2019 at 17:40, JamO Luhrsen <jluhrsen@...> wrote:
I remember it the same way as you, Luis. I don't see the
output any more. Clearly your patch has an extra space, but
for more complicated patches it would be nice to see it in
the console.

Oh, I think before we had a script to run robot.tidy that
Vratko gave us, but now we are getting it automatically from
pre-commit. That's probably the difference.

Maybe it's possible to get pre-commit to give us that output?

JamO

On 9/9/19 11:34 AM, Luis Gomez wrote:
Hi int devs,

I remember some time back the tox job showed robot-tidy syntax errors in the jenkins console, but now I do not see these errors anymore:


If you see above, the build fails in the robot-tidy, but no indication what is wrong (at least I could not find).

Am I missing something here?

BR/Luis




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13679): https://lists.opendaylight.org/g/integration-dev/message/13679
Mute This Topic: https://lists.opendaylight.org/mt/34083459/535209
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [jluhrsen@...]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13684): https://lists.opendaylight.org/g/integration-dev/message/13684
Mute This Topic: https://lists.opendaylight.org/mt/34083459/1869318
Group Owner: integration-dev+owner@...
Unsubscribe: https://lists.opendaylight.org/g/integration-dev/unsub  [zxiiro@...]
-=-=-=-=-=-=-=-=-=-=-=-