Re: #84024 migrate Unimgr master to Neon-SR1

Donald Hunter
 

Hi Mahesh,

I pushed this changeset which includes the bgp-api and apidoc explorer, with the problematic union commented out in ietf-bgp-common.


If we submit the change, it would go onto a bgp-api branch, or you can review it locally with git-review -d 84051

 It all seems to work, with augmentations appearing under ietf-routing:


A couple of things worth noting.

* We get the following warnings which might just indicate the module does not contribute its own root nodes, or might be more concerning:

23:06:06.930 INFO [qtp731828305-75] Modules found [58]
23:06:06.936 WARN [qtp731828305-75] Could not generate doc for iana-bfd-types,2018-08-01
23:06:06.937 WARN [qtp731828305-75] Could not generate doc for iana-if-type,2017-01-19
23:06:06.939 WARN [qtp731828305-75] Could not generate doc for ieee802-dot1q-types,2018-03-07
23:06:06.940 WARN [qtp731828305-75] Could not generate doc for ietf-bfd-types,2018-08-01
23:06:06.944 WARN [qtp731828305-75] Could not generate doc for ietf-bgp,2019-06-13
23:06:06.945 WARN [qtp731828305-75] Could not generate doc for ietf-bgp-policy,2019-06-13
23:06:06.945 WARN [qtp731828305-75] Could not generate doc for ietf-bgp-types,2019-06-13
23:06:06.946 WARN [qtp731828305-75] Could not generate doc for ietf-flexible-encapsulation,2017-10-30
23:06:06.947 WARN [qtp731828305-75] Could not generate doc for ietf-if-l3-vlan,2017-10-30
23:06:06.950 WARN [qtp731828305-75] Could not generate doc for ietf-inet-types,2013-07-15
23:06:06.953 WARN [qtp731828305-75] Could not generate doc for ietf-interfaces-common,2019-03-05
23:06:06.956 WARN [qtp731828305-75] Could not generate doc for ietf-netconf-monitoring-extension,2013-12-10
23:06:06.957 WARN [qtp731828305-75] Could not generate doc for ietf-netconf-notifications,2012-02-06
23:06:06.960 WARN [qtp731828305-75] Could not generate doc for ietf-network-topology,2018-02-26
23:06:06.962 WARN [qtp731828305-75] Could not generate doc for ietf-restconf,2013-10-19
23:06:06.964 WARN [qtp731828305-75] Could not generate doc for ietf-restconf,2017-01-26
23:06:06.976 WARN [qtp731828305-75] Could not generate doc for ietf-routing-types,2017-12-04
23:06:06.977 WARN [qtp731828305-75] Could not generate doc for ietf-yang-types,2013-07-15
23:06:06.978 WARN [qtp731828305-75] Could not generate doc for mef-common,2018-03-21
23:06:06.979 WARN [qtp731828305-75] Could not generate doc for mef-common-types,2018-03-21
23:06:06.980 WARN [qtp731828305-75] Could not generate doc for nrm-connectivity,2018-03-21
23:06:06.981 WARN [qtp731828305-75] Could not generate doc for nrp-interface,2018-03-21
23:06:06.983 WARN [qtp731828305-75] Could not generate doc for sal-remote-augment,2014-07-08
23:06:07.010 WARN [qtp731828305-75] Could not generate doc for yang-ext,2013-07-09

* When I install a Unimgr driver feature, e.g. odl-unimgr-cisco it seems to cause the apidoc explorer to undeploy:

opendaylight-user@root>http:list
ID  │ Servlet            │ Servlet-Name                     │ State       │ Alias               │ Url
────┼────────────────────┼──────────────────────────────────┼─────────────┼─────────────────────┼────────────────────────────────────
186 │ JolokiaServlet     │ ServletModel-2                   │ Deployed    │ /jolokia            │ [/jolokia/*]
204 │ MoonTokenEndpoint  │ ServletModel-5                   │ Deployed    │ /moon               │ [/moon/*]
204 │ OAuth2TokenServlet │ ServletModel-7                   │ Deployed    │ /oauth2             │ [/oauth2/*]
293 │ ResourceServlet    │ /apidoc/18/explorer:/18/explorer │ Deployed    │ /apidoc/18/explorer │ [/apidoc/18/explorer/*]
293 │ ResourceServlet    │ /apidoc/explorer:/explorer       │ Deployed    │ /apidoc/explorer    │ [/apidoc/explorer/*]
293 │ ServletContainer   │ ServletContainer                 │ Deployed    │                     │ [/apidoc/apis/*, /apidoc/18/apis/*]
opendaylight-user@root>feature:install odl-unimgr-cisco-xr-driver 
opendaylight-user@root>http:list
ID  │ Servlet            │ Servlet-Name                     │ State       │ Alias               │ Url
────┼────────────────────┼──────────────────────────────────┼─────────────┼─────────────────────┼────────────────────────
186 │ JolokiaServlet     │ ServletModel-44                  │ Deployed    │ /jolokia            │ [/jolokia/*]
204 │ MoonTokenEndpoint  │ ServletModel-47                  │ Deployed    │ /moon               │ [/moon/*]
204 │ OAuth2TokenServlet │ ServletModel-49                  │ Deployed    │ /oauth2             │ [/oauth2/*]
292 │ ServletContainer   │ ServletContainer                 │ Deployed    │                     │ [/rests/*]
293 │ ResourceServlet    │ /apidoc/18/explorer:/18/explorer │ Undeployed  │ /apidoc/18/explorer │ [/apidoc/18/explorer/*]
293 │ ResourceServlet    │ /apidoc/explorer:/explorer       │ Undeployed  │ /apidoc/explorer    │ [/apidoc/explorer/*]

It’s possible to recover by exiting and restarting karaf.


On 28 Aug 2019, at 13:43, Donald Hunter (donaldh) <donaldh@...> wrote:

Yep, I accidentally included the two pom files in the changeset. 

Cheers
Donald.

On 28 Aug 2019, at 01:32, Mahesh Jethanandani <mjethanandani@...> wrote:

Hi Donald,

I was about to comment on the changes, but noticed that you took out bgp and bgp-orig in Patchset 2. Good, because I was not sure we were ready to commit that quite as yet.

Cheers.

On Aug 27, 2019, at 3:47 PM, Donald Hunter (donaldh) <donaldh@...> wrote:

This change updates all the dependency versions to align with Neon-SR1


This seems to resurrect the Unimgr master branch to a working state. It is a prerequisite for:
  • merging up the stable/fluorine work
  • integrating apidoc explorer
  • experimenting with bgp-api on new MD-SAL
Cheers,
Donald.

Join unimgr-dev@lists.opendaylight.org to automatically receive all group messages.