This group is locked. No changes can be made to the group while it is locked.
Date
1 - 5 of 5
c/59988 copy-pasting aaa-h2-store code in aaa-shiro
|
Michael Vorburger <vorburger@...>
Hello, just stumbled upon https://git.opendaylight.org/gerrit/#/c/59988/ by coincidence, and was wondering if you guys really meant to copy/paste (not move) all of the code from aaa-h2-store code into aaa-shiro? Not sure that's really such a great idea / design... one ALWAYS ends up ultimately regretting copy/paste'd code, IMHO. Can't you just add a dependency from aaa-shiro to aaa-h2-store? Tx, M. PS: I'm not on aaa-dev (got enough email as it is), plz Reply-to-all not only aaa-dev. -- |
|
|
|
Mohamed ElSerngawy
Hi Michael, In aaa meeting, We agree that we need to move all the AAA data store bundles ( H2 and MD-SAL) to be under the same bundle with aaa-shiro. There are many benefits from doing that e.g easy maintain code and bundle dependencies. same time we doing refactoring on the go to make the source code in same design style. You can join us next meeting we will discuss this in more details. Thnx On Tue, Jul 11, 2017 at 4:37 AM, Michael Vorburger <vorburger@...> wrote:
|
|
|
|
Ryan Goulding <ryandgoulding@...>
I think he is asking why you are copying and pasting instead of just moving? I tend to agree let's not keep the code in two divergent places. I.e. Move it to shiro bundle and remove it from h2 store bundle On Jul 11, 2017, at 9:25 AM, Mohamed El-Serngawy <m.elserngawy@...> wrote:
|
|
|
|
Mohamed ElSerngawy
well, moving the code will affect other bundles dependency even the deprecated one and the effort to fix that is useless. I tried that couple of month ago but I'm lazy to do it again :) . On Tue, Jul 11, 2017 at 9:42 AM, Ryan Goulding <ryandgoulding@...> wrote:
|
|
|
|
Michael Vorburger <vorburger@...>
On Tue, Jul 11, 2017 at 7:26 PM, Mohamed El-Serngawy <m.elserngawy@...> wrote:
but I'm depending on aaa-h2-store in aaa-cli-jar, and so any such refactoring (move) should deal with that as well. It has to be done sooner or later, either now (better) or later when you'll want to remove aaa-h2-store. What typically happens when you copy/paste is that the code stays around in both places, someone makes some fix to the h2 stuff in aaa-shiro, forgets about and doesn't care about aaa-h2-store anymore, and aaa-cli-jar which still depends on that old code doesn't get that fix etc. You know how it goes. That's why, if you refactor, it's best to make the effort to move things from the start in one go, IMHO.
yup, that's what I meant.
would love to but don't have the bandwidth to get drawn into yet another project; sorry! ;-)
|
|
|