This group is locked. No changes can be made to the group while it is locked.
Date
1 - 17 of 17
[OpenDaylight TSC] CSIT status in proposed topic:neon-mri ("Weather Item" TSC-132)
|
Michael Vorburger <vorburger@...>
On Thu, Oct 11, 2018 at 7:08 PM Luis Gomez <ecelgp@...> wrote:
Luis, FTR Stephen fixed the problem below in https://git.opendaylight.org/gerrit/#/c/76817/5..6/karaf/pom.xml (TX skitt!)
nobody said your patch introduced it; it's an impact of the new Karaf in the new odlparent. The first, but may be not the last one? ;-)
|
||
|
|
||
|
Luis Gomez
Yeah, I also saw the error, which BTW I have never seen before but on the other hand it is very unlike that this is introduced by my patch that only thing that does is to add int/dist to the topic patch list.
toggle quoted messageShow quoted text
|
||
|
|
||
|
Michael Vorburger <vorburger@...>
Hello, On Thu, Oct 11, 2018 at 1:12 AM Luis Gomez <ecelgp@...> wrote: This should fix: Thanks. I have just kicked off a new https://jenkins.opendaylight.org/releng/view/integration/job/integration-multipatch-test-neon/75/ I am also running this job in sandbox to verify: this failed with a new error, is this just because a ran on sandbox or a real new problem: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (default) on project karaf: An Ant BuildException has occured: Directory does not exist: /w/workspace/integration-multipatch-test-neon/patch_tester/distribution/karaf/target/assembly/system/mysql [ERROR] around Ant part ...<delete includeemptydirs="true">... @ 4:35 in /w/workspace/integration-multipatch-test-neon/patch_tester/distribution/karaf/target/antrun/build-main.xml [ERROR] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (default) on project karaf: An Ant BuildException has occured: Directory does not exist: /w/workspace/integration-multipatch-test-neon/patch_tester/distribution/karaf/target/assembly/system/mysql around Ant part ...<delete includeemptydirs="true">... @ 4:35 in /w/workspace/integration-multipatch-test-neon/patch_tester/distribution/karaf/target/antrun/build-main.xml This mysql business sounds vaguely familiar - is this the thing we did to yank out (remove) the mysql JDBC client because of license concerns? MAYBE that is no longer there now (check please), because the newer version of Karaf in the new odlparent has picked up a new PAX JDBC where "someone" (me!) had done https://ops4j1.jira.com/browse/PAXJDBC-128 to remove that at source upstream? If that has trickled down and finally reached us now, we can probably remove the Ant <delete> hack we had to do at the time. Will someone have a closer look at this and confirm? BR/Luis
|
||
|
|
||
|
Luis Gomez
This should fix:
toggle quoted messageShow quoted text
https://git.opendaylight.org/gerrit/#/c/76839/ I am also running this job in sandbox to verify: https://jenkins.opendaylight.org/sandbox/job/integration-multipatch-test-neon/1 BR/Luis
On Oct 10, 2018, at 3:53 PM, Robert Varga <nite@...> wrote:
|
||
|
|
||
|
Robert Varga
On 11/10/2018 00:49, Luis Gomez wrote:
It is also weird this miss was not detected before...I believe we weren't upgrading karaf using this process -- both Fluorine and Oxygen are shipping odlparent-3.1.x. Regards, Robert
|
||
|
|
||
|
Luis Gomez
OK, it seems like int/dist project is not included in the logic resolving a topic, let me fix that quickly. It is also weird this miss was not detected before...
toggle quoted messageShow quoted text
On Oct 10, 2018, at 3:21 PM, Robert Varga <nite@...> wrote:
|
||
|
|
||
|
Robert Varga
On 11/10/2018 00:18, Robert Varga wrote:
On 11/10/2018 00:13, Robert Varga wrote:RTFC:On 11/10/2018 00:02, Robert Varga wrote:And if it's not that, neon-mri patches need to be audited. I am prettyfeatures-core-4.1.5 ... wrong base karaf distro, pulled fromperhaps 00:02:10.037 adding integration/distribution 00:02:10.039 Cloning into 'distribution'... 00:02:12.545 Already on 'master' 00:02:12.545 Your branch is up to date with 'origin/master'. 00:02:12.546 /w/workspace/integration-multipatch-test-neon/patch_tester/infrautils /w/workspace/integration-multipatch-test-neon/patch_tester 00:02:12.856 Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) i.e. int/dist is not patched. Luis, back to you :) Bye, Robert
|
||
|
|
||
|
Robert Varga
On 11/10/2018 00:13, Robert Varga wrote:
On 11/10/2018 00:02, Robert Varga wrote:And if it's not that, neon-mri patches need to be audited. I am prettyfeatures-core-4.1.5 ... wrong base karaf distro, pulled fromperhaps sure controller-netconf are okay. Bye, Robert
|
||
|
|
||
|
Robert Varga
On 11/10/2018 00:02, Robert Varga wrote:
features-core-4.1.5 ... wrong base karaf distro, pulled fromperhaps https://git.opendaylight.org/gerrit/#/c/76817/4..5/artifacts/upstream/properties/pom.xml Bye, Robert
|
||
|
|
||
|
Robert Varga
features-core-4.1.5 ... wrong base karaf distro, pulled from odlparent-3.1.0-3, not 4.0.2. Sent from my BlackBerry - the most secure mobile device - via the Orange Network
Sent: October 10, 2018 23:59 To: vorburger@... Cc: nite@...; aaa-dev@...; tompantelis@...; netvirt-dev@...; tsc@...; netconf-dev@...; skitt@...; jluhrsen@...; jluhrsen@... Subject: Re: [OpenDaylight TSC] CSIT status in proposed topic:neon-mri ("Weather Item" TSC-132) Just to be clear, this is not a multi-patch job issue but a controller version integration issue, right?
|
||
|
|
||
|
Luis Gomez
Just to be clear, this is not a multi-patch job issue but a controller version integration issue, right?
toggle quoted messageShow quoted text
|
||
|
|
||
|
Michael Vorburger <vorburger@...>
- netconf-dev, as it's no longer their problem: On Wed, Oct 10, 2018 at 1:35 PM Michael Vorburger <vorburger@...> wrote:
after having sorted out a few other problems, we're unfortunately still back to this issue: despite https://git.opendaylight.org/gerrit/76817, https://jenkins.opendaylight.org/releng/view/integration/job/integration-multipatch-test-neon/71/ still fails e.g. on https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/aaa-csit-1node-authn-all-neon/62/odl_1/odl1_karaf.log.gz with: 2018-10-10T19:21:48,049 | ERROR | pool-1-thread-2 | BootFeaturesInstaller | 8 - org.apache.karaf.features.core - 4.1.5 | Error installing boot features org.osgi.service.resolver.ResolutionException: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=odl-integration-compatible-with-all; type=karaf.feature; version="[0.10.0.SNAPSHOT,0.10.0.SNAPSHOT]"; filter:="(&(osgi.identity=odl-integration-compatible-with-all)(type=karaf.feature)(version>=0.10.0.SNAPSHOT)(version<=0.10.0.SNAPSHOT))" [caused by: Unable to resolve odl-integration-compatible-with-all/0.10.0.SNAPSHOT: missing requirement [odl-integration-compatible-with-all/0.10.0.SNAPSHOT] osgi.identity; osgi.identity=odl-ovsdb-southbound-impl; type=karaf.feature; version="[1.8.0.SNAPSHOT,1.8.0.SNAPSHOT]" [caused by: Unable to resolve odl-ovsdb-southbound-impl/1.8.0.SNAPSHOT: missing requirement [odl-ovsdb-southbound-impl/1.8.0.SNAPSHOT] osgi.identity; osgi.identity=odl-ovsdb-library; type=karaf.feature; version="[1.8.0.SNAPSHOT,1.8.0.SNAPSHOT]" [caused by: Unable to resolve odl-ovsdb-library/1.8.0.SNAPSHOT: missing requirement [odl-ovsdb-library/1.8.0.SNAPSHOT] osgi.identity; osgi.identity=org.opendaylight.ovsdb.library; type=osgi.bundle; version="[1.8.0.SNAPSHOT,1.8.0.SNAPSHOT]"; resolution:=mandatory [caused by: Unable to resolve org.opendaylight.ovsdb.library/1.8.0.SNAPSHOT: missing requirement [org.opendaylight.ovsdb.library/1.8.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.aaa.cert.api)(version>=0.9.0)(!(version>=1.0.0)))" [caused by: Unable to resolve org.opendaylight.aaa.cert/0.9.0.SNAPSHOT: missing requirement [org.opendaylight.aaa.cert/0.9.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.bouncycastle.asn1)(version>=1.60.0)(!(version>=2.0.0)))"]]]]]
|
||
|
|
||
|
Luis Gomez
On Oct 10, 2018, at 6:36 AM, Stephen Kitt <skitt@...> wrote:+1, distribution is always added at the end so no need to specify in the BUILD_ORDER. If there is an int/dist patch in the patch list or the topic it will grab that, otherwise it will grab the job stream code (e.g. neon=master).
|
||
|
|
||
|
Stephen Kitt <skitt@...>
On Wed, 10 Oct 2018 13:35:29 +0200
Michael Vorburger <vorburger@...> wrote: On Wed, Oct 10, 2018 at 12:30 PM Robert Varga <nite@...> wrote:Since 76817 is in the neon-mri topic, it should be picked up byint/dist is just another project, hence it obviously needs aOh! Right. - Thanks a lot for puttting that together. multipatch automatically. Regards, Stephen
|
||
|
|
||
|
Michael Vorburger <vorburger@...>
On Wed, Oct 10, 2018 at 12:30 PM Robert Varga <nite@...> wrote: On 10/10/2018 00:42, Michael Vorburger wrote: Oh! Right. - Thanks a lot for puttting that together. Luis, I want to run a new multipatch job incl. c/76817 ... have just kicked off new https://jenkins.opendaylight.org/releng/view/integration/job/integration-multipatch-test-neon/66, where I manually added "integration/distribution" to "BUILD_ORDER" ... is that correct? If yes, do we need to add that in the default (similar to https://git.opendaylight.org/gerrit/#/c/76724) as well now? If not, confirm if this is automatic/implicit anyway? PS: RELENG-135 makes me a little sceptical how well this actually work, but let's discuss that further on the other thread "Build failures, aren't we making a big mistake by not isolating version bumping multipatch jobs from new SNAPSHOTs?" instead.
|
||
|
|
||
|
Robert Varga
On 10/10/2018 00:42, Michael Vorburger wrote:
The SFT in AAA should have caught this, but apparently didn't... perhapsint/dist is just another project, hence it obviously needs a neon-mri patch: https://git.opendaylight.org/gerrit/76817. Bye, Robert
|
||
|
|
||
|
Michael Vorburger <vorburger@...>
-SFC but +aaa & Tom & Robert, On Tue, Oct 9, 2018 at 6:35 PM Michael Vorburger <vorburger@...> wrote:
Jamo and Ijust had a look at https://jenkins.opendaylight.org/releng/view/integration/job/integration-multipatch-test-neon/63/, and he from there finds https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/aaa-csit-1node-authn-all-neon/59/odl_1/odl1_karaf.log.gz with this new beauty, looks like some problem in AAA re. BouncyCastle version?! The SFT in AAA should have caught this, but apparently didn't... perhaps it only appears in an integration/distribution Karaf? Tom or Robert, is this something you would be willing to dig more into? 2018-10-09T19:48:59,694 | ERROR | pool-1-thread-2 | BootFeaturesInstaller | 8 - org.apache.karaf.features.core - 4.1.5 | Error installing boot features org.osgi.service.resolver.ResolutionException: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=odl-integration-compatible-with-all; type=karaf.feature; version="[0.10.0.SNAPSHOT,0.10.0.SNAPSHOT]"; filter:="(&(osgi.identity=odl-integration-compatible-with-all)(type=karaf.feature)(version>=0.10.0.SNAPSHOT)(version<=0.10.0.SNAPSHOT))" [caused by: Unable to resolve odl-integration-compatible-with-all/0.10.0.SNAPSHOT: missing requirement [odl-integration-compatible-with-all/0.10.0.SNAPSHOT] osgi.identity; osgi.identity=odl-sfc-ovs; type=karaf.feature; version="[0.9.0.SNAPSHOT,0.9.0.SNAPSHOT]" [caused by: Unable to resolve odl-sfc-ovs/0.9.0.SNAPSHOT: missing requirement [odl-sfc-ovs/0.9.0.SNAPSHOT] osgi.identity; osgi.identity=org.opendaylight.sfc.ovs; type=osgi.bundle; version="[0.9.0.SNAPSHOT,0.9.0.SNAPSHOT]"; resolution:=mandatory [caused by: Unable to resolve org.opendaylight.sfc.ovs/0.9.0.SNAPSHOT: missing requirement [org.opendaylight.sfc.ovs/0.9.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.ovsdb.southbound)(version>=1.8.0)(!(version>=2.0.0)))" [caused by: Unable to resolve org.opendaylight.ovsdb.southbound-impl/1.8.0.SNAPSHOT: missing requirement [org.opendaylight.ovsdb.southbound-impl/1.8.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.ovsdb.lib)(version>=1.8.0)(!(version>=2.0.0)))" [caused by: Unable to resolve org.opendaylight.ovsdb.library/1.8.0.SNAPSHOT: missing requirement [org.opendaylight.ovsdb.library/1.8.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.aaa.cert.api)(version>=0.9.0)(!(version>=1.0.0)))" [caused by: Unable to resolve org.opendaylight.aaa.cert/0.9.0.SNAPSHOT: missing requirement [org.opendaylight.aaa.cert/0.9.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.bouncycastle.asn1)(version>=1.60.0)(!(version>=2.0.0)))"]]]]]] at org.apache.felix.resolver.ResolutionError.toException(ResolutionError.java:42) ~[?:?] at org.apache.felix.resolver.ResolverImpl.doResolve(ResolverImpl.java:391) ~[?:?] at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:377) ~[?:?] at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:349) ~[?:?] at org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:218) ~[?:?] at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:291) ~[?:?] at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1248) ~[?:?] at org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$1(FeaturesServiceImpl.java:1147) ~[?:?] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
|
||
|
|
||