Validation changes


Krell, Sherry <sherry.krell@...>
 

Hi Wojciech,

 

I’ve pushed out 2 validation related changes for review.

 

https://git.opendaylight.org/gerrit/#/c/15993/  (AuthenticationBuilder)

https://git.opendaylight.org/gerrit/#/c/16154/  (ClaimBuilder)

 

 

From: aaa-dev-bounces@... [mailto:aaa-dev-bounces@...] On Behalf Of Krell, Sherry
Sent: Thursday, March 05, 2015 8:32 AM
To: Wojciech Dec
Cc: aaa-dev@...
Subject: Re: [Aaa-dev] Change in aaa[master]: DO NOT MERGE - Add validation handling to ClaimBuilder and A...

 

Hi Wojciech,

 

Ok. I had figured that might be the answer, so I’ve actually started splitting out this check-in into one focused on AuthenticationBuilder and one focused on ClaimBuilder. The AuthenticationBuilder one is already on gerrit; it just needs to be reviewed.

 

From: Wojciech Dec [mailto:wdec.ietf@...]
Sent: Thursday, March 05, 2015 3:17 AM
To: Krell, Sherry
Cc: aaa-dev@...
Subject: Re: Change in aaa[master]: DO NOT MERGE - Add validation handling to ClaimBuilder and A...

 

Hi Sherry,

well, at least for Lithium, we won't be moving the user-store to MD-SAL. I'd say let's harden at least a bit the stuff we have now, as currently it appears to cause surprises to users that really we should be catching in tests.

Cheers,

Wojciech.

 

On 25 February 2015 at 02:06, Krell, Sherry <sherry.krell@...> wrote:

HI Wojciech,

I've pushed out an initial change to address your request for more negative testing (null, empty string, etc.) at https://git.opendaylight.org/gerrit/15688. This change was supposed to be targeted at only ClaimBuilder. However, since AuthenticationBuilder extends it, I had to make changes there as well. Unfortunately, there was no validation for these types of failures in place in the builders. So I ended up touching quite a few files already, and I'm not done yet. After speaking with Liem, there were a few issues that needed to be addressed:
1) missing validation (I've tried to update the interface documentation to capture at a minimum the required fields).
2) the MutableClaim and MutableAuthentication are actually supposed to be Immutable

Also, in chatting with some folks here it sounds like these builders would actually go away, if we end up moving the authentication piece into MD-SAL, since they would be generated by the yang tools.

So my question is with respect to the current commit I've posted. Is it the right direction to take? If we are going to move authn into MD-SAL, maybe we just skip hardening the builders for now?


-----Original Message-----
From: Gerrit Code Review [mailto:gerrit@...]
Sent: Tuesday, February 24, 2015 4:45 PM
To: Krell, Sherry
Subject: Change in aaa[master]: DO NOT MERGE - Add validation handling to ClaimBuilder and A...

From jenkins-releng <jenkins-releng@...>:

jenkins-releng has posted comments on this change.

Change subject: DO NOT MERGE - Add validation handling to ClaimBuilder and AuthenticationBuilder. Update unit tests to get them all working again.
......................................................................


Patch Set 1:

Build Started https://jenkins.opendaylight.org/releng/job/aaa-verify-master/16/

--
To view, visit https://git.opendaylight.org/gerrit/15688
To unsubscribe, visit https://git.opendaylight.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8910fe9c50d1234dadaefbbb92f245e9c15900fa
Gerrit-PatchSet: 1
Gerrit-Project: aaa
Gerrit-Branch: master
Gerrit-Owner: Sherry Krell <sherry.krell@...>
Gerrit-Reviewer: jenkins-releng <jenkins-releng@...>
Gerrit-HasComments: No