Date   

Re: Follow up with Document status

Wojciech Dec <wdec.ietf@...>
 

Hi George,

AAA doc changes are in:
 https://git.opendaylight.org/gerrit/19400

-Wojciech.

On 27 April 2015 at 21:19, George Zhao <George.Y.Zhao@...> wrote:

Project leads in the following projects, could you please provide your documentation locations:

 

AAA

ALTO

Controller,

D4A

DIDM

dLux

L2switch

SDNi

SNMP

SNMP4SDN

SNBI

Yangtools

 

Please use TTP project for example, its documentation in docs.git/manuals/developers-guide/src/main/asciidoc/ttp.adoc

 

Thanks,

George



回复: a question about alto ecs ?

linxiao9292
 

Yes! 
It is really helpful! 
Thanks a lot! 

Xiao Lin 



------------------ 原始邮件 ------------------
发件人: Wendy Roome <wendy@...>
发送时间: 2015年04月30日 21:50
收件人: <linxiao9292@...> <linxiao9292@...>
抄送: alto-dev@... <alto-dev@...>
主题: Re: [alto-dev] a question about alto ecs ?

According the rfc 7285,  ECS response just gives the cost. The server hides the path and any other information it uses to calculate the cost.

The easiest way to implement ECS is for the server to map each endpoint to a pid and return the costs between the pids. But the server  MAY use more detailed cost information if it wants.

Does that help?



On Apr 29, 2015, at 21:15, <linxiao9292@...> <linxiao9292@...> wrote:

Hi all,

When ALTO server provide endpoint cost between h1 and h2 , is the path between h1 and h2 given ?

For example, 

before ALTO server provides endpoint cost, it knows that h1 can connect to h2 in path h1-s1-s3-h2
h1-s1-s3-h2
       |    |
      s2-s4

Or

ALTO server could assume by itself that h1 could be connect to h2 through path h1-s1-s2-s4-s3-h2?

Thanks & Best Wishes!

Xiao Lin
_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev


some comments ALTO code

chenguohai
 

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImpl line36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 


Re: some comments ALTO code

Gao Kai
 

Mr. Chen,

We appreciate your interest of ALTO and the effort to improve its performance.

For the record, however, the code are generated by yangtools automatically. A patch is still welcomed but I think you can report this to the yangtools group so that these issues can be solved, at least from my perspective of view, in a more general and elegant manner.

Thanks again for your work and we are glad to get feedback from the community.

Yours,

GK

On 04/05/15 17:20, Chenguohai wrote:

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImpl line36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华 为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本 邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全 部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 



_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev


Re some comments ALTO code

chenguohai
 

Hi Kai,

 

Good proposal. I’ll try to find who is responsible for that.

There is another project(https://wiki.opendaylight.org/view/YANG_Tools:Main), may be the committers know the clue.

 

BR

Robert

发件人: Gao Kai [mailto:godrickk@...]
发送时间: Monday, May 04, 2015 11:00 PM
收件人: Chenguohai; alto-dev@...
主题: Re: [alto-dev] some comments ALTO code

 

Mr. Chen,

We appreciate your interest of ALTO and the effort to improve its performance.

For the record, however, the code are generated by yangtools automatically. A patch is still welcomed but I think you can report this to the yangtools group so that these issues can be solved, at least from my perspective of view, in a more general and elegant manner.

Thanks again for your work and we are glad to get feedback from the community.

Yours,

GK

On 04/05/15 17:20, Chenguohai wrote:

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImplline36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华 为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本 邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全 部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

 

_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev

 


Re some comments ALTO code

chenguohai
 

 

 

Hi  folks,

I am suspecting there are some constraints on AddressGroup which could most include one IPV4 and(or) one IPV6. The processing code in RFC2ModelEndpointAddressGroupCoventer.java seems only could cope with most one IPV4 and(or) one IPV6.

 

    @Override

    protected Object _convert() {

        List<ModelEndpointAddressGroup> out = new LinkedList<ModelEndpointAddressGroup>();

        if ((in().ipv4 != null) && (!in().ipv4.isEmpty())) {

            ModelEndpointAddressGroup v4 = new ModelEndpointAddressGroup();

            v4.setJSONAddressType(ModelEndpointAddressGroup.IPV4);

            v4.setJSONEndpointPrefix(in().ipv4);

            out.add(v4);

        }

        if ((in().ipv6 != null) && (!in().ipv6.isEmpty())) {

            ModelEndpointAddressGroup v6 = new ModelEndpointAddressGroup();

            v6.setJSONAddressType(ModelEndpointAddressGroup.IPV6);

            v6.setJSONEndpointPrefix(in().ipv6);

            out.add(v6);

        }

        return out;

    }

It is reseanable that one EP has multiple IPV4 addresses or multiple IPV6 addresses.

 

Did I misunderstand something .

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

发件人: Chenguohai
发送时间: Tuesday, May 05, 2015 3:39 PM
收件人: 'godrickk@...'
抄送: alto-dev@...
主题: Re [alto-dev] some comments ALTO code

 

Hi Kai,

 

Good proposal. I’ll try to find who is responsible for that.

There is another project(https://wiki.opendaylight.org/view/YANG_Tools:Main), may be the committers know the clue.

 

BR

Robert

发件人: Gao Kai [mailto:godrickk@...]
发送时间: Monday, May 04, 2015 11:00 PM
收件人: Chenguohai; alto-dev@...
主题: Re: [alto-dev] some comments ALTO code

 

Mr. Chen,

We appreciate your interest of ALTO and the effort to improve its performance.

For the record, however, the code are generated by yangtools automatically. A patch is still welcomed but I think you can report this to the yangtools group so that these issues can be solved, at least from my perspective of view, in a more general and elegant manner.

Thanks again for your work and we are glad to get feedback from the community.

Yours,

GK

On 04/05/15 17:20, Chenguohai wrote:

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImpl line36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华 为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本 邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全 部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

 

_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev

 


Re: Re some comments ALTO code

Gao Kai
 

Mr. Chen,

in().ipv4 is a list, so is in().ipv6.


On 07/05/15 08:31, Chenguohai wrote:

 

 

Hi  folks,

I am suspecting there are some constraints on AddressGroup which could most include one IPV4 and(or) one IPV6. The processing code in RFC2ModelEndpointAddressGroupCoventer.java seems only could cope with most one IPV4 and(or) one IPV6.

 

    @Override

    protected Object _convert() {

        List<ModelEndpointAddressGroup> out = new LinkedList<ModelEndpointAddressGroup>();

        if ((in().ipv4 != null) && (!in().ipv4.isEmpty())) {

            ModelEndpointAddressGroup v4 = new ModelEndpointAddressGroup();

            v4.setJSONAddressType(ModelEndpointAddressGroup.IPV4);

            v4.setJSONEndpointPrefix(in().ipv4);

            out.add(v4);

        }

        if ((in().ipv6 != null) && (!in().ipv6.isEmpty())) {

            ModelEndpointAddressGroup v6 = new ModelEndpointAddressGroup();

            v6.setJSONAddressType(ModelEndpointAddressGroup.IPV6);

            v6.setJSONEndpointPrefix(in().ipv6);

            out.add(v6);

        }

        return out;

    }

It is reseanable that one EP has multiple IPV4 addresses or multiple IPV6 addresses.

 

Did I misunderstand something .

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他 人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件 通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

发件人: Chenguohai
发送时间: Tuesday, May 05, 2015 3:39 PM
收件人: 'godrickk@...'
抄送: alto-dev@...
主题: Re [alto-dev] some comments ALTO code

 

Hi Kai,

 

Good proposal. I’ll try to find who is responsible for that.

There is another project(https://wiki.opendaylight.org/view/YANG_Tools:Main), may be the committers know the clue.

 

BR

Robert

发件人: Gao Kai [mailto:godrickk@...]
发送时间: Monday, May 04, 2015 11:00 PM
收件人: Chenguohai; alto-dev@...
主题: Re: [alto-dev] some comments ALTO code

 

Mr. Chen,

We appreciate your interest of ALTO and the effort to improve its performance.

For the record, however, the code are generated by yangtools automatically. A patch is still welcomed but I think you can report this to the yangtools group so that these issues can be solved, at least from my perspective of view, in a more general and elegant manner.

Thanks again for your work and we are glad to get feedback from the community.

Yours,

GK

On 04/05/15 17:20, Chenguohai wrote:

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImpl line36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华 为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本 邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全 部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

 

_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev

 



Re: 答复: Re some comments ALTO code

chenguohai
 

 

 

Dear all

 

That is my misunderstanding.

I have posted my previous question here(https://ask.opendaylight.org/question/3617/there-should-be-some-improvement-about-the-auto-generated-codes-from-yangtools/), but there is no answer now.

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

发件人: Gao Kai [mailto:godrickk@...]
发送时间: Thursday, May 07, 2015 8:48 AM
收件人: Chenguohai
抄送: alto-dev@...
主题: Re: Re [alto-dev] some comments ALTO code

 

Mr. Chen,

in().ipv4 is a list, so is in().ipv6.

On 07/05/15 08:31, Chenguohai wrote:

 

 

Hi  folks,

I am suspecting there are some constraints on AddressGroup which could most include one IPV4 and(or) one IPV6. The processing code in RFC2ModelEndpointAddressGroupCoventer.java seems only could cope with most one IPV4 and(or) one IPV6.

 

    @Override

    protected Object _convert() {

        List<ModelEndpointAddressGroup> out = new LinkedList<ModelEndpointAddressGroup>();

        if ((in().ipv4 != null) && (!in().ipv4.isEmpty())) {

            ModelEndpointAddressGroup v4 = new ModelEndpointAddressGroup();

            v4.setJSONAddressType(ModelEndpointAddressGroup.IPV4);

            v4.setJSONEndpointPrefix(in().ipv4);

            out.add(v4);

        }

        if ((in().ipv6 != null) && (!in().ipv6.isEmpty())) {

            ModelEndpointAddressGroup v6 = new ModelEndpointAddressGroup();

            v6.setJSONAddressType(ModelEndpointAddressGroup.IPV6);

            v6.setJSONEndpointPrefix(in().ipv6);

            out.add(v6);

        }

        return out;

    }

It is reseanable that one EP has multiple IPV4 addresses or multiple IPV6 addresses.

 

Did I misunderstand something .

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他 人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件 通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

发件人: Chenguohai
发送时间: Tuesday, May 05, 2015 3:39 PM
收件人: 'godrickk@...'
抄送: alto-dev@...
主题: Re [alto-dev] some comments ALTO code

 

Hi Kai,

 

Good proposal. I’ll try to find who is responsible for that.

There is another project(https://wiki.opendaylight.org/view/YANG_Tools:Main), may be the committers know the clue.

 

BR

Robert

发件人: Gao Kai [mailto:godrickk@...]
发送时间: Monday, May 04, 2015 11:00 PM
收件人: Chenguohai; alto-dev@...
主题: Re: [alto-dev] some comments ALTO code

 

Mr. Chen,

We appreciate your interest of ALTO and the effort to improve its performance.

For the record, however, the code are generated by yangtools automatically. A patch is still welcomed but I think you can report this to the yangtools group so that these issues can be solved, at least from my perspective of view, in a more general and elegant manner.

Thanks again for your work and we are glad to get feedback from the community.

Yours,

GK

On 04/05/15 17:20, Chenguohai wrote:

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImpl line36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华 为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本 邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全 部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

 

_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev

 

 


Re: Re some comments ALTO code

chenguohai
 

 

Hi all

I have reported and yangtools shall take over that.

@Kai, you gave me much help, thank you.

Link is here: https://bugs.opendaylight.org/show_bug.cgi?id=3147

 

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

发件人: Chenguohai
发送时间: Tuesday, May 05, 2015 3:39 PM
收件人: 'godrickk@...'
抄送: alto-dev@...
主题: Re [alto-dev] some comments ALTO code

 

Hi Kai,

 

Good proposal. I’ll try to find who is responsible for that.

There is another project(https://wiki.opendaylight.org/view/YANG_Tools:Main), may be the committers know the clue.

 

BR

Robert

发件人: Gao Kai [mailto:godrickk@...]
发送时间: Monday, May 04, 2015 11:00 PM
收件人: Chenguohai; alto-dev@...
主题: Re: [alto-dev] some comments ALTO code

 

Mr. Chen,

We appreciate your interest of ALTO and the effort to improve its performance.

For the record, however, the code are generated by yangtools automatically. A patch is still welcomed but I think you can report this to the yangtools group so that these issues can be solved, at least from my perspective of view, in a more general and elegant manner.

Thanks again for your work and we are glad to get feedback from the community.

Yours,

GK

On 04/05/15 17:20, Chenguohai wrote:

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImpl line36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华 为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本 邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全 部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

 

_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev

 

 


Re: Re some comments ALTO code

Gao Kai
 

Mr. Chen,

Thank you for your participation. I'm very glad that I can help.

Yours,

Kai

On 08/05/15 11:00, Chenguohai wrote:

 

Hi all

I have reported and yangtools shall take over that.

@Kai, you gave me much help, thank you.

Link is here: https://bugs.opendaylight.org/show_bug.cgi?id=3147

 

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他 人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件 通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

发件人: Chenguohai
发送时间: Tuesday, May 05, 2015 3:39 PM
收件人: 'godrickk@...'
抄送: alto-dev@...
主题: Re [alto-dev] some comments ALTO code

 

Hi Kai,

 

Good proposal. I’ll try to find who is responsible for that.

There is another project(https://wiki.opendaylight.org/view/YANG_Tools:Main), may be the committers know the clue.

 

BR

Robert

发件人: Gao Kai [mailto:godrickk@...]
发送时间: Monday, May 04, 2015 11:00 PM
收件人: Chenguohai; alto-dev@...
主题: Re: [alto-dev] some comments ALTO code

 

Mr. Chen,

We appreciate your interest of ALTO and the effort to improve its performance.

For the record, however, the code are generated by yangtools automatically. A patch is still welcomed but I think you can report this to the yangtools group so that these issues can be solved, at least from my perspective of view, in a more general and elegant manner.

Thanks again for your work and we are glad to get feedback from the community.

Yours,

GK

On 04/05/15 17:20, Chenguohai wrote:

Hi folks,

 

I am reading the code under ALTO@ODL. And here are my two comments.

 

1:File named AltoProviderImplBuilderunder alto-provider/……./modules/module/configuration  :in function named  'toString',first is defined to judge a common should be inserted, i recommend writting as following

        @Override

        public java.lang.String toString() {

            java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");

            //boolean first = true;

       

            if (_dataBroker != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_dataBroker=");

                builder.append(_dataBroker);

                builder.append(", ");//new added

 

             }

            if (_rpcRegistry != null) {

                //if (first) {

                //    first = false;

                //} else {

                //    builder.append(", ");

                //}

                builder.append("_rpcRegistry=");

                builder.append(_rpcRegistry);

                builder.append(", ");//new added

 

             }

            //if (first) {

            //    first = false;

            //} else {

            //    builder.append(", ");

            //}

            builder.append("augmentation=");

            builder.append(augmentation.values());

            return builder.append(']').toString();

        }

    }

Fewer judgement, fewer jumpes and simplified, consistent code,Make sense.

There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

 

2:  File named YangModuleInfoImpl line36 there are duplicated something between $YangModuleInfoImpl method(line 30 to line 33) and getModuleSourceStream.YangModuleInfoImpl can call getModuleSourceStream to get a stream.

 

    private $YangModuleInfoImpl() {

        Set<YangModuleInfo> set = new HashSet<>();

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.binding.rev131028.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.rev130405.$YangModuleInfoImpl.getInstance());

        set.add(org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.rpc.context.rev130617.$YangModuleInfoImpl.getInstance());

        importedModules = ImmutableSet.copyOf(set);

   

        //InputStream stream = $YangModuleInfoImpl.class.getResourceAsStream(resourcePath);

        //if (stream == null) {

        //    throw new IllegalStateException("Resource '" + resourcePath + "' is missing");

        //}

        InputStream stream = getModuleSourceStream ();// new added one

        try {

            stream.close();

        } catch (IOException e) {

        // Resource leak, but there is nothing we can do

        }

}

 

BR

Robert

-------------------------------------------------------------------------------------------------------------------------------------

Chen Guohai (Robert), 陈国海. Network Research Department, Huawei Technologies Co., Ltd. Telephone: 0086-25-56624606;

华 为技术有限公司 ,地址:深圳市龙岗区坂田华为基地 邮编:518129 http://www.huawei.com

-------------------------------------------------------------------------------------------------------------------------------------

本 邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全 部或部分地泄露、复制、或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!

This e-mail and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the  information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

----------------------------------------------------------------------------------------------------------------------------------------

 

 

_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev

 

 



M5 of alto in ODL?

Y. Richard Yang
 

Dear team,

My apologies for being quiet in the last few days. I did check and saw that you guys are making good process! Thank you so much! I greatly appreciate it!

Tomorrow (May 14) is the M5 cutoff date. As project leads (PL), Kai/Shu will need to send an email to the release mailing list to report M5 status. If you do not subscribe to the release mailing list, you may not have seen others' email. I can forward an email to you in this case.

I wonder if the PL think we should have a sync up meeting tomorrow morning US ET (say 8:30 am ET, which is 8:30 pm China), to resolve last-minute issues. I am available at the said time.

Thank you so much! 

Richard



--
Richard


Re: M5 of alto in ODL?

Gao Kai <gaok12@...>
 

Agreed.

BTW Where can we see the requirements for M5? I'd like to check the list.

On 14/05/15 06:17, Y. Richard Yang wrote:

Dear team,

My apologies for being quiet in the last few days. I did check and saw that you guys are making good process! Thank you so much! I greatly appreciate it!

Tomorrow (May 14) is the M5 cutoff date. As project leads (PL), Kai/Shu will need to send an email to the release mailing list to report M5 status. If you do not subscribe to the release mailing list, you may not have seen others' email. I can forward an email to you in this case.

I wonder if the PL think we should have a sync up meeting tomorrow morning US ET (say 8:30 am ET, which is 8:30 pm China), to resolve last-minute issues. I am available at the said time.

Thank you so much! 

Richard



--
Richard


Re: M5 of alto in ODL?

Y. Richard Yang
 

On Wednesday, May 13, 2015, Gao Kai <gaok12@...> wrote:
Agreed.

BTW Where can we see the requirements for M5? I'd like to check the list.

On 14/05/15 06:17, Y. Richard Yang wrote:
Dear team,

My apologies for being quiet in the last few days. I did check and saw that you guys are making good process! Thank you so much! I greatly appreciate it!

Tomorrow (May 14) is the M5 cutoff date. As project leads (PL), Kai/Shu will need to send an email to the release mailing list to report M5 status. If you do not subscribe to the release mailing list, you may not have seen others' email. I can forward an email to you in this case.

I wonder if the PL think we should have a sync up meeting tomorrow morning US ET (say 8:30 am ET, which is 8:30 pm China), to resolve last-minute issues. I am available at the said time.

Thank you so much! 

Richard



--
Richard



--
Richard


[release] [Reminder for offset 2 projects] M5 status will be due on May 14, Thursday

Y. Richard Yang
 

Dear team,

Here is the template.

Richard 

---------- Forwarded message ----------
From: George Zhao <George.Y.Zhao@...>
Date: Monday, May 11, 2015
Subject: [release] [Reminder for offset 2 projects] M5 status will be due on May 14, Thursday
To: "release@..." <release@...>


 

 

Template:

 

0, Any issue testing with Karaf 3.0.3 (Not tested/Tested No issue/list of issues)

1, Code Freeze has been met (i.e. only bug fixes is allowed from now on)  Yes/No

2, Stability branch (stable/lithium) is cut and local project versions bumped on master complete.  Yes/No

 

        a)     Please provide gerrit patch URL for version bump.

3, String Freeze (all externally visible strings frozen to allow for translation & documentation)  Yes/No

4, Documentation complete. (Only editing and enhancing should take place after this point) Yes/No

 

        a)     Please provide github location URL for documentations, if your document status in [0] is not merged or under review

5, Integration & System test

 

        a)     Each user-facing feature system test complete Yes/No

 

        b)    Test run on code merge, upstream project code merge, release weekly Yes/No  (Please provide a merge job link)

 

 

[0] https://docs.google.com/spreadsheets/d/1KPpO9LH539Vlcoa4RvLa6PPCdLifi5JD-ihRhlybqeo/edit#gid=928464648




--
Richard


Re: M5 of alto in ODL?

dongshu
 

Yeah, let's do a sync up at the said time. 

And sorry for that I didn't involved too much in it this week since I'm preparing my tomorrow's Visa appointment. There are tons of materials to be done : ( Actually, most of the work is done by Gao Kai. Thank you so much Kai! 

On Thu, May 14, 2015 at 9:54 AM, Y. Richard Yang <yry@...> wrote:
Hi Kai,

The requirements are here:

Richard

On Wednesday, May 13, 2015, Gao Kai <gaok12@...> wrote:
Agreed.

BTW Where can we see the requirements for M5? I'd like to check the list.

On 14/05/15 06:17, Y. Richard Yang wrote:
Dear team,

My apologies for being quiet in the last few days. I did check and saw that you guys are making good process! Thank you so much! I greatly appreciate it!

Tomorrow (May 14) is the M5 cutoff date. As project leads (PL), Kai/Shu will need to send an email to the release mailing list to report M5 status. If you do not subscribe to the release mailing list, you may not have seen others' email. I can forward an email to you in this case.

I wonder if the PL think we should have a sync up meeting tomorrow morning US ET (say 8:30 am ET, which is 8:30 pm China), to resolve last-minute issues. I am available at the said time.

Thank you so much! 

Richard



--
Richard



--
Richard


Re: M5 of alto in ODL?

Gao Kai
 

Hi Shu,

Don't worry and take your time. I'll be working on the M5 stuff today.

And Richard,

The deadline is actually tomorrow noon in China, right?

On 14/05/15 10:36, 董舒 wrote:

Yeah, let's do a sync up at the said time. 

And sorry for that I didn't involved too much in it this week since I'm preparing my tomorrow's Visa appointment. There are tons of materials to be done : ( Actually, most of the work is done by Gao Kai. Thank you so much Kai! 

On Thu, May 14, 2015 at 9:54 AM, Y. Richard Yang <yry@...> wrote:
Hi Kai,

The requirements are here:

Richard

On Wednesday, May 13, 2015, Gao Kai <gaok12@...> wrote:
Agreed.

BTW Where can we see the requirements for M5? I'd like to check the list.

On 14/05/15 06:17, Y. Richard Yang wrote:
Dear team,

My apologies for being quiet in the last few days. I did check and saw that you guys are making good process! Thank you so much! I greatly appreciate it!

Tomorrow (May 14) is the M5 cutoff date. As project leads (PL), Kai/Shu will need to send an email to the release mailing list to report M5 status. If you do not subscribe to the release mailing list, you may not have seen others' email. I can forward an email to you in this case.

I wonder if the PL think we should have a sync up meeting tomorrow morning US ET (say 8:30 am ET, which is 8:30 pm China), to resolve last-minute issues. I am available at the said time.

Thank you so much! 

Richard



--
Richard



--
Richard



_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev


Re: M5 of alto in ODL?

Y. Richard Yang
 

Hi Kai,

Yes. It is US time, I believe. Hence, I see no problem sending out tomorrow noon China time.

Talk to you soon.

Richard

On Wed, May 13, 2015 at 10:43 PM, Gao Kai <godrickk@...> wrote:
Hi Shu,

Don't worry and take your time. I'll be working on the M5 stuff today.

And Richard,

The deadline is actually tomorrow noon in China, right?

On 14/05/15 10:36, 董舒 wrote:
Yeah, let's do a sync up at the said time. 

And sorry for that I didn't involved too much in it this week since I'm preparing my tomorrow's Visa appointment. There are tons of materials to be done : ( Actually, most of the work is done by Gao Kai. Thank you so much Kai! 

On Thu, May 14, 2015 at 9:54 AM, Y. Richard Yang <yry@...> wrote:
Hi Kai,

The requirements are here:

Richard

On Wednesday, May 13, 2015, Gao Kai <gaok12@...> wrote:
Agreed.

BTW Where can we see the requirements for M5? I'd like to check the list.

On 14/05/15 06:17, Y. Richard Yang wrote:
Dear team,

My apologies for being quiet in the last few days. I did check and saw that you guys are making good process! Thank you so much! I greatly appreciate it!

Tomorrow (May 14) is the M5 cutoff date. As project leads (PL), Kai/Shu will need to send an email to the release mailing list to report M5 status. If you do not subscribe to the release mailing list, you may not have seen others' email. I can forward an email to you in this case.

I wonder if the PL think we should have a sync up meeting tomorrow morning US ET (say 8:30 am ET, which is 8:30 pm China), to resolve last-minute issues. I am available at the said time.

Thank you so much! 

Richard



--
Richard



--
Richard



_______________________________________________
alto-dev mailing list
alto-dev@...
https://lists.opendaylight.org/mailman/listinfo/alto-dev


Change in docs[master]: Documentation outline for ALTO

Y. Richard Yang
 

Dear team,

The previous draft doc is under review.

---------- Forwarded message ----------
From: Gerrit Code Review <gerrit@...>
Date: Wed, Apr 22, 2015 at 3:26 PM
Subject: Change in docs[master]: Documentation outline for ALTO
To: "Y. Richard Yang" <yry@...>
Cc: jenkins-releng <jenkins-releng@...>


From Colin Dixon <colin@...>:

Colin Dixon has posted comments on this change.

Change subject: Documentation outline for ALTO
......................................................................


Patch Set 1: Code-Review-1

(12 comments)

https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opendaylight.org_gerrit_-23_c_18389_1_manuals_developer-2Dguide_src_main_asciidoc_alto_odl-2Dalto-2Ddev.adoc&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=D35NWM92fBUnkmeSyaLexFvNuCmT4NwscKmztd5pU_E&e=
File manuals/developer-guide/src/main/asciidoc/alto/odl-alto-dev.adoc:

Line 4: (1) a northbound interface based on RFC7285 to provide ALTO services
      : to ALTO clients; and (2) an ALTO manager so that a network administrator can
      : provision the data of the services.
call these out as bullets by putting a period-space in front of them and putting them on their own line?


Line 18: OpenDayLight
OpenDaylight


https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opendaylight.org_gerrit_-23_c_18389_1_manuals_install-2Dguide_src_main_asciidoc_alto_alto-2Dinstall.adoc&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=LuHNUoEXeIEJPzhA7kOOGCtaJEEW3zpthA1PkYrK1hk&e=
File manuals/install-guide/src/main/asciidoc/alto/alto-install.adoc:

In general if all that's required for installation is installing features, we just put that together in one big table rather than requiring each project list pretty much exactly the same information.


https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opendaylight.org_gerrit_-23_c_18389_1_manuals_user-2Dguide_src_main_asciidoc_alto_odl-2Dalto-2Duser.adoc&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=Yvx2v5V0Nb36VXvCPD5Gye9Hs6C6JyyoFIEEiUwfccE&e=
File manuals/user-guide/src/main/asciidoc/alto/odl-alto-user.adoc:

Line 1: == ALTO User Guide
Does it make sense to expand the ALTO acronym?


Line 2: northbound
what do you mean by northbound?


Line 3: user
section instead of user?


Line 2: ALTO
      : administrator
"an ALTO administrator"? or "ALTO administrators"?


Line 11: the
reachable at?


Line 11: OpenDayLight
OpenDaylight


Line 13: curl -u karaf:karaf -X GET -D - https://urldefense.proofpoint.com/v2/url?u=http-3A__localhost-3A8181_controller_nb_v2_alto_&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=GuQGl6NRLYSPEVvCB4hH2vxOL5aV-cA8ka6FDUbSn-0&e=
My guess is that you want this to be on its own line and thus you want a blank line before it. You might also put it in inside pluses (+) or put a space in front of it to get it to format in a fixed-width font.


Line 16: CI
expand the acronym?


Line 22: * [https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.opendaylight.org_mailman_listinfo_alto-2Ddev&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=3qhCzWQpO_tYa-hrvSlPodxt7JREw1Sgsz29jywm8yU&e=  alto-dev], a general developers list
This format is wiki syntax, not AsciiDoc, the AsciiDoc would be:

https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.opendaylight.org_mailman_listinfo_alto-2Ddev-5Balto-2Ddev&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=XIVkEA7DNBLcXnhOyxPEmaU0hxCprEgSbuUJEWey4tc&e= ]


--
To view, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opendaylight.org_gerrit_18389&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=S9cuOJYt1voEA3jNbvXvy8zOnQgG-kNajJFmEii2kAw&e=
To unsubscribe, visit https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opendaylight.org_gerrit_settings&d=AwIDaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=aUmHoN4pOkfQQEnvVkjF-WbjB1qrcjgllVXxWsJTGvk&s=1OOh-HcQ3PyRlFQM-j5FcvBDv2F3wkKwlO7uU7YR_sQ&e=

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fbe435b5fdf541d47119a512b664ae618b54416
Gerrit-PatchSet: 1
Gerrit-Project: docs
Gerrit-Branch: master
Gerrit-Owner: Y. Richard Yang <yry@...>
Gerrit-Reviewer: Colin Dixon <colin@...>
Gerrit-Reviewer: jenkins-releng <jenkins-releng@...>
Gerrit-HasComments: Yes



--
-- 
 =====================================
| Y. Richard Yang <yry@...>   |
| Professor of Computer Science       |
 =====================================


Re: [alto] ALTO implementation interoperability

Y. Richard Yang
 

A good starting point. I added the alto-dev mailing list on opendaylight. The team there has test cases to test the correctness of their alto server in ODL.

Richard


On Tuesday, May 12, 2015, Huaming Guo郭华明 <guohuaming@...> wrote:
Hi Wendy, all,



I think we can first go through a list of all test cases, then we complete all details.

I post the list below. The cases with * are added or updated by me. I also like to

serve an editor, if possible.



1. Information Resource Directory

 1.1 Test-IRD-1:  The Information Resource Directory (IRD) enumerates URIs

      at which an ALTO server offers Information Resources.

 *1.2 Test-IRD-2 ALTO server delegate IRD to a subdomain.



2. Map Service

 2.1 Test-MAPS-1:   An ALTO client retrieves a complete network map.

 2.2 Test-MAPS-2:   An ALTO client retrieves a complete cost map for the

      numerical cost mode.

 2.3 Test-MAPS-3:   An ALTO client retrieves a complete cost map for the

      ordinal cost mode.

 2.4 Test-MAPS-4:   This test is designed to detect a change in the

      network map.



3. Map-Filtering Service

 *3.1 Test-FILTER-1:   An ALTO client sends a request to get a filtered network map

      of PID mypid2.

 *3.2 Test-FILTER-2:   An ALTO client sends a request to get a filtered cost map

      from a source PID to a set of destination PIDs.

 *3.3 Test-FILTER-3:   An ALTO client requests the cost map subject to

      certain constraints.



4. Endpoint Property Service

 4.1 Test-EPS-1:   An ALTO client retrieves a PID for IPv4 address

      192.168.1.23.

 4.2 Test-EPS-2:   An ALTO client retrieves a PID for IPv4 address

      192.168.10.23.

 4.3 Test-EPS-3:   An ALTO client retrieves a PID for IPv4 address

      201.1.13.12.

 4.4 Test-EPS-4:   An ALTO client retrieves a PID for an IPv4 and IPv6

      address.

 *4.5 Test-EPS-5: An ALTO client retrieves a Private Endpoint Property for an IPv4

      address.



5. Endpoint Cost Service

 5.1 Test-ECS-1:   An ALTO client requests cost information between

      individual endpoints.

 5.2 Test-ECS-2:   An ALTO client requests the ranking service for a

      source host to a set of destination hosts.

 5.3 Test-ECS-3:   An ALTO client requests the cost service subject to

      certain constraints.



6. Protocol Errors

 *6.1 Test-ERR-1:   An ALTO client sends a malformed JSON body in the

      request --- a missing closing brace ('}'). (E_SYNTAX)

 *6.2 Test-ERR-2:   An ALTO client sends a malformed request --- the

      "dsts" member for the endpoint cost service is missing. (E_MISSING_FIELD)

 *6.3 Test-ERR-3:   An ALTO client sends a request with an unexpected

      type for a JSON value. (E_INVAILD_FIELD_TYPE)

 *6.4 Test-ERR-4:   An ALTO client sends a request with a wrong value for

      a correct field. (E_INVAILD_FIELD_VALUE)

 *6.5 Test-ERR-5:   An ALTO client sends a request with multiple

      errors.













> -----原始邮件-----

> 发件人: "Vijay K. Gurbani" <vkg@...>

> 发送时间: 2015-05-13 00:01:35 (星期三)

> 收件人: "郭华明" <guohuaming@...>

> 抄送: "Y. Richard Yang" <yry@...>, "IETF ALTO" <alto@...>

> 主题: Re: [alto] ALTO implementation interoperability

>

> On 05/11/2015 07:41 PM, 郭华明 wrote:

> > Dear Vijay, Richard,

> >

> > I am interested in this work. I will bring the test cases soon.

>

> Excellent.  Please coordinate with the editors of the document with

> regard to bringing new test cases.

>

> Thanks for your time on this!

>

> Cheers,

>

> - vijay

> --

> Vijay K. Gurbani, Bell Laboratories, Alcatel-Lucent

> 1960 Lucent Lane, Rm. 9C-533, Naperville, Illinois 60563 (USA)

> Email: vkg@{bell-labs.com,acm.org} / vijay.gurbani@...

> Web: https://urldefense.proofpoint.com/v2/url?u=http-3A__ect.bell-2Dlabs.com_who_vkg_&d=AwIGaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=6h5yxyhxHTpCCwoZgmUqgGPoEl0VjBvG-QUM7wa8LTc&s=DkqHFvN8f463jbMtPlk51Ik2KCYpj3GA5ijiYZrxPXk&e=   | Calendar: https://urldefense.proofpoint.com/v2/url?u=http-3A__goo.gl_x3Ogq&d=AwIGaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4G36iiEVb2m_v-0RnP2gx9KZJjYQgfvrOCE3789JGIA&m=6h5yxyhxHTpCCwoZgmUqgGPoEl0VjBvG-QUM7wa8LTc&s=w302JfJ6Hg8_t-g1qcHO9XrAdCmuiD00QoI_kIn3M-M&e=





--

----------------

Best!









Huaming Guo





China Academy of Information and Communications Technology (CAICT)





No.36 A Nanlishi Road, Xicheng District, Beijing 100037, China



--
Richard


[release]ALTO M5 Status

Gao Kai
 

1. Code Freeze (bug fixes only from here as defined above)
Yes

2. Stability branch, i.e., stable/lithium, must be cut and local project versions bumped on master to avoid overwriting lithium SNAPSHOTS
Stability branch has been cut.
Version has been bumped on master: https://git.opendaylight.org/gerrit/#/c/20468/

3. String Freeze (all externally visible strings frozen to allow for translation & documentation)
Yes

4. Documentation Complete: Only editing and and enhancing should take place after this point.
Yes, https://git.opendaylight.org/gerrit/20475

5. Integration & System Test
Features: https://git.opendaylight.org/gerrit/#/c/20383/
Test suites for
odl-alto-provider and odl-alto-hosttracker feature: https://git.opendaylight.org/gerrit/#/c/20455/

61 - 80 of 542