Neutron code review


Abhijit Kumbhare <abhijitkoss@...>
 

Hi Achuth,

Robert requested the code review for the outstanding Neutron code patches:


I think the old patches from 2018 and earlier are less of a priority than the ones from this year. Since you are not a committer, you will not be able to merge them, but you can definitely review them.

Thanks,
Abhijit


Abhijit Kumbhare <abhijitkoss@...>
 

Hi Achuth,

Since you are now a Neutron committer, you should be able to start reviewing and then merging the patches once you have your committer rights assigned from helpdesk rather than us needing to have Robert or Anil use super committer powers to merge Robert's patches.

Regards,
Abhijit


On Thu, Oct 31, 2019 at 10:17 AM Abhijit Kumbhare <abhijitkoss@...> wrote:
Hi Achuth,

Robert requested the code review for the outstanding Neutron code patches:


I think the old patches from 2018 and earlier are less of a priority than the ones from this year. Since you are not a committer, you will not be able to merge them, but you can definitely review them.

Thanks,
Abhijit


Abhijit Kumbhare <abhijitkoss@...>
 

Great, thanks for the update.

On Sat, Nov 9, 2019 at 9:00 PM Achuth Maniyedath <achuth.m@...> wrote:

Hi Abhijit

 

Thanks,  I am reviewing some of the patches open already

Will continue working on the other patches as well

 

Thanks

Achuth

 

 

 

From: Abhijit Kumbhare <abhijitkoss@...>
Sent: Saturday, November 9, 2019 6:34 AM
To: ODL neutron dev <neutron-dev@...>; Achuth Maniyedath <achuth.m@...>; Robert Varga <nite@...>; Anil Belur <abelur@...>
Cc: Netvirt <netvirt-dev@...>
Subject: Re: Neutron code review

 

Hi Achuth,

 

Since you are now a Neutron committer, you should be able to start reviewing and then merging the patches once you have your committer rights assigned from helpdesk rather than us needing to have Robert or Anil use super committer powers to merge Robert's patches.

 

Regards,

Abhijit

 

 

On Thu, Oct 31, 2019 at 10:17 AM Abhijit Kumbhare <abhijitkoss@...> wrote:

Hi Achuth,

 

Robert requested the code review for the outstanding Neutron code patches:

 

 

I think the old patches from 2018 and earlier are less of a priority than the ones from this year. Since you are not a committer, you will not be able to merge them, but you can definitely review them.

 

Thanks,

Abhijit