Re: [integration-dev] [opendaylight-dev] openflow performance regression
|
Abhijit Kumbhare
Luis, In today's OF Plugin meeting Tony provided the info on this & the fix: [09:08:50] <ttkacik1> whole issue is in droptest itself [09:09:40] <abhijitkumbhare> Oh - but have there been any changes to droptest? [09:09:54] <ttkacik1> droptest was using MD-SAL threads even if it is explicitly docuemnted in javadocs for MD-SAL Notifcation APIs to do not any work which may take time
[09:10:48] <abhijitkumbhare> so someone needs to change drop test [09:10:53] <ttkacik1> patch which dropped performance was announced to mailing lists before: https://lists.opendaylight.org/pipermail/openflowplugin-dev/2015-May/003022.html [09:11:08] <ttkacik1> even points to patch [09:11:30] <abhijitkumbhare> OK [09:11:54] <ttkacik1> which changed bit behavior of notif. broker impl but not API contractz [09:12:11] <ttkacik1> which showed that droptest was stealing MD-SAL threads to do its work [09:12:19] <ttkacik1> that is why perf. dropped [09:12:40] <ttkacik1> now notification broker makes sure none of the listener is invoked from multiple threads at same time [09:12:51] <abhijitkumbhare> so someone needs to change drop test to work better with the lithium notification broker [09:13:10] <abhijitkumbhare> right? [09:13:29] <ttkacik1> and that was implementation specific behaviour on which droptest relies [09:13:38] <ttkacik1> I pushed initial fix to droptest as of now [09:14:12] <abhijitkumbhare> OK - good [09:14:37] <jamoluhrsen> #info https://git.opendaylight.org/gerrit/#/c/19717/ is Tony's drop-test patch [09:14:39] <ttkacik1> https://git.opendaylight.org/gerrit/#/c/19717/ [09:14:46] <michal_rehak> testing the patch right now [09:15:21] <abhijitkumbhare> OK [09:15:22] <michal_rehak> looks like it improves throughput in He-codebase of ofPlugin 3 times [09:16:03] <michal_rehak> merged Thanks, Abhijit On Wed, May 6, 2015 at 9:20 AM, Luis Gomez <ecelgp@...> wrote:
|
|
|