Query on ConnectionAdapterImpl


Michal Polkorab
 

Hello Giuseppe,


there is a reason behind this implementation. MultipartReply messages are RPCs, but there can be multiple of them delivered from switch to controller (eg.

OFPMPF_REPLY_* flags).

If those were strictly paired with MultipartRequest message, then the first MultipartReply message would consume the relevant / corresponding MultipartRequest future and the next one (with the same XID) could be paired with no future. Openflowplugin project implements a mechanism for multipart request <-> reply mapping.


Regards,

Michal


From: Petralia, GiuseppeX <giuseppex.petralia@...>
Sent: 19 November 2015 18:36
To: 'openflowjava-dev@...'
Subject: [openflowjava-dev] Query on ConnectionAdapterImpl
 

Hi all,

 

I am working with the ConnectionAdapterImpl

(https://github.com/opendaylight/openflowjava/blob/master/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImpl.java)

 

I can’t understand why the multipartRequest method return an object of type Future<RpcResult<Void>> instead of  Future<RpcResult<MultiparReplyMessage>>  as happens for all the methods related to messages that have a reply.

 

public Future<RpcResult<Void>> multipartRequest(final MultipartRequestInput input)

 

Is that any reason for that or is it a bug?

 

 

Thank you for your help.

 

Best,

Giuseppe Petralia

 

 

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

MichalPolkoráb

Software Engineer


Sídlo Mlynské Nivy 56 / 821 05 Bratislava / Slovakia
R&D centrum 
Janka Kráľa 9 /  974 01 Banská Bystrica Slovakia
+421 918 378 907 / michal.polkorab@...
reception: +421 2 206 65 114 / www.pantheon.sk

logo

 


Petralia, GiuseppeX <giuseppex.petralia@...>
 

Hi all,

 

I am working with the ConnectionAdapterImpl

(https://github.com/opendaylight/openflowjava/blob/master/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/connection/ConnectionAdapterImpl.java)

 

I can’t understand why the multipartRequest method return an object of type Future<RpcResult<Void>> instead of  Future<RpcResult<MultiparReplyMessage>>  as happens for all the methods related to messages that have a reply.

 

public Future<RpcResult<Void>> multipartRequest(final MultipartRequestInput input)

 

Is that any reason for that or is it a bug?

 

 

Thank you for your help.

 

Best,

Giuseppe Petralia

 

 

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.