z.archive.openflowjava-dev@lists.opendaylight.org | Regression detected

Home Messages Hashtags Subgroups

This group is locked. No changes can be made to the group while it is locked.

Date Date 1 - 7 of 7

Regression detected

Luis Gomez <ecelgp@...> #627 But also, can anyone in vtn explain the consequences of not applying this patch? the reason is this seems like the ovs 2.0 discussion last release: we do something right in the code that breaks popular switch connectivity, and CPqD is not as popular as OVS but still. I am also cc-ing memo project because they have recently showed interest in using CPqD for their system test, and this will impact them. BR/Luis toggle quoted message Show quoted text On Feb 5, 2016, at 3:38 PM, Luis Gomez <ecelgp@...> wrote: I can take care of the robot test. On Feb 5, 2016, at 6:48 AM, Michal Polkoráb <michal.polkorab@...> wrote: Robot tests (robot setups) should know which switch they are using. CPqD switches should be used only when testing groups - as far as I know. Unfortunately, I won't do the change as it is out of my scope. Michal From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 15:36 To: Michal Polkoráb Cc: Luis Gomez; openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected For the first solution: 1. introduce timeout / sleep in testcases with CPqD switches, How do you know if we are connecting to a CPqD switch and not any other kind of switch? It will be important to be able to keep working with CPqD switch as it would be good to be able to work with multiple switches. So will you do the timeout change Michal? On Fri, Feb 5, 2016 at 5:43 AM, Michal Polkoráb <michal.polkorab@...> wrote: Hello, the change that causes the problems is this one: https://git.opendaylight.org/gerrit/#/c/33906/. It fixes Bug 4614 (https://bugs.opendaylight.org/show_bug.cgi?id=4614). We have tested the change with both OVS and CPqD switches and both passed. The XID (see the change) wasn't used because CPqD switch didn't fully behave according to the specification (didn't reply with correct XID) - and as it turns out, it still doesn't. The first connection usually replies with random generated XID in features-reply, after we close the connection (approx. 30 seconds), the device connects successfully. So our options are: 1. introduce timeout / sleep in testcases with CPqD switches, 2. replace CPqD switches with OVS switches (since OVS 2.3 - groups are supported). Regards, Michal Polkorab From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 01:24 To: Luis Gomez Cc: openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected Thanks Luis. May be better to wait for Michal Polkorab to comment. On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez <ecelgp@...> wrote: Hi OFP devs, It looks like this patch: https://git.opendaylight.org/gerrit/#/c/33652/ broke CPqD switch support in both plugins: https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/ https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/ BR/Luis _______________________________________________ openflowjava-dev mailing list openflowjava-dev@... https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk
Luis Gomez <ecelgp@...> #626 I can take care of the robot test. toggle quoted message Show quoted text On Feb 5, 2016, at 6:48 AM, Michal Polkoráb <michal.polkorab@...> wrote: Robot tests (robot setups) should know which switch they are using. CPqD switches should be used only when testing groups - as far as I know. Unfortunately, I won't do the change as it is out of my scope. Michal From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 15:36 To: Michal Polkoráb Cc: Luis Gomez; openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected For the first solution: 1. introduce timeout / sleep in testcases with CPqD switches, How do you know if we are connecting to a CPqD switch and not any other kind of switch? It will be important to be able to keep working with CPqD switch as it would be good to be able to work with multiple switches. So will you do the timeout change Michal? On Fri, Feb 5, 2016 at 5:43 AM, Michal Polkoráb <michal.polkorab@...> wrote: Hello, the change that causes the problems is this one: https://git.opendaylight.org/gerrit/#/c/33906/. It fixes Bug 4614 (https://bugs.opendaylight.org/show_bug.cgi?id=4614). We have tested the change with both OVS and CPqD switches and both passed. The XID (see the change) wasn't used because CPqD switch didn't fully behave according to the specification (didn't reply with correct XID) - and as it turns out, it still doesn't. The first connection usually replies with random generated XID in features-reply, after we close the connection (approx. 30 seconds), the device connects successfully. So our options are: 1. introduce timeout / sleep in testcases with CPqD switches, 2. replace CPqD switches with OVS switches (since OVS 2.3 - groups are supported). Regards, Michal Polkorab From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 01:24 To: Luis Gomez Cc: openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected Thanks Luis. May be better to wait for Michal Polkorab to comment. On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez <ecelgp@...> wrote: Hi OFP devs, It looks like this patch: https://git.opendaylight.org/gerrit/#/c/33652/ broke CPqD switch support in both plugins: https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/ https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/ BR/Luis _______________________________________________ openflowjava-dev mailing list openflowjava-dev@... https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk
Michal Polkorab #625 Robot tests (robot setups) should know which switch they are using. CPqD switches should be used only when testing groups - as far as I know. Unfortunately, I won't do the change as it is out of my scope. Michal toggle quoted message Show quoted text From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 15:36 To: Michal Polkoráb Cc: Luis Gomez; openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected For the first solution: 1. introduce timeout / sleep in testcases with CPqD switches, How do you know if we are connecting to a CPqD switch and not any other kind of switch? It will be important to be able to keep working with CPqD switch as it would be good to be able to work with multiple switches. So will you do the timeout change Michal? On Fri, Feb 5, 2016 at 5:43 AM, Michal Polkoráb <michal.polkorab@...> wrote: Hello, the change that causes the problems is this one: https://git.opendaylight.org/gerrit/#/c/33906/. It fixes Bug 4614 (https://bugs.opendaylight.org/show_bug.cgi?id=4614). We have tested the change with both OVS and CPqD switches and both passed. The XID (see the change) wasn't used because CPqD switch didn't fully behave according to the specification (didn't reply with correct XID) - and as it turns out, it still doesn't. The first connection usually replies with random generated XID in features-reply, after we close the connection (approx. 30 seconds), the device connects successfully. So our options are: 1. introduce timeout / sleep in testcases with CPqD switches, 2. replace CPqD switches with OVS switches (since OVS 2.3 - groups are supported). Regards, Michal Polkorab From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 01:24 To: Luis Gomez Cc: openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected Thanks Luis. May be better to wait for Michal Polkorab to comment. On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez <ecelgp@...> wrote: Hi OFP devs, It looks like this patch: https://git.opendaylight.org/gerrit/#/c/33652/ broke CPqD switch support in both plugins: https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/ https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/ BR/Luis _______________________________________________ openflowjava-dev mailing list openflowjava-dev@... https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk
Abhijit Kumbhare #624 For the first solution: 1. introduce timeout / sleep in testcases with CPqD switches, How do you know if we are connecting to a CPqD switch and not any other kind of switch? It will be important to be able to keep working with CPqD switch as it would be good to be able to work with multiple switches. So will you do the timeout change Michal? toggle quoted message Show quoted text On Fri, Feb 5, 2016 at 5:43 AM, Michal Polkoráb <michal.polkorab@...> wrote: Hello, the change that causes the problems is this one: https://git.opendaylight.org/gerrit/#/c/33906/. It fixes Bug 4614 (https://bugs.opendaylight.org/show_bug.cgi?id=4614). We have tested the change with both OVS and CPqD switches and both passed. The XID (see the change) wasn't used because CPqD switch didn't fully behave according to the specification (didn't reply with correct XID) - and as it turns out, it still doesn't. The first connection usually replies with random generated XID in features-reply, after we close the connection (approx. 30 seconds), the device connects successfully. So our options are: 1. introduce timeout / sleep in testcases with CPqD switches, 2. replace CPqD switches with OVS switches (since OVS 2.3 - groups are supported). Regards, Michal Polkorab From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 01:24 To: Luis Gomez Cc: openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected Thanks Luis. May be better to wait for Michal Polkorab to comment. On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez <ecelgp@...> wrote: Hi OFP devs, It looks like this patch: https://git.opendaylight.org/gerrit/#/c/33652/ broke CPqD switch support in both plugins: https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/ https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/ BR/Luis _______________________________________________ openflowjava-dev mailing list openflowjava-dev@... https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk
Michal Polkorab #623 Hello, the change that causes the problems is this one: https://git.opendaylight.org/gerrit/#/c/33906/. It fixes Bug 4614 (https://bugs.opendaylight.org/show_bug.cgi?id=4614). We have tested the change with both OVS and CPqD switches and both passed. The XID (see the change) wasn't used because CPqD switch didn't fully behave according to the specification (didn't reply with correct XID) - and as it turns out, it still doesn't. The first connection usually replies with random generated XID in features-reply, after we close the connection (approx. 30 seconds), the device connects successfully. So our options are: 1. introduce timeout / sleep in testcases with CPqD switches, 2. replace CPqD switches with OVS switches (since OVS 2.3 - groups are supported). Regards, Michal Polkorab toggle quoted message Show quoted text From: Abhijit Kumbhare <abhijitkoss@...> Sent: 05 February 2016 01:24 To: Luis Gomez Cc: openflowjava-dev; openflowplugin-dev Subject: Re: [openflowjava-dev] Regression detected Thanks Luis. May be better to wait for Michal Polkorab to comment. On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez <ecelgp@...> wrote: Hi OFP devs, It looks like this patch: https://git.opendaylight.org/gerrit/#/c/33652/ broke CPqD switch support in both plugins: https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/ https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/ BR/Luis _______________________________________________ openflowjava-dev mailing list openflowjava-dev@... https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev MichalPolkoráb Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 918 378 907 / michal.polkorab@... reception: +421 2 206 65 114 / www.pantheon.sk
Abhijit Kumbhare #622 Thanks Luis. May be better to wait for Michal Polkorab to comment. toggle quoted message Show quoted text On Thu, Feb 4, 2016 at 4:08 PM, Luis Gomez <ecelgp@...> wrote: Hi OFP devs, It looks like this patch: https://git.opendaylight.org/gerrit/#/c/33652/ broke CPqD switch support in both plugins: https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/ https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/ BR/Luis _______________________________________________ openflowjava-dev mailing list openflowjava-dev@... https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev
Luis Gomez <ecelgp@...> #621 Hi OFP devs, It looks like this patch: https://git.opendaylight.org/gerrit/#/c/33652/ broke CPqD switch support in both plugins: https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-only-beryllium/ https://jenkins.opendaylight.org/releng/view/openflowplugin/job/openflowplugin-csit-1node-flow-services-lithium-redesign-only-beryllium/ BR/Luis

1 - 7 of 7

1

Previous Topic Next Topic

Home Hashtags Subgroups Terms