OpenFlow broken in master


Luis Gomez <ecelgp@...>
 

It seems the blueprint patches for openflowjava:


broke the openflowplugin project and all projects depending on OpenFlow:

2016-06-02 09:37:46,379 | ERROR | config-pusher    | ConfigRegistryImpl               | 121 - org.opendaylight.controller.config-manager - 0.5.0.SNAPSHOT | Configuration Transaction failed on 2PC, server is unhealthy
java.lang.IllegalStateException: Error - getInstance() failed for ModuleIdentifier{factoryName='openflow-plugin-provider-impl', instanceName='openflow-plugin-provider-impl'} in transaction TransactionIdentifier{name='ConfigTransaction-68-70'}

I am still investigating why the distribution-check job did not catch this.

BR/Luis


Luis Gomez <ecelgp@...>
 

The distribution-check job is designed to fail when it sees a failure like the one I sent in my previous mail but this ERROR message did not show when we loaded all the features like we do in the distribution-check, instead we see these WARN messages indicating the issue but not failing the distribution-check:

2016-06-01 08:20:55,771 | WARN  | ction-291-293'}} | DeadlockMonitor                  | 113 - org.opendaylight.controller.config-manager - 0.5.0.SNAPSHOT | ModuleIdentifier{factoryName='openflow-switch-connection-provider-impl', instanceName='openflow-switch-connection-provider-default-impl'} did not finish after 174947 ms
BR/Luis


On Jun 2, 2016, at 2:11 PM, Luis Gomez <ecelgp@...> wrote:

It seems the blueprint patches for openflowjava:


broke the openflowplugin project and all projects depending on OpenFlow:

2016-06-02 09:37:46,379 | ERROR | config-pusher    | ConfigRegistryImpl               | 121 - org.opendaylight.controller.config-manager - 0.5.0.SNAPSHOT | Configuration Transaction failed on 2PC, server is unhealthy
java.lang.IllegalStateException: Error - getInstance() failed for ModuleIdentifier{factoryName='openflow-plugin-provider-impl', instanceName='openflow-plugin-provider-impl'} in transaction TransactionIdentifier{name='ConfigTransaction-68-70'}

I am still investigating why the distribution-check job did not catch this.

BR/Luis



Anil Vishnoi
 

Hi Luis,

Following patch should not be merge, It needs to be merge with few openflowplugin patches. Can you locally revert this patch and test it distribution builds fine.


Thanks
Anil

On Thu, Jun 2, 2016 at 2:26 PM, Luis Gomez <ecelgp@...> wrote:
The distribution-check job is designed to fail when it sees a failure like the one I sent in my previous mail but this ERROR message did not show when we loaded all the features like we do in the distribution-check, instead we see these WARN messages indicating the issue but not failing the distribution-check:

2016-06-01 08:20:55,771 | WARN  | ction-291-293'}} | DeadlockMonitor                  | 113 - org.opendaylight.controller.config-manager - 0.5.0.SNAPSHOT | ModuleIdentifier{factoryName='openflow-switch-connection-provider-impl', instanceName='openflow-switch-connection-provider-default-impl'} did not finish after 174947 ms
BR/Luis


On Jun 2, 2016, at 2:11 PM, Luis Gomez <ecelgp@...> wrote:

It seems the blueprint patches for openflowjava:


broke the openflowplugin project and all projects depending on OpenFlow:

2016-06-02 09:37:46,379 | ERROR | config-pusher    | ConfigRegistryImpl               | 121 - org.opendaylight.controller.config-manager - 0.5.0.SNAPSHOT | Configuration Transaction failed on 2PC, server is unhealthy
java.lang.IllegalStateException: Error - getInstance() failed for ModuleIdentifier{factoryName='openflow-plugin-provider-impl', instanceName='openflow-plugin-provider-impl'} in transaction TransactionIdentifier{name='ConfigTransaction-68-70'}

I am still investigating why the distribution-check job did not catch this.

BR/Luis



_______________________________________________
openflowjava-dev mailing list
openflowjava-dev@...
https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev




--
Thanks
Anil


Luis Gomez <ecelgp@...>
 

Yes, I reverted and verified it fixes the distribution:


BR/Luis


On Jun 2, 2016, at 2:59 PM, Anil Vishnoi <vishnoianil@...> wrote:

Hi Luis,

Following patch should not be merge, It needs to be merge with few openflowplugin patches. Can you locally revert this patch and test it distribution builds fine.


Thanks
Anil

On Thu, Jun 2, 2016 at 2:26 PM, Luis Gomez <ecelgp@...> wrote:
The distribution-check job is designed to fail when it sees a failure like the one I sent in my previous mail but this ERROR message did not show when we loaded all the features like we do in the distribution-check, instead we see these WARN messages indicating the issue but not failing the distribution-check:

2016-06-01 08:20:55,771 | WARN  | ction-291-293'}} | DeadlockMonitor                  | 113 - org.opendaylight.controller.config-manager - 0.5.0.SNAPSHOT | ModuleIdentifier{factoryName='openflow-switch-connection-provider-impl', instanceName='openflow-switch-connection-provider-default-impl'} did not finish after 174947 ms
BR/Luis


On Jun 2, 2016, at 2:11 PM, Luis Gomez <ecelgp@...> wrote:

It seems the blueprint patches for openflowjava:


broke the openflowplugin project and all projects depending on OpenFlow:

2016-06-02 09:37:46,379 | ERROR | config-pusher    | ConfigRegistryImpl               | 121 - org.opendaylight.controller.config-manager - 0.5.0.SNAPSHOT | Configuration Transaction failed on 2PC, server is unhealthy
java.lang.IllegalStateException: Error - getInstance() failed for ModuleIdentifier{factoryName='openflow-plugin-provider-impl', instanceName='openflow-plugin-provider-impl'} in transaction TransactionIdentifier{name='ConfigTransaction-68-70'}

I am still investigating why the distribution-check job did not catch this.

BR/Luis



_______________________________________________
openflowjava-dev mailing list
openflowjava-dev@...
https://lists.opendaylight.org/mailman/listinfo/openflowjava-dev




--
Thanks
Anil