Extensibility support - actions needed from OVSDB team
|
Abhijit Kumbhare
We had a daily scrum meeting for the OpenFlow plugin project & here are the conclusions about extensibility support: 1) https://git.opendaylight.org/gerrit/#/c/9393/ - should give us extensions... pretty for actions, less pretty for matches. The users of the project (like OVSDB, SFC) need extensions. So we will go with what we have for Helium and make the matches pretty in Lithium.
2) The instructions to try out are at https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Backlog:Extensibility#Helpful_hints_for_reviewing_https:.2F.2Fgit.opendaylight.org.2Fgerrit.2F.23.2Fc.2F9393.2F.
3) We need the following to be reviewed & tried before tomorrow by OVSDB folks (Madhu / Brent or whoever is the right person). It will be great if Rob Adams also reviews it. From the OF plugin side the reviewers are - Ed, Prasanna, Jan Medved & Abhijit.
4) We would like the reviewers to join the OpenFlow plugin scrum meeting (over IRC) tomorrow - meeting details at: https://wiki.opendaylight.org/view/Meetings#OpenFlow_Plugin. Following the meeting if all is well - we will merge the code.
Thanks, Abhijit
|
|
|
|
Rob Adams <readams@...>
I've already implemented my functionality off of the unmerged tree (and added additional work on top to make OUTPUT_REG and group table actions work). The API is definitely not pretty but it works. -Rob
On Wed, Aug 6, 2014 at 9:09 AM, Abhijit Kumbhare <abhijitkoss@...> wrote:
|
|
|
|
Rob Adams <readams@...>
For examples on use:
On Wed, Aug 6, 2014 at 9:11 AM, Rob Adams <readams@...> wrote:
|
|
|
|
Abhijit Kumbhare
Great! How about https://git.opendaylight.org/gerrit/#/c/9723/ ? Is that the change you need in the openflow plugin side while https://git.opendaylight.org/gerrit/#/c/9672/ is on the consumer of it side (GBP in this case)?
On Wed, Aug 6, 2014 at 9:12 AM, Rob Adams <readams@...> wrote:
|
|
|
|
Rob Adams <readams@...>
I need https://git.opendaylight.org/gerrit/#/c/9723/ and https://git.opendaylight.org/gerrit/#/c/9671 on the openflowplugin side. https://git.opendaylight.org/gerrit/#/c/9672/ is the GBP code that uses the extensions. Checkout especially FlowUtils.java for examples of using the extension API.
On Wed, Aug 6, 2014 at 9:14 AM, Abhijit Kumbhare <abhijitkoss@...> wrote:
|
|
|
|
Abhijit Kumbhare
OVSDB folks, Can anyone of you be able to join the 7 am Pacific meeting tomorrow? Thanks, Abhijit
|
|
|
|
Madhu Venugopal
Hi Abhijit, I won't be able to attend 7am PT meeting slots. I will anyway try the latest patches as suggested by Rob Adams later tonight and provide my input. I was facing issues with multiple actions last week when I was trying the framework. Hopefully they are all solved now. -Madhu
On Aug 6, 2014, at 6:31 PM, Abhijit Kumbhare <abhijitkoss@...> wrote:
|
|
|
|
Rob Adams <readams@...>
By the way if you want to use multiple actions, you need:
On Wed, Aug 6, 2014 at 6:44 PM, Madhu Venugopal <mavenugo@...> wrote:
|
|
|
|
Abhijit Kumbhare
Sure - email feedback is fine. Unfortunately the 7 am slot was the only slot that most folks on the team were OK with in the morning on a daily basis - and which did not clash with the other ODL meetings. Even the Tuesday 8 am OpenFlow plugin slot gives us a trouble as we frequently go into the MD-SAL call time slot (and causes some Webex issues for them).
On Wed, Aug 6, 2014 at 6:44 PM, Madhu Venugopal <mavenugo@...> wrote:
|
|
|
|
Madhu Venugopal
Thanks Rob. Appreciate your help. -Madhu
On Aug 6, 2014, at 6:46 PM, Rob Adams <readams@...> wrote:
|
|
|
|
Abhijit Kumbhare
Yes - thanks Rob! Also appreciate your quick feedback.
On Wed, Aug 6, 2014 at 6:55 PM, Madhu Venugopal <mavenugo@...> wrote:
|
|
|
|
Madhu Venugopal
Thats okay. Totally understand the scheduling issues. -Madhu On 8/6/14, 6:52 PM, Abhijit Kumbhare
wrote:
|
|
|
|
Prasanna Huddar
I verified(on gerrit 9393) some normal OF matches and NXM matches(as in wiki). Everything seems to work as expected.
-Prasanna
From: Rob Adams [mailto:readams@...]
For examples on use:
On Wed, Aug 6, 2014 at 9:11 AM, Rob Adams <readams@...> wrote:
I've already implemented my functionality off of the unmerged tree (and added additional work on top to make OUTPUT_REG and group table actions work). The API is definitely not pretty but it works.
-Rob
On Wed, Aug 6, 2014 at 9:09 AM, Abhijit Kumbhare <abhijitkoss@...> wrote: We had a daily scrum meeting for the OpenFlow plugin project & here are the conclusions about extensibility support:
1) https://git.opendaylight.org/gerrit/#/c/9393/ - should give us extensions... pretty for actions, less pretty for matches. The users of the project (like OVSDB, SFC) need extensions. So we will go with what we have for Helium and make the matches pretty in Lithium. 2) The instructions to try out are at https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Backlog:Extensibility#Helpful_hints_for_reviewing_https:.2F.2Fgit.opendaylight.org.2Fgerrit.2F.23.2Fc.2F9393.2F. 3) We need the following to be reviewed & tried before tomorrow by OVSDB folks (Madhu / Brent or whoever is the right person). It will be great if Rob Adams also reviews it. From the OF plugin side the reviewers are - Ed, Prasanna, Jan Medved & Abhijit. 4) We would like the reviewers to join the OpenFlow plugin scrum meeting (over IRC) tomorrow - meeting details at: https://wiki.opendaylight.org/view/Meetings#OpenFlow_Plugin. Following the meeting if all is well - we will merge the code.
Thanks, Abhijit
|
|
|
|
Abhijit Kumbhare
Thanks Prasanna!
On Thu, Aug 7, 2014 at 2:24 AM, Prasanna Huddar <prasanna.huddar@...> wrote:
|
|
|
|
Madhu Venugopal
Played with existing NXM extensions using java API (not restconf) : reg0 - 7 and ARP related. match and actions are working. This was just a very quick test. Statistics seems to be not working with extensions in place and I see a lot of trace backs. Am also developing more extensions. As Rob said the APIs aren't pretty and is not intuitive to use. But am able to code one, but it is not working. Still debugging. (Should be my error). -Madhu
On Aug 7, 2014, at 5:25 AM, Abhijit Kumbhare <abhijitkoss@...> wrote:
|
|
|
|
Abhijit Kumbhare
Prasanna has filed https://bugs.opendaylight.org/show_bug.cgi?id=1501.
On Thu, Aug 7, 2014 at 6:46 AM, Madhu Venugopal <mavenugo@...> wrote:
|
|
|
|
Rob Adams <readams@...>
Can we also merge my changes: These add support for the OUTPUT_REG action and also fix a bug where actions didn't work in group buckets. -Rob
On Thu, Aug 7, 2014 at 7:36 AM, Abhijit Kumbhare <abhijitkoss@...> wrote:
|
|
|
|
Abhijit Kumbhare
I think Prasanna should review it as he reviewed the other (9393) - if its OK for you that it is merged tonight (Prasanna is in India).
On Thu, Aug 7, 2014 at 10:38 AM, Rob Adams <readams@...> wrote:
|
|
|
|
Madhu Venugopal
Just as a datapoint, I tried these 2 patches from Rob and it works fine. -Madhu On 8/7/14, 11:45 AM, Abhijit Kumbhare
wrote:
|
|
|
|
Prasanna Huddar
I have merged the gerrits Rob -Prasanna
From: Rob Adams [mailto:readams@...]
Can we also merge my changes:
These add support for the OUTPUT_REG action and also fix a bug where actions didn't work in group buckets.
-Rob
On Thu, Aug 7, 2014 at 7:36 AM, Abhijit Kumbhare <abhijitkoss@...> wrote:
Prasanna has filed https://bugs.opendaylight.org/show_bug.cgi?id=1501.
On Thu, Aug 7, 2014 at 6:46 AM, Madhu Venugopal <mavenugo@...> wrote:
Played with existing NXM extensions using java API (not restconf) : reg0 - 7 and ARP related. match and actions are working. This was just a very quick test.
Statistics seems to be not working with extensions in place and I see a lot of trace backs.
Am also developing more extensions. As Rob said the APIs aren't pretty and is not intuitive to use. But am able to code one, but it is not working. Still debugging. (Should be my error).
|
|
|