Re: [ovsdb-gerrit] Change in ovsdb[master]: Implemented the deleteBridgeDomain method in ConfigurationSe...


Brent Salisbury
 

Awesome, thanks guys. We probably should have been more specific other
then filling out the ConfigurationService methods. Hugo, really
appreciated your review, I submitted the patch.

Thanks all!
-Brent

On 11/8/13 5:34 PM, "Punal Patel" <Punal.Patel@...> wrote:

Thank You Luis.

-----Original Message-----
From: ovsdb-dev-bounces@...
[mailto:ovsdb-dev-bounces@...] On Behalf Of Luis Gomez
Sent: November-08-13 2:30 PM
To: Madhu Venguopal; hugo@...; Brent Salisbury
Cc: ovsdb-dev@...
Subject: Re: [ovsdb-dev] [ovsdb-gerrit] Change in ovsdb[master]:
Implemented the deleteBridgeDomain method in ConfigurationSe...

Good idea, I just setup Trello for Integration group, we do not want to
step into same issue :)

-----Original Message-----
From: ovsdb-dev-bounces@...
[mailto:ovsdb-dev-bounces@...] On Behalf Of Madhu
Venguopal
Sent: Friday, November 08, 2013 2:58 AM
To: hugo@...; Brent Salisbury
Cc: ovsdb-dev@...
Subject: Re: [ovsdb-dev] [ovsdb-gerrit] Change in ovsdb[master]:
Implemented the deleteBridgeDomain method in ConfigurationSe...


It would help if we use Trello effectively to avoid effort duplication :)

-Madhu

On 11/8/13, 1:26 AM, Gerrit Code Review wrote:
From Hugo Trippaers <hugo@...>:

Hugo Trippaers has posted comments on this change.

Change subject: Implemented the deleteBridgeDomain method in
ConfigurationService
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

You beat me to it, was just working on the same thing ;-)

....................................................
File
ovsdb/src/main/java/org/opendaylight/ovsdb/plugin/ConfigurationService.ja
va
Line 606: if (tr.get(i).getError() != null &&
tr.get(i).getError().trim().length() > 0) {
With openvswitch it is possible that a transaction returns an array
with null elements. As there is only one transaction here it is not a
big risk. But for safety we should check if tr.get(i) != null


Line 877: status =
this.deleteBridgeDomain(Node.fromString(nodeName), bridgeName);
Node.fromString can return null. deleteBridgeDomain doesn't check this
resulting in an NPE. Should we check for this even though this is a
debug function?

_______________________________________________
ovsdb-dev mailing list
ovsdb-dev@...
https://lists.opendaylight.org/mailman/listinfo/ovsdb-dev
_______________________________________________
ovsdb-dev mailing list
ovsdb-dev@...
https://lists.opendaylight.org/mailman/listinfo/ovsdb-dev

Legal Disclaimer:
The information contained in this message may be privileged and
confidential. It is intended to be read only by the individual or entity
to whom it is addressed or by their designee. If the reader of this
message is not the intended recipient, you are on notice that any
distribution of this message, in any form, is strictly prohibited. If you
have received this message in error, please immediately notify the sender
and delete or destroy any copy of this message!

Join z.archive.ovsdb-dev@lists.opendaylight.org to automatically receive all group messages.