[Odlparent-dev] New SingleFeatureTest incl. TestBundleDiag

Michael Vorburger vorburger at redhat.com
Thu Jan 12 14:20:59 UTC 2017


[removing individual recipients to get this through list moderation]

On Thu, Jan 12, 2017 at 1:14 PM, Stephen Kitt <skitt at redhat.com> wrote:

> Hi Michael,
>
> On Thu, 12 Jan 2017 13:01:49 +0100
> Michael Vorburger <vorburger at redhat.com> wrote:
> > Based on this "written confirmation of certification" ;) would you be
> > able to now merge https://git.opendaylight.org/gerrit/#/c/48901/
> > soon-ish?   I'd love to see this go in ASAP now, because any delays
> > mean people will commit new changes in projects which could possibly
> > break features again - and it would be better if they got the failure
> > on their gerrits with c/48901 merged in odlparent than them merging
> > new things which break features now and then getting broken builds
> > from SFT on other gerrits later because c/48901 was merged since.
> >
> > I commit to promptly offer support to any projects with failing
> > SingleFeatureTest due to the new TestBundleDiag.
>
> This is very good news, thanks for fixing the various issues you
> encountered!
>
> Even with your tests, there's still a time-of-check-to-time-of-use
> race: there are outstanding patches which have passed Gerrit and are
> now liable to be merged without rechecking (and fail when merging). As
> a result, you need to handle this change with a weather event [0]. I'd
> suggest announcing that the patch will be merged on Monday (that's what
> we usually do for odlparent patches with large potential impact).
>

Sounds like a plan! Just created
https://wiki.opendaylight.org/view/Weather#Extended_SingleFeatureTest_incl._TestBundleDiag
; I'll send out a "[WEATHER]" email to release and dev lists in a moment.


>
> Regards,
>
> Stephen
>
> [0] https://wiki.opendaylight.org/view/Weather
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opendaylight.org/pipermail/odlparent-dev/attachments/20170112/36665c11/attachment.html>


More information about the Odlparent-dev mailing list