[sfc-dev] Why does feature odl-sfc-provider depend on odl-l2switch-hosttracker?

Edward Warnicke hagbard at gmail.com
Wed Aug 12 17:34:48 UTC 2015


How does sfc-provider consume it?  It is OF specific (in fact OVS
specific)...

Ed

On Tue, Aug 11, 2015 at 7:44 PM, Yang, Yi Y <yi.y.yang at intel.com> wrote:

> As we discussed before, it will have two consumers, sfc-provider and
> sfcofl2, currently I can’t find out a better feature/component to contain
> this piece.
>
>
>
> *From:* Edward Warnicke [mailto:hagbard at gmail.com]
> *Sent:* Wednesday, August 12, 2015 9:52 AM
>
> *To:* Yang, Yi Y
> *Cc:* sfc-dev at lists.opendaylight.org
> *Subject:* Re: [sfc-dev] Why does feature odl-sfc-provider depend on
> odl-l2switch-hosttracker?
>
>
>
> Yang,
>
>
>
> I understand, the question is does it need to be in sfc-provider (which
> *all* things, not just sfcofl2 use) or does it belong in sfcofl2 (the place
> that uses it)?
>
>
>
> Please keep in mind that SFC is multi-renderer... and sfcofl2 (while a
> very important renderer) is just *one* renderer... stuff specific to it
> should live with it.
>
> Stuff general across all SFCs should live in sfc-provider :)
>
>
>
> Ed
>
>
>
> On Tue, Aug 11, 2015 at 6:33 PM, Yang, Yi Y <yi.y.yang at intel.com> wrote:
>
> I must map ovsdb and openflow to get the real openflow port. Sfcofl2 used
> many ovsdb-related data, it must get openflow port by IP or ovsdb bridge
> node ID.
>
>
>
> Please take a look at these APIs, they are APIs we need to use.
>
>
>
>     public static Topology getOpenflowTopology() {
>
>     public static Topology getOvsdbTopology() {
>
>     public static Node getOvsdbNode(String nodeId) {
>
>     public static String getOfPortByHostIp(IpAddress ip) {
>
>     public static String getOfPortByHostMac(MacAddress mac) {
>
>     public static Link getLink(String srcNodeId, String dstNodeId) {
>
>     public static String getLinkSrcPort(Link link) {
>
>     public static String getLinkDstPort(Link link) {
>
>     public static String getOfNodeIdByDpid(String dpid) {
>
>     public static String getDpidByOfNodeId(String ofNodeId) {
>
>     public static String getOfNodeIdByOvsdbNodeId(String ovsdbNodeId) {
>
>     public static String getOfNodeIdByVMAddress(IpAddress ip) {
>
>     public static String getOfNodeIdByVMAddress(MacAddress mac) {
>
>     public static String getOvsdbNodeIdByDpid(String dpid) {
>
>     public static String getOvsdbNodeIdByVMAddress(IpAddress ip) {
>
>     public static String getOvsdbNodeIdByVMAddress(MacAddress mac) {
>
>
>
> *From:* Edward Warnicke [mailto:hagbard at gmail.com]
> *Sent:* Wednesday, August 12, 2015 9:13 AM
>
>
> *To:* Yang, Yi Y
> *Cc:* sfc-dev at lists.opendaylight.org
> *Subject:* Re: [sfc-dev] Why does feature odl-sfc-provider depend on
> odl-l2switch-hosttracker?
>
>
>
> Wouldn't it make more sense, as its simply a Util class for Hostracker,
> for it to live in l2switch?
>
>
>
> Also... I can see the general need to compute the shortest path between
> two topology nodes... but I don't understand why you need
>
> more than the topology model for that...
>
>
>
> Ed
>
>
>
> P.S.  I've added you to this commit
> https://git.opendaylight.org/gerrit/#/c/25186/ and self -1ed so we can
> talk about it there :)
>
>
>
> On Tue, Aug 11, 2015 at 5:59 PM, Yang, Yi Y <yi.y.yang at intel.com> wrote:
>
> This is just part of the whole effort, the following commits will be
> coming.
>
>
>
> *From:* Edward Warnicke [mailto:hagbard at gmail.com]
> *Sent:* Wednesday, August 12, 2015 6:43 AM
>
>
> *To:* Yang, Yi Y
> *Cc:* sfc-dev at lists.opendaylight.org
> *Subject:* Re: [sfc-dev] Why does feature odl-sfc-provider depend on
> odl-l2switch-hosttracker?
>
>
>
> Yi,
>
>
>
> Question... digging into this some more, I can see
> SfcNetworkTopologyUtils... but nothing calls any of its methods... is this
> class in use?
>
> If not, is it still needed?  If its still needed, who do you expect to use
> it?
>
>
>
> Ed
>
>
>
> On Tue, Aug 4, 2015 at 6:51 PM, Yang, Yi Y <yi.y.yang at intel.com> wrote:
>
> No, sfcofl2 (openflow renderer in sfc) will use the RSP created by
> selection algorithm to program Openflow tables for every SFF the RSP goes
> through. SFC has several selection algorithms to create RSP, including Load
> Balance, Round Robin, Random and the Shortest Path. The shortest path means
> the distance between SFs the RSP are shortest, so the traffic can faster
> reach the destination.
>
>
>
> *From:* Edward Warnicke [mailto:hagbard at gmail.com]
> *Sent:* Wednesday, August 05, 2015 9:40 AM
>
>
> *To:* Yang, Yi Y
> *Cc:* sfc-dev at lists.opendaylight.org
> *Subject:* Re: [sfc-dev] Why does feature odl-sfc-provider depend on
> odl-l2switch-hosttracker?
>
>
>
> OK... but that only makes sense for OpenFlow Renderers... correct?
>
>
>
> Ed
>
>
>
> On Tue, Aug 4, 2015 at 6:33 PM, Yang, Yi Y <yi.y.yang at intel.com> wrote:
>
> It doesn’t use l2switch, l2switch will help add host nodes in Openflow
> network topology. The shortest path algorithm will use a full network
> topology to calculate the best service function path for a given service
> function chain.
>
>
>
> *From:* Edward Warnicke [mailto:hagbard at gmail.com]
> *Sent:* Wednesday, August 05, 2015 9:29 AM
> *To:* Yang, Yi Y
> *Cc:* sfc-dev at lists.opendaylight.org
> *Subject:* Re: [sfc-dev] Why does feature odl-sfc-provider depend on
> odl-l2switch-hosttracker?
>
>
>
> How is the SF selection algorithm using hosttracker? (not objecting,
> curious ;) ).
>
>
>
> Ed
>
>
>
> On Tue, Aug 4, 2015 at 6:18 PM, Yang, Yi Y <yi.y.yang at intel.com> wrote:
>
> SF selection algorithms are implemented in sfc-provider, the shortest path
> selection algorithm needs it. maybe sfc-provider isn’t the best place to
> accommodate it, but I don’t think sfc-ovs and sfcofl2 are better than
> sfc-provider. This piece includes OVSDB network topology APIs and Openflow
> network topology APIs.
>
>
>
> *From:* Edward Warnicke [mailto:hagbard at gmail.com]
> *Sent:* Wednesday, August 05, 2015 9:08 AM
> *To:* Yang, Yi Y
> *Cc:* sfc-dev at lists.opendaylight.org
> *Subject:* Re: [sfc-dev] Why does feature odl-sfc-provider depend on
> odl-l2switch-hosttracker?
>
>
>
> That's fair... question though... why is it in the core instead of in
> sfc-ovs or sfc-ofl2 ?
>
>
>
> Ed
>
>
>
> On Tue, Aug 4, 2015 at 5:27 PM, Yang, Yi Y <yi.y.yang at intel.com> wrote:
>
> Hi, Ed
>
>
>
> I did that, we can get Openflow port and IP of a SF from MD-SAL network
> topology by l2switch, we need to use these network topology to program
> SFF’s openflow tables.
>
>
>
> *From:* sfc-dev-bounces at lists.opendaylight.org [mailto:
> sfc-dev-bounces at lists.opendaylight.org] *On Behalf Of *Edward Warnicke
> *Sent:* Wednesday, August 05, 2015 12:56 AM
> *To:* sfc-dev at lists.opendaylight.org
> *Subject:* [sfc-dev] Why does feature odl-sfc-provider depend on
> odl-l2switch-hosttracker?
>
>
>
> Why does feature odl-sfc-provider depend on odl-l2switch-hosttracker?
>
>
>
> I'm not saying it shouldn't... I'm just trying to understand why it does ;)
>
>
>
> Ed
>
>
>
>
>
>
>
>
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opendaylight.org/pipermail/sfc-dev/attachments/20150812/efcedf52/attachment-0001.html>


More information about the sfc-dev mailing list